Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1278935 > unrolled thread
| Started by | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| First post | 2015-11-27 20:50 +0100 |
| Last post | 2015-11-30 13:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v3] clocksource: arm_global_timer: fix suspend resume Grygorii Strashko <grygorii.strashko@ti.com> - 2015-11-27 20:50 +0100
Re: [PATCH v3] clocksource: arm_global_timer: fix suspend resume "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2015-11-30 01:40 +0100
Re: [PATCH v3] clocksource: arm_global_timer: fix suspend resume Grygorii Strashko <grygorii.strashko@ti.com> - 2015-11-30 13:00 +0100
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2015-11-27 20:50 +0100 |
| Subject | [PATCH v3] clocksource: arm_global_timer: fix suspend resume |
| Message-ID | <qzxbQ-75z-11@gated-at.bofh.it> |
Now the System stall is observed on TI AM437x based board
(am437x-gp-evm) during resuming from System suspend when ARM Global
timer is selected as clocksource device (CPUIdle not enabled) - SysRq are working,
but nothing else.
The reason of stall is that ARM Global timer loses its contexts during
System suspend:
GT_CONTROL.TIMER_ENABLE = 0 (unbanked)
GT_COUNTERx = 0
Hence, update ARM Global timer driver to reflect above behaviour
- re-enable ARM Global timer on resume GT_CONTROL.TIMER_ENABLE = 1.
CC: Arnd Bergmann <arnd@arndb.de>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
Changes in v3:
- dropped all DT specific code
Changes in v2:
- suspend/resume simplified: nothing is stored any more and
ARM GT just re-enabled
Link on v2:
https://lkml.org/lkml/2015/11/20/355
Link on v1:
https://lkml.org/lkml/2015/11/13/456
drivers/clocksource/arm_global_timer.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
index a2cb6fa..10d1417 100644
--- a/drivers/clocksource/arm_global_timer.c
+++ b/drivers/clocksource/arm_global_timer.c
@@ -195,12 +195,19 @@ static cycle_t gt_clocksource_read(struct clocksource *cs)
return gt_counter_read();
}
+static void gt_resume(struct clocksource *cs)
+{
+ /* re-enable timer on resume */
+ writel(GT_CONTROL_TIMER_ENABLE, gt_base + GT_CONTROL);
+}
+
static struct clocksource gt_clocksource = {
.name = "arm_global_timer",
.rating = 300,
.read = gt_clocksource_read,
.mask = CLOCKSOURCE_MASK(64),
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
+ .resume = gt_resume,
};
#ifdef CONFIG_CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
--
2.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> |
|---|---|
| Date | 2015-11-30 01:40 +0100 |
| Message-ID | <qAkFz-4GC-7@gated-at.bofh.it> |
| In reply to | #1278935 |
On 11/27/15 11:47 AM, Grygorii Strashko wrote:
> Now the System stall is observed on TI AM437x based board
> (am437x-gp-evm) during resuming from System suspend when ARM Global
> timer is selected as clocksource device (CPUIdle not enabled) - SysRq are working,
> but nothing else.
>
> The reason of stall is that ARM Global timer loses its contexts during
> System suspend:
> GT_CONTROL.TIMER_ENABLE = 0 (unbanked)
> GT_COUNTERx = 0
>
> Hence, update ARM Global timer driver to reflect above behaviour
> - re-enable ARM Global timer on resume GT_CONTROL.TIMER_ENABLE = 1.
>
> CC: Arnd Bergmann <arnd@arndb.de>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> Changes in v3:
> - dropped all DT specific code
> Changes in v2:
> - suspend/resume simplified: nothing is stored any more and
> ARM GT just re-enabled
> Link on v2:
> https://lkml.org/lkml/2015/11/20/355
> Link on v1:
> https://lkml.org/lkml/2015/11/13/456
>
Looks reasonable to me.
> drivers/clocksource/arm_global_timer.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
> index a2cb6fa..10d1417 100644
> --- a/drivers/clocksource/arm_global_timer.c
> +++ b/drivers/clocksource/arm_global_timer.c
> @@ -195,12 +195,19 @@ static cycle_t gt_clocksource_read(struct clocksource *cs)
> return gt_counter_read();
> }
>
> +static void gt_resume(struct clocksource *cs)
> +{
> + /* re-enable timer on resume */
> + writel(GT_CONTROL_TIMER_ENABLE, gt_base + GT_CONTROL);
Check if its disabled before enabling it.
Other than that,
Reviewed-by: Santosh Shilimkar <ssantosh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2015-11-30 13:00 +0100 |
| Message-ID | <qAvhF-38r-31@gated-at.bofh.it> |
| In reply to | #1279482 |
On 11/30/2015 02:29 AM, santosh.shilimkar@oracle.com wrote:
> On 11/27/15 11:47 AM, Grygorii Strashko wrote:
>> Now the System stall is observed on TI AM437x based board
>> (am437x-gp-evm) during resuming from System suspend when ARM Global
>> timer is selected as clocksource device (CPUIdle not enabled) - SysRq
>> are working,
>> but nothing else.
>>
>> The reason of stall is that ARM Global timer loses its contexts during
>> System suspend:
>> GT_CONTROL.TIMER_ENABLE = 0 (unbanked)
>> GT_COUNTERx = 0
>>
>> Hence, update ARM Global timer driver to reflect above behaviour
>> - re-enable ARM Global timer on resume GT_CONTROL.TIMER_ENABLE = 1.
>>
>> CC: Arnd Bergmann <arnd@arndb.de>
>> Cc: John Stultz <john.stultz@linaro.org>
>> Cc: Felipe Balbi <balbi@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Santosh Shilimkar <ssantosh@kernel.org>
>> Cc: Marc Zyngier <marc.zyngier@arm.com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> Changes in v3:
>> - dropped all DT specific code
>> Changes in v2:
>> - suspend/resume simplified: nothing is stored any more and
>> ARM GT just re-enabled
>> Link on v2:
>> https://lkml.org/lkml/2015/11/20/355
>> Link on v1:
>> https://lkml.org/lkml/2015/11/13/456
>>
> Looks reasonable to me.
>> drivers/clocksource/arm_global_timer.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/clocksource/arm_global_timer.c
>> b/drivers/clocksource/arm_global_timer.c
>> index a2cb6fa..10d1417 100644
>> --- a/drivers/clocksource/arm_global_timer.c
>> +++ b/drivers/clocksource/arm_global_timer.c
>> @@ -195,12 +195,19 @@ static cycle_t gt_clocksource_read(struct
>> clocksource *cs)
>> return gt_counter_read();
>> }
>>
>> +static void gt_resume(struct clocksource *cs)
>> +{
>> + /* re-enable timer on resume */
>> + writel(GT_CONTROL_TIMER_ENABLE, gt_base + GT_CONTROL);
>
> Check if its disabled before enabling it.
> Other than that,
> Reviewed-by: Santosh Shilimkar <ssantosh@kernel.org>
Sure, I'll update.
Thanks.
--
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web