Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1280430 > unrolled thread
| Started by | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| First post | 2015-12-01 01:40 +0100 |
| Last post | 2015-12-01 17:30 +0100 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] uselib: default depending if libc5 was used Andrew Morton <akpm@linux-foundation.org> - 2015-12-01 01:40 +0100
Re: [PATCH v2] uselib: default depending if libc5 was used Josh Triplett <josh@joshtriplett.org> - 2015-12-01 02:10 +0100
Re: [PATCH v2] uselib: default depending if libc5 was used Geert Uytterhoeven <geert@linux-m68k.org> - 2015-12-01 09:50 +0100
Re: [PATCH v2] uselib: default depending if libc5 was used Riku Voipio <riku.voipio@linaro.org> - 2015-12-01 13:40 +0100
Re: [PATCH v2] uselib: default depending if libc5 was used Josh Triplett <josh@joshtriplett.org> - 2015-12-01 17:30 +0100
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Date | 2015-12-01 01:40 +0100 |
| Subject | Re: [PATCH v2] uselib: default depending if libc5 was used |
| Message-ID | <qAH97-2nP-7@gated-at.bofh.it> |
On Fri, 27 Nov 2015 12:07:10 -0800 Josh Triplett <josh@joshtriplett.org> wrote: > On Fri, Nov 27, 2015 at 01:14:20PM +0200, Riku Voipio wrote: > > uselib hasn't been used since libc5; glibc does not use it. > > Deprecate uselib a bit more, by making the default y only > > if libc5 was widely used on the plaform. > > > > This makes arm64 kernel built with defconfig slighly smaller > > > > bloat-o-meter: > > add/remove: 0/3 grow/shrink: 0/2 up/down: 0/-1390 (-1390) > > function old new delta > > kernel_config_data 18164 18162 -2 > > uselib_flags 20 - -20 > > padzero 216 192 -24 > > sys_uselib 380 - -380 > > load_elf_library 964 - -964 > > One question below. > > > v2: Disable on X86_64 if no 32bit support > > init/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/init/Kconfig b/init/Kconfig > > index c24b6f7..a4bc657 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -285,7 +285,7 @@ config FHANDLE > > > > config USELIB > > bool "uselib syscall" > > - default y > > + def_bool ALPHA || M68K || SPARC || X86_32 || (X86_64 && IA32_EMULATION) > > IA32_EMULATION depends on X86_64, so doesn't that reduce to: > def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION It's a bit old fashioned to add an expression like this at the definition site anyway. The cool new thing is to do def_bool ARCH_WANT_USELIB then go off and define ARCH_WANT_USELIB in the appropriate places in the per-arch Kconfig files. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Josh Triplett <josh@joshtriplett.org> |
|---|---|
| Date | 2015-12-01 02:10 +0100 |
| Message-ID | <qAHC9-2Om-7@gated-at.bofh.it> |
| In reply to | #1280430 |
On Mon, Nov 30, 2015 at 04:31:29PM -0800, Andrew Morton wrote: > On Fri, 27 Nov 2015 12:07:10 -0800 Josh Triplett <josh@joshtriplett.org> wrote: > > > On Fri, Nov 27, 2015 at 01:14:20PM +0200, Riku Voipio wrote: > > > uselib hasn't been used since libc5; glibc does not use it. > > > Deprecate uselib a bit more, by making the default y only > > > if libc5 was widely used on the plaform. > > > > > > This makes arm64 kernel built with defconfig slighly smaller > > > > > > bloat-o-meter: > > > add/remove: 0/3 grow/shrink: 0/2 up/down: 0/-1390 (-1390) > > > function old new delta > > > kernel_config_data 18164 18162 -2 > > > uselib_flags 20 - -20 > > > padzero 216 192 -24 > > > sys_uselib 380 - -380 > > > load_elf_library 964 - -964 > > > > One question below. > > > > > v2: Disable on X86_64 if no 32bit support > > > init/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/init/Kconfig b/init/Kconfig > > > index c24b6f7..a4bc657 100644 > > > --- a/init/Kconfig > > > +++ b/init/Kconfig > > > @@ -285,7 +285,7 @@ config FHANDLE > > > > > > config USELIB > > > bool "uselib syscall" > > > - default y > > > + def_bool ALPHA || M68K || SPARC || X86_32 || (X86_64 && IA32_EMULATION) > > > > IA32_EMULATION depends on X86_64, so doesn't that reduce to: > > def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION > > It's a bit old fashioned to add an expression like this at the > definition site anyway. The cool new thing is to do > > def_bool ARCH_WANT_USELIB > > then go off and define ARCH_WANT_USELIB in the appropriate places in > the per-arch Kconfig files. Good point; that does seem cleaner. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2015-12-01 09:50 +0100 |
| Message-ID | <qAONk-7gM-3@gated-at.bofh.it> |
| In reply to | #1280430 |
Hi Andrew,
On Tue, Dec 1, 2015 at 1:31 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 27 Nov 2015 12:07:10 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
>> On Fri, Nov 27, 2015 at 01:14:20PM +0200, Riku Voipio wrote:
>> > uselib hasn't been used since libc5; glibc does not use it.
>> > Deprecate uselib a bit more, by making the default y only
>> > if libc5 was widely used on the plaform.
>> >
>> > This makes arm64 kernel built with defconfig slighly smaller
>> >
>> > bloat-o-meter:
>> > add/remove: 0/3 grow/shrink: 0/2 up/down: 0/-1390 (-1390)
>> > function old new delta
>> > kernel_config_data 18164 18162 -2
>> > uselib_flags 20 - -20
>> > padzero 216 192 -24
>> > sys_uselib 380 - -380
>> > load_elf_library 964 - -964
>>
>> One question below.
>>
>> > v2: Disable on X86_64 if no 32bit support
>> > init/Kconfig | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/init/Kconfig b/init/Kconfig
>> > index c24b6f7..a4bc657 100644
>> > --- a/init/Kconfig
>> > +++ b/init/Kconfig
>> > @@ -285,7 +285,7 @@ config FHANDLE
>> >
>> > config USELIB
>> > bool "uselib syscall"
>> > - default y
>> > + def_bool ALPHA || M68K || SPARC || X86_32 || (X86_64 && IA32_EMULATION)
>>
>> IA32_EMULATION depends on X86_64, so doesn't that reduce to:
>> def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION
>
> It's a bit old fashioned to add an expression like this at the
> definition site anyway. The cool new thing is to do
>
> def_bool ARCH_WANT_USELIB
>
> then go off and define ARCH_WANT_USELIB in the appropriate places in
> the per-arch Kconfig files.
That's useful for new to-be-implemented features, but this dependency list is
(hopefully) cast in stone. No new architecture should need this.
So I see no reason to clutter up more Kconfig files.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Riku Voipio <riku.voipio@linaro.org> |
|---|---|
| Date | 2015-12-01 13:40 +0100 |
| Message-ID | <qASnU-1b9-15@gated-at.bofh.it> |
| In reply to | #1280647 |
On 1 December 2015 at 10:46, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Tue, Dec 1, 2015 at 1:31 AM, Andrew Morton <akpm@linux-foundation.org> wrote: >> On Fri, 27 Nov 2015 12:07:10 -0800 Josh Triplett <josh@joshtriplett.org> wrote: >>> IA32_EMULATION depends on X86_64, so doesn't that reduce to: >>> def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION Ok. looks cleaner to me. >> It's a bit old fashioned to add an expression like this at the >> definition site anyway. The cool new thing is to do >> >> def_bool ARCH_WANT_USELIB >> >> then go off and define ARCH_WANT_USELIB in the appropriate places in >> the per-arch Kconfig files. > > That's useful for new to-be-implemented features, but this dependency list is > (hopefully) cast in stone. No new architecture should need this. > So I see no reason to clutter up more Kconfig files. I agree. Splitting oneline patch to a patch that changes 5 files around kernel tree only risks merge conflicts in this case. Riku -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Josh Triplett <josh@joshtriplett.org> |
|---|---|
| Date | 2015-12-01 17:30 +0100 |
| Message-ID | <qAVYu-3yp-21@gated-at.bofh.it> |
| In reply to | #1280822 |
On Tue, Dec 01, 2015 at 02:35:24PM +0200, Riku Voipio wrote: > On 1 December 2015 at 10:46, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Tue, Dec 1, 2015 at 1:31 AM, Andrew Morton <akpm@linux-foundation.org> wrote: > >> On Fri, 27 Nov 2015 12:07:10 -0800 Josh Triplett <josh@joshtriplett.org> wrote: > >>> IA32_EMULATION depends on X86_64, so doesn't that reduce to: > >>> def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION > > Ok. looks cleaner to me. > > >> It's a bit old fashioned to add an expression like this at the > >> definition site anyway. The cool new thing is to do > >> > >> def_bool ARCH_WANT_USELIB > >> > >> then go off and define ARCH_WANT_USELIB in the appropriate places in > >> the per-arch Kconfig files. > > > > That's useful for new to-be-implemented features, but this dependency list is > > (hopefully) cast in stone. No new architecture should need this. > > So I see no reason to clutter up more Kconfig files. > > I agree. Splitting oneline patch to a patch that changes 5 files around kernel > tree only risks merge conflicts in this case. True; I take back what I said about that approach being cleaner. It does ease maintenance in cases where the list may change, but in this case, the list should never change again. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web