Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280687 > unrolled thread

[PATCH] HID: lg: restrict filtering out of first interface to G29 only

Back to article view | Back to linux.kernel

Contents

  [PATCH] HID: lg: restrict filtering out of first interface to G29 only Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2015-12-01 10:30 +0100
    Re: [PATCH] HID: lg: restrict filtering out of first interface to  G29 only Jiri Kosina <jikos@kernel.org> - 2015-12-02 15:00 +0100

#1280687 — [PATCH] HID: lg: restrict filtering out of first interface to G29 only

Looks like 29fae1c85 ("HID: logitech: Add support for G29") was a little
bit aggressive and broke other devices.

Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=108121

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---

Hi Jiri,

as reported in #108121, this is 4.4-rc material. At least 2 people already
started complaining about it on the mailing list, so it should definitively
be fixed before 4.4 is out.

Cheers,
Benjamin

 drivers/hid/hid-lg.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index c20ac76..c690fae 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -665,8 +665,9 @@ static int lg_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	struct lg_drv_data *drv_data;
 	int ret;
 
-	/* Only work with the 1st interface (G29 presents multiple) */
-	if (iface_num != 0) {
+	/* G29 only work with the 1st interface */
+	if ((hdev->product == USB_DEVICE_ID_LOGITECH_G29_WHEEL) &&
+	    (iface_num != 0)) {
 		dbg_hid("%s: ignoring ifnum %d\n", __func__, iface_num);
 		return -ENODEV;
 	}
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1281812 — Re: [PATCH] HID: lg: restrict filtering out of first interface to G29 only

On Tue, 1 Dec 2015, Benjamin Tissoires wrote:

> Looks like 29fae1c85 ("HID: logitech: Add support for G29") was a little
> bit aggressive and broke other devices.
> 
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=108121
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> 
> Hi Jiri,
> 
> as reported in #108121, this is 4.4-rc material. At least 2 people already
> started complaining about it on the mailing list, so it should definitively
> be fixed before 4.4 is out.

Applied to for-4.4/upstream-fixes, thanks.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web