Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1280671 > unrolled thread
| Started by | Sunil Goutham <sunil.kovvuri@gmail.com> |
|---|---|
| First post | 2015-12-01 10:20 +0100 |
| Last post | 2015-12-01 17:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver. Sunil Goutham <sunil.kovvuri@gmail.com> - 2015-12-01 10:20 +0100
Re: [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-12-01 14:20 +0100
Re: [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver. Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2015-12-01 17:30 +0100
| From | Sunil Goutham <sunil.kovvuri@gmail.com> |
|---|---|
| Date | 2015-12-01 10:20 +0100 |
| Subject | [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver. |
| Message-ID | <qAPgm-7I5-19@gated-at.bofh.it> |
From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
---
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 +++
drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 180aa9f..1fb72dd 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
struct bgx *bgx = NULL;
u8 lmac;
+ /*Load octeon mdio driver*/
+ octeon_mdiobus_force_mod_depencency();
+
bgx = devm_kzalloc(dev, sizeof(*bgx), GFP_KERNEL);
if (!bgx)
return -ENOMEM;
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.h b/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
index 07b7ec6..89a02fa 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.h
@@ -182,6 +182,7 @@ enum MCAST_MODE {
#define BCAST_ACCEPT 1
#define CAM_ACCEPT 1
+void octeon_mdiobus_force_mod_depencency(void);
void bgx_add_dmac_addr(u64 dmac, int node, int bgx_idx, int lmac);
unsigned bgx_get_map(int node);
int bgx_get_lmac_count(int node, int bgx);
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2015-12-01 14:20 +0100 |
| Subject | Re: [PATCH 1/6] net: thunderx: Force to load octeon-mdio before bgx driver. |
| Message-ID | <qAT0C-1GT-23@gated-at.bofh.it> |
| In reply to | #1280671 |
Hello.
On 12/1/2015 12:13 PM, Sunil Goutham wrote:
> From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
>
> Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com>
> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
> ---
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 +++
> drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 1 +
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index 180aa9f..1fb72dd 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> struct bgx *bgx = NULL;
> u8 lmac;
>
> + /*Load octeon mdio driver*/
Please insert spaces after /* and before */ (unless it's a common comment
style in this driver).
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sunil Kovvuri <sunil.kovvuri@gmail.com> |
|---|---|
| Date | 2015-12-01 17:30 +0100 |
| Message-ID | <qAVYu-3yp-25@gated-at.bofh.it> |
| In reply to | #1280858 |
Thanks a lot, will fix and repost the patch. On Tue, Dec 1, 2015 at 6:47 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > On 12/1/2015 12:13 PM, Sunil Goutham wrote: > >> From: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com> >> >> Signed-off-by: Thanneeru Srinivasulu <tsrinivasulu@caviumnetworks.com> >> Signed-off-by: Sunil Goutham <sgoutham@cavium.com> >> --- >> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 3 +++ >> drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 1 + >> 2 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> index 180aa9f..1fb72dd 100644 >> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c >> @@ -1009,6 +1009,9 @@ static int bgx_probe(struct pci_dev *pdev, const >> struct pci_device_id *ent) >> struct bgx *bgx = NULL; >> u8 lmac; >> >> + /*Load octeon mdio driver*/ > > > Please insert spaces after /* and before */ (unless it's a common comment > style in this driver). > > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web