Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1280222 > unrolled thread
| Started by | Kevin Hilman <khilman@kernel.org> |
|---|---|
| First post | 2015-11-30 20:30 +0100 |
| Last post | 2015-11-30 22:10 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/7] ARM: dts: qcom: msm8974-honami: Define pinctrl state for blsp_uart2 Kevin Hilman <khilman@kernel.org> - 2015-11-30 20:30 +0100
Re: [PATCH 1/7] ARM: dts: qcom: msm8974-honami: Define pinctrl state for blsp_uart2 Bjorn Andersson <bjorn@kryo.se> - 2015-11-30 21:20 +0100
Re: [PATCH 1/7] ARM: dts: qcom: msm8974-honami: Define pinctrl state for blsp_uart2 Andy Gross <agross@codeaurora.org> - 2015-11-30 22:10 +0100
| From | Kevin Hilman <khilman@kernel.org> |
|---|---|
| Date | 2015-11-30 20:30 +0100 |
| Subject | Re: [PATCH 1/7] ARM: dts: qcom: msm8974-honami: Define pinctrl state for blsp_uart2 |
| Message-ID | <qACj8-7Iu-13@gated-at.bofh.it> |
On Tue, Oct 20, 2015 at 9:57 PM, Bjorn Andersson
<bjorn.andersson@sonymobile.com> wrote:
> Make sure the blsp1_uart2 pins are in the correct state for the uart.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
kernelci.org has been detecting boot failures on my z1 since
next-20151120[1] and I finally got around to bisecting, which pointed
to this patch which is in next in the for of commit 14cd83b824aa ARM:
dts: qcom: msm8974-honami: Define pinctrl state for blsp_uart2
That commit doesn't revert cleanly on top of next-20151130, but
manually removing the stuff added in this patch, next-20151130 boots
fine on the z1.
Kevin
[1] http://kernelci.org/boot/qcom-msm8974-sony-xperia-honami/job/next/kernel/next-20151127/defconfig/multi_v7_defconfig/lab/lab-khilman/?_id=5658061359b5140196b5fd2f
> ---
> .../boot/dts/qcom-msm8974-sony-xperia-honami.dts | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dts b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dts
> index 016f9ad9392a..6f7e4ef4ccf7 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dts
> @@ -23,6 +23,29 @@
> &soc {
> serial@f991e000 {
> status = "ok";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&blsp1_uart2_pin_a>;
> + };
> +
> + pinctrl@fd510000 {
> + blsp1_uart2_pin_a: blsp1-uart2-pin-active {
> + rx {
> + pins = "gpio5";
> + function = "blsp_uart2";
> +
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + tx {
> + pins = "gpio4";
> + function = "blsp_uart2";
> +
> + drive-strength = <4>;
> + bias-disable;
> + };
> + };
> };
> };
>
> --
> 2.4.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Bjorn Andersson <bjorn@kryo.se> |
|---|---|
| Date | 2015-11-30 21:20 +0100 |
| Message-ID | <qAD5w-8hq-13@gated-at.bofh.it> |
| In reply to | #1280222 |
On Mon, Nov 30, 2015 at 11:23 AM, Kevin Hilman <khilman@kernel.org> wrote: > On Tue, Oct 20, 2015 at 9:57 PM, Bjorn Andersson > <bjorn.andersson@sonymobile.com> wrote: >> Make sure the blsp1_uart2 pins are in the correct state for the uart. >> >> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > > kernelci.org has been detecting boot failures on my z1 since > next-20151120[1] and I finally got around to bisecting, which pointed > to this patch which is in next in the for of commit 14cd83b824aa ARM: > dts: qcom: msm8974-honami: Define pinctrl state for blsp_uart2 > > That commit doesn't revert cleanly on top of next-20151130, but > manually removing the stuff added in this patch, next-20151130 boots > fine on the z1. > > Kevin > > [1] http://kernelci.org/boot/qcom-msm8974-sony-xperia-honami/job/next/kernel/next-20151127/defconfig/multi_v7_defconfig/lab/lab-khilman/?_id=5658061359b5140196b5fd2f Thanks Kevin, I did see these too. But at the same time, as far as I can see, the qcom_defconfig boots just fine - indicating that this particular commit would not be the cause. I'll fire up some builds to figure out what's going on. PS. I believe earlycon would be more helpful than earlyprintk on the multi platform build command line... Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Andy Gross <agross@codeaurora.org> |
|---|---|
| Date | 2015-11-30 22:10 +0100 |
| Message-ID | <qADRT-nK-11@gated-at.bofh.it> |
| In reply to | #1280250 |
On Mon, Nov 30, 2015 at 12:19:13PM -0800, Bjorn Andersson wrote: > On Mon, Nov 30, 2015 at 11:23 AM, Kevin Hilman <khilman@kernel.org> wrote: > > On Tue, Oct 20, 2015 at 9:57 PM, Bjorn Andersson > > <bjorn.andersson@sonymobile.com> wrote: > >> Make sure the blsp1_uart2 pins are in the correct state for the uart. > >> > >> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > > > > kernelci.org has been detecting boot failures on my z1 since > > next-20151120[1] and I finally got around to bisecting, which pointed > > to this patch which is in next in the for of commit 14cd83b824aa ARM: > > dts: qcom: msm8974-honami: Define pinctrl state for blsp_uart2 > > > > That commit doesn't revert cleanly on top of next-20151130, but > > manually removing the stuff added in this patch, next-20151130 boots > > fine on the z1. > > > > Kevin > > > > [1] http://kernelci.org/boot/qcom-msm8974-sony-xperia-honami/job/next/kernel/next-20151127/defconfig/multi_v7_defconfig/lab/lab-khilman/?_id=5658061359b5140196b5fd2f > > Thanks Kevin, > > I did see these too. But at the same time, as far as I can see, the > qcom_defconfig boots just fine - indicating that this particular > commit would not be the cause. > > I'll fire up some builds to figure out what's going on. I threw the extra config options that qcom_defconfig had on it on top of my next branch. I hadn't seen any kernel ci runs on that yet. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web