Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1278810 > unrolled thread

[PATCH] evm: EVM_LOAD_X509 depends on EVM

Started byArnd Bergmann <arnd@arndb.de>
First post2015-11-27 15:00 +0100
Last post2015-11-30 20:20 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] evm: EVM_LOAD_X509 depends on EVM Arnd Bergmann <arnd@arndb.de> - 2015-11-27 15:00 +0100
    Re: [PATCH] evm: EVM_LOAD_X509 depends on EVM Mimi Zohar <zohar@linux.vnet.ibm.com> - 2015-11-30 20:20 +0100

#1278810 — [PATCH] evm: EVM_LOAD_X509 depends on EVM

FromArnd Bergmann <arnd@arndb.de>
Date2015-11-27 15:00 +0100
Subject[PATCH] evm: EVM_LOAD_X509 depends on EVM
Message-ID<qzrJ8-3Bb-19@gated-at.bofh.it>
The newly added EVM_LOAD_X509 code can be configured even if
CONFIG_EVM is disabled, but that causes a link error:

security/built-in.o: In function `integrity_load_keys':
digsig_asymmetric.c:(.init.text+0x400): undefined reference to `evm_load_x509'

This adds a Kconfig dependency to ensure it is only enabled when
CONFIG_EVM is set as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7f753c992343 ("evm: load x509 certificate from the kernel")
---
Found on yesterday's linux-next with ARM randconfig builds

diff --git a/security/integrity/evm/Kconfig b/security/integrity/evm/Kconfig
index b1433e9cd8cb..87e83adf4c6e 100644
--- a/security/integrity/evm/Kconfig
+++ b/security/integrity/evm/Kconfig
@@ -44,7 +44,7 @@ config EVM_EXTRA_SMACK_XATTRS
 
 config EVM_LOAD_X509
 	bool "Load X509 certificate to the '.evm' trusted keyring"
-	depends on INTEGRITY_TRUSTED_KEYRING
+	depends on EVM && INTEGRITY_TRUSTED_KEYRING
 	default n
 	help
 	   Load X509 certificate to the '.evm' trusted keyring.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1280214

FromMimi Zohar <zohar@linux.vnet.ibm.com>
Date2015-11-30 20:20 +0100
Message-ID<qAC9r-7Fj-3@gated-at.bofh.it>
In reply to#1278810
On Fri, 2015-11-27 at 14:52 +0100, Arnd Bergmann wrote:
> The newly added EVM_LOAD_X509 code can be configured even if
> CONFIG_EVM is disabled, but that causes a link error:
> 
> security/built-in.o: In function `integrity_load_keys':
> digsig_asymmetric.c:(.init.text+0x400): undefined reference to `evm_load_x509'
> 
> This adds a Kconfig dependency to ensure it is only enabled when
> CONFIG_EVM is set as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7f753c992343 ("evm: load x509 certificate from the kernel")

Thanks for the patch!

Mimi

> ---
> Found on yesterday's linux-next with ARM randconfig builds
> 
> diff --git a/security/integrity/evm/Kconfig b/security/integrity/evm/Kconfig
> index b1433e9cd8cb..87e83adf4c6e 100644
> --- a/security/integrity/evm/Kconfig
> +++ b/security/integrity/evm/Kconfig
> @@ -44,7 +44,7 @@ config EVM_EXTRA_SMACK_XATTRS
> 
>  config EVM_LOAD_X509
>  	bool "Load X509 certificate to the '.evm' trusted keyring"
> -	depends on INTEGRITY_TRUSTED_KEYRING
> +	depends on EVM && INTEGRITY_TRUSTED_KEYRING
>  	default n
>  	help
>  	   Load X509 certificate to the '.evm' trusted keyring.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web