Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1278410 > unrolled thread

Re: [PATCH] drivers:pci:hotplug Fix space prohibited between function name and open parenthesis '('

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] drivers:pci:hotplug Fix space prohibited between  function name and open parenthesis '(' Joe Perches <joe@perches.com> - 2015-11-26 20:40 +0100
    Re: [PATCH] drivers:pci:hotplug Fix space prohibited between function name and open parenthesis '(' sasa bogicevic <brutallesale@gmail.com> - 2015-11-29 09:50 +0100

#1278410 — Re: [PATCH] drivers:pci:hotplug Fix space prohibited between function name and open parenthesis '('

On Thu, 2015-11-26 at 16:50 +0100, Bogicevic Sasa wrote:
> This fixes all errors "space prohibited between function name and
> open parenthesis '(' " in all files in drivers/pci/hotplug folder

It's good when sending this sort of patch to add a bit of
description like "git diff -w shows no differences" and that
using scripts/objdiff also shows no difference.

Doing so shows that you've done a bit more than a mechanical
transformation using something like:

$ ./scripts/checkpatch -f --types=spacing --fix-inplace <files>

and that you have verified your changes too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1279296 — Re: [PATCH] drivers:pci:hotplug Fix space prohibited between function name and open parenthesis '('

> On Nov 26, 2015, at 8:36 PM, Joe Perches <joe@perches.com> wrote:
> 
> On Thu, 2015-11-26 at 16:50 +0100, Bogicevic Sasa wrote:
>> This fixes all errors "space prohibited between function name and
>> open parenthesis '(' " in all files in drivers/pci/hotplug folder
> 
> It's good when sending this sort of patch to add a bit of
> description like "git diff -w shows no differences" and that
> using scripts/objdiff also shows no difference.
> 
> Doing so shows that you've done a bit more than a mechanical
> transformation using something like:
> 
> $ ./scripts/checkpatch -f --types=spacing --fix-inplace <files>
> 
> and that you have verified your changes too.
> Ah ok, thanks for the info. Ill explore some more on what else can checkpatch.pl can do and resend all that needs to be corrected in that folder.
  Thanks, Sasa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web