Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1225147 > unrolled thread
| Started by | yassinjaffer@gmail.com |
|---|---|
| First post | 2015-09-15 16:10 +0200 |
| Last post | 2015-09-17 16:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC yassinjaffer@gmail.com - 2015-09-15 16:10 +0200
Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-17 13:30 +0200
Re: [linux-sunxi] Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC Chen-Yu Tsai <wens@csie.org> - 2015-09-17 16:30 +0200
| From | yassinjaffer@gmail.com |
|---|---|
| Date | 2015-09-15 16:10 +0200 |
| Subject | [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC |
| Message-ID | <q8Z5M-73c-35@gated-at.bofh.it> |
From: Yassin Jaffer <yassinjaffer@gmail.com>
Add Keypad controller node definition to the A20 SoC.
Signed-off-by: Yassin Jaffer <yassinjaffer@gmail.com>
---
arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 333604a..35cc8d0 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -1198,6 +1198,15 @@
status = "disabled";
};
+ kp: kp@01c23000 {
+ compatible = "allwinner,sun4i-a10-keypad";
+ reg = <0x01c23000 0x400>;
+ interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&apb0_gates 10>, <&keypad_clk>;
+ clock-names = "apb", "keypad";
+ status = "disabled";
+ };
+
sid: eeprom@01c23800 {
compatible = "allwinner,sun7i-a20-sid";
reg = <0x01c23800 0x200>;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2015-09-17 13:30 +0200 |
| Message-ID | <q9Fy1-24Q-5@gated-at.bofh.it> |
| In reply to | #1225147 |
[Multipart message — attachments visible in raw view] — view raw
Hi Yassin,
On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaffer@gmail.com wrote:
> From: Yassin Jaffer <yassinjaffer@gmail.com>
>
> Add Keypad controller node definition to the A20 SoC.
>
> Signed-off-by: Yassin Jaffer <yassinjaffer@gmail.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 333604a..35cc8d0 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -1198,6 +1198,15 @@
> status = "disabled";
> };
>
> + kp: kp@01c23000 {
The node name should reflect the class of the device. keypad@01c23000
would be better for example.
It looks good otherwise.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2015-09-17 16:30 +0200 |
| Subject | Re: [linux-sunxi] Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC |
| Message-ID | <q9Ime-6cb-27@gated-at.bofh.it> |
| In reply to | #1226926 |
On Thu, Sep 17, 2015 at 7:29 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi Yassin,
>
> On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaffer@gmail.com wrote:
>> From: Yassin Jaffer <yassinjaffer@gmail.com>
>>
>> Add Keypad controller node definition to the A20 SoC.
>>
>> Signed-off-by: Yassin Jaffer <yassinjaffer@gmail.com>
>> ---
>> arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
>> index 333604a..35cc8d0 100644
>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
>> @@ -1198,6 +1198,15 @@
>> status = "disabled";
>> };
>>
>> + kp: kp@01c23000 {
>
> The node name should reflect the class of the device. keypad@01c23000
> would be better for example.
Expanding the label to "keypad" as well would be nice.
"kp" could mean other things.
Thanks.
ChenYu
> It looks good otherwise.
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web