Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222073 > unrolled thread

Re: [PATCH] arm/ls1021a: Add Sleep feature for ls1021

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] arm/ls1021a: Add Sleep feature for ls1021 Mark Rutland <mark.rutland@arm.com> - 2015-09-10 12:00 +0200
    Re: [PATCH] arm/ls1021a: Add Sleep feature for ls1021 Mark Rutland <mark.rutland@arm.com> - 2015-09-17 14:40 +0200
      Re: [PATCH] arm/ls1021a: Add Sleep feature for ls1021 Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2015-09-18 09:50 +0200

#1222073 — Re: [PATCH] arm/ls1021a: Add Sleep feature for ls1021

On Thu, Sep 10, 2015 at 10:36:36AM +0100, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
> 
> Based on PSCI framework, add system STANDBY implement for ls1021 platform.
> 
> Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
> 
> diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> index fb689d8..d7a2d1d 100644
> --- a/arch/arm/mach-imx/Makefile
> +++ b/arch/arm/mach-imx/Makefile
> @@ -90,6 +90,7 @@ ifeq ($(CONFIG_SUSPEND),y)
>  AFLAGS_suspend-imx6.o :=-Wa,-march=armv7-a
>  obj-$(CONFIG_SOC_IMX6) += suspend-imx6.o
>  obj-$(CONFIG_SOC_IMX53) += suspend-imx53.o
> +obj-$(CONFIG_SOC_LS1021A) += pm-ls1.o
>  endif
>  obj-$(CONFIG_SOC_IMX6) += pm-imx6.o
>  
> diff --git a/arch/arm/mach-imx/pm-ls1.c b/arch/arm/mach-imx/pm-ls1.c
> new file mode 100644
> index 0000000..f80b24d
> --- /dev/null
> +++ b/arch/arm/mach-imx/pm-ls1.c
> @@ -0,0 +1,222 @@
> +/*
> + * Support Power Management Control for LS1
> + *
> + * Copyright 2015 Freescale Semiconductor Inc.
> + *
> + * This program is free software; you can redistribute	it and/or modify it
> + * under  the terms of	the GNU General	 Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */
> +
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/of_platform.h>
> +#include <linux/of_address.h>
> +#include <linux/psci.h>
> +#include <linux/suspend.h>
> +
> +#include <uapi/linux/psci.h>
> +
> +#include <asm/cacheflush.h>
> +#include <asm/psci.h>

NAK.

No new platform code should be calling the PSCI functions directly; you
should not need to include these files in platform code.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1226968

On Fri, Sep 11, 2015 at 04:53:04AM +0100, Wang Dongsheng wrote:
> Hi Mark,

Hi,

> > > > diff --git a/arch/arm/mach-imx/pm-ls1.c b/arch/arm/mach-imx/pm-ls1.c
> > > > new file mode 100644 index 0000000..f80b24d
> > > > --- /dev/null
> > > > +++ b/arch/arm/mach-imx/pm-ls1.c
> > > > @@ -0,0 +1,222 @@
> > > > +/*
> > > > + * Support Power Management Control for LS1
> > > > + *
> > > > + * Copyright 2015 Freescale Semiconductor Inc.
> > > > + *
> > > > + * This program is free software; you can redistribute	it and/or modify it
> > > > + * under  the terms of	the GNU General	 Public License as
> > published by
> > > the
> > > > + * Free Software Foundation;  either version 2 of the  License, or
> > > > +(at your
> > > > + * option) any later version.
> > > > + */
> > > > +
> > > > +#include <linux/io.h>
> > > > +#include <linux/kernel.h>
> > > > +#include <linux/of_platform.h>
> > > > +#include <linux/of_address.h>
> > > > +#include <linux/psci.h>
> > > > +#include <linux/suspend.h>
> > > > +
> > > > +#include <uapi/linux/psci.h>
> > > > +
> > > > +#include <asm/cacheflush.h>
> > > > +#include <asm/psci.h>
> > >
> > > NAK.
> > >
> > > No new platform code should be calling the PSCI functions directly;
> > > you should not need to include these files in platform code.
> > 
> > PSCI 1.0 define SYSTEM_SUSPEND, and 0.2 and 0.1 not support this feature.
> > 
> > I will drop psci-cpu_suspend to implement SYSTEM SUSPEND, and implement system
> > suspend in platform code.
> 
> Now 0.1 and 0.2 not support SYSTEM SUSPEND, means if do system suspend we still
> need to use platform_suspend_ops to implement system suspend in platform code and
> cannot use PSCI interface to do it?

As PSCI_SYSTEM_SUSPEND was introduced in PSCI 1.0, you would need a PSCI
1.0 implementation in order to use PSCI_SYSTEM_SUSPEND. Is there
anything preventing implementing PSCI 1.0?

> How about PSCI 1.0 support, could you share some information about it?

Lorenzo has implemented basic PSCI 1.0 support [1,2], and Sudeep has
been working on SYSTEM_SUSPEND [3], though I'm not immediately aware of
the state of the world there.

Do you have any specific questions?

Thanks,
Mark.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/355098.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/369806.html
[3] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/369804.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1227628

On Fri, Sep 18, 2015 at 03:37:15AM +0100, Wang Dongsheng wrote:

[...]

> > > How about PSCI 1.0 support, could you share some information about it?
> > 
> > Lorenzo has implemented basic PSCI 1.0 support [1,2], and Sudeep has been
> > working on SYSTEM_SUSPEND [3], though I'm not immediately aware of the state of
> > the world there.
> > 
> > Do you have any specific questions?
> > 
> 
> There is no problem, I just want to use V1.0 to support our platform SYSTEM_SUSPEND,
> but 1.0 implementation is not in v4.3-rc1, so abandon this.

It will be in v4.4, so you can drop this patch then.

Thanks,
Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web