Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1226013 > unrolled thread
| Started by | Gerhard Bertelsmann <info@gerhard-bertelsmann.de> |
|---|---|
| First post | 2015-09-16 13:30 +0200 |
| Last post | 2015-09-17 12:10 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings Gerhard Bertelsmann <info@gerhard-bertelsmann.de> - 2015-09-16 13:30 +0200
Re: [PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings Marc Kleine-Budde <mkl@pengutronix.de> - 2015-09-17 10:10 +0200
Re: [PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-17 12:10 +0200
Re: [PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-17 12:10 +0200
| From | Gerhard Bertelsmann <info@gerhard-bertelsmann.de> |
|---|---|
| Date | 2015-09-16 13:30 +0200 |
| Subject | [PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings |
| Message-ID | <q9j4t-31b-15@gated-at.bofh.it> |
Devicetree bindings for Allwinner A10/A20 CAN
Signed-off-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
---
.../devicetree/bindings/net/can/sun4i_can.txt | 38 +
1 files changed, 389 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/can/sun4i_can.txt b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
new file mode 100644
index 0000000..cd0f50c
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
@@ -0,0 +1,38 @@
+Allwinner A10/A20 CAN controller Device Tree Bindings
+-----------------------------------------------------
+
+Required properties:
+- compatible: "allwinner,sun4i-a10-can"
+- reg: physical base address and size of the Allwinner A10/A20 CAN register map.
+- interrupts: interrupt specifier for the sole interrupt.
+- clock: phandle and clock specifier.
+
+
+Example
+-------
+
+SoC common .dtsi file:
+
+ can0_pins_a: can0@0 {
+ allwinner,pins = "PH20","PH21";
+ allwinner,function = "can";
+ allwinner,drive = <0>;
+ allwinner,pull = <0>;
+ };
+...
+ can0: can@01c2bc00 {
+ compatible = "allwinner,sun4i-a10-can";
+ reg = <0x01c2bc00 0x400>;
+ interrupts = <0 26 4>;
+ clocks = <&apb1_gates 4>;
+ status = "disabled";
+ };
+
+Board specific .dts file:
+
+ can0: can@01c2bc00 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&can0_pins_a>;
+ status = "okay";
+ };
+
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Marc Kleine-Budde <mkl@pengutronix.de> |
|---|---|
| Date | 2015-09-17 10:10 +0200 |
| Subject | Re: [PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings |
| Message-ID | <q9Cqu-5Ub-15@gated-at.bofh.it> |
| In reply to | #1226013 |
[Multipart message — attachments visible in raw view] — view raw
On 09/16/2015 01:21 PM, Gerhard Bertelsmann wrote:
> Devicetree bindings for Allwinner A10/A20 CAN
>
> Signed-off-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
> ---
>
> .../devicetree/bindings/net/can/sun4i_can.txt | 38 +
> 1 files changed, 389 insertions(+)
>
>
> diff --git a/Documentation/devicetree/bindings/net/can/sun4i_can.txt b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> new file mode 100644
> index 0000000..cd0f50c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> @@ -0,0 +1,38 @@
> +Allwinner A10/A20 CAN controller Device Tree Bindings
> +-----------------------------------------------------
> +
> +Required properties:
> +- compatible: "allwinner,sun4i-a10-can"
> +- reg: physical base address and size of the Allwinner A10/A20 CAN register map.
> +- interrupts: interrupt specifier for the sole interrupt.
> +- clock: phandle and clock specifier.
> +
> +
> +Example
> +-------
> +
> +SoC common .dtsi file:
> +
> + can0_pins_a: can0@0 {
> + allwinner,pins = "PH20","PH21";
> + allwinner,function = "can";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +...
> + can0: can@01c2bc00 {
> + compatible = "allwinner,sun4i-a10-can";
> + reg = <0x01c2bc00 0x400>;
> + interrupts = <0 26 4>;
> + clocks = <&apb1_gates 4>;
> + status = "disabled";
> + };
What about adding this snippet to SoC where the CAN core is available?
Maxime, what's the policy on sinxi? If you give me an Ack I'd like to
take the series via linux-can-next (and to net-next) upstream.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2015-09-17 12:10 +0200 |
| Subject | Re: [PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings |
| Message-ID | <q9EiC-kL-7@gated-at.bofh.it> |
| In reply to | #1226736 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Sep 17, 2015 at 10:04:56AM +0200, Marc Kleine-Budde wrote:
> On 09/16/2015 01:21 PM, Gerhard Bertelsmann wrote:
> > Devicetree bindings for Allwinner A10/A20 CAN
> >
> > Signed-off-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>
> > ---
> >
> > .../devicetree/bindings/net/can/sun4i_can.txt | 38 +
> > 1 files changed, 389 insertions(+)
> >
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/sun4i_can.txt b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> > new file mode 100644
> > index 0000000..cd0f50c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/can/sun4i_can.txt
> > @@ -0,0 +1,38 @@
> > +Allwinner A10/A20 CAN controller Device Tree Bindings
> > +-----------------------------------------------------
> > +
> > +Required properties:
> > +- compatible: "allwinner,sun4i-a10-can"
> > +- reg: physical base address and size of the Allwinner A10/A20 CAN register map.
> > +- interrupts: interrupt specifier for the sole interrupt.
> > +- clock: phandle and clock specifier.
> > +
> > +
> > +Example
> > +-------
> > +
> > +SoC common .dtsi file:
> > +
> > + can0_pins_a: can0@0 {
> > + allwinner,pins = "PH20","PH21";
> > + allwinner,function = "can";
> > + allwinner,drive = <0>;
> > + allwinner,pull = <0>;
> > + };
> > +...
> > + can0: can@01c2bc00 {
> > + compatible = "allwinner,sun4i-a10-can";
> > + reg = <0x01c2bc00 0x400>;
> > + interrupts = <0 26 4>;
> > + clocks = <&apb1_gates 4>;
> > + status = "disabled";
> > + };
>
> What about adding this snippet to SoC where the CAN core is available?
> Maxime, what's the policy on sinxi?
It would be great, but it can come as a second step.
> If you give me an Ack I'd like to take the series via linux-can-next
> (and to net-next) upstream.
I just did so for this patch, I'll review the driver when I'll have a
bit of time.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2015-09-17 12:10 +0200 |
| Subject | Re: [PATCH v8 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings |
| Message-ID | <q9EiD-kL-23@gated-at.bofh.it> |
| In reply to | #1226013 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Sep 16, 2015 at 01:21:19PM +0200, Gerhard Bertelsmann wrote: > Devicetree bindings for Allwinner A10/A20 CAN > > Signed-off-by: Gerhard Bertelsmann <info@gerhard-bertelsmann.de> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web