Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225478 > unrolled thread

[PATCH v3 0/2] Add Cygnus PCIe Serdes/PHY support

Started byRay Jui <rjui@broadcom.com>
First post2015-09-15 20:00 +0200
Last post2015-09-19 02:00 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 0/2] Add Cygnus PCIe Serdes/PHY support Ray Jui <rjui@broadcom.com> - 2015-09-15 20:00 +0200
    [PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding Ray Jui <rjui@broadcom.com> - 2015-09-15 20:00 +0200
      Re: [PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding Kishon Vijay Abraham I <kishon@ti.com> - 2015-09-18 08:20 +0200
        Re: [PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding Ray Jui <rjui@broadcom.com> - 2015-09-19 02:00 +0200

#1225478 — [PATCH v3 0/2] Add Cygnus PCIe Serdes/PHY support

FromRay Jui <rjui@broadcom.com>
Date2015-09-15 20:00 +0200
Subject[PATCH v3 0/2] Add Cygnus PCIe Serdes/PHY support
Message-ID<q92Gl-3AZ-3@gated-at.bofh.it>
This patch series adds support for the Cygnus PCIe PHY

This patch series is based on Linux v4.3-rc1 and is avaliable in:
https://github.com/Broadcom/cygnus-linux/tree/cygnus-pcie-phy-v3

Changes from v2:
 - Dropped MDC/MDIO bus driver since it's not needed to enable/disable the
   analog-front-end of the PCIe Serdes on Cygnus
 - Optimized delay waiting for PCIe analog-front-end to be fully enabled
 - Reduce the #phy-cell to 1 since now the MDIO PHY ID is not required

Changes from v1:
 - Move the MDC/MDIO bus driver from drivers/phy/* to drivers/bus/*
 - Make the PCIe PHY device node child node of the MDIO bus
 - Change the PCIe PHY driver to tristate so it can be compiled as a module
 - Other minor changes

Ray Jui (2):
  dt-bindings: Add Broadcom Cygnus PCIe PHY binding
  phy: cygnus: pcie: Add Cygnus PCIe PHY support

 .../bindings/phy/brcm,cygnus-pcie-phy.txt          |  30 ++++
 drivers/phy/Kconfig                                |   9 +
 drivers/phy/Makefile                               |   1 +
 drivers/phy/phy-bcm-cygnus-pcie.c                  | 198 +++++++++++++++++++++
 4 files changed, 238 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
 create mode 100644 drivers/phy/phy-bcm-cygnus-pcie.c

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1225479 — [PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding

FromRay Jui <rjui@broadcom.com>
Date2015-09-15 20:00 +0200
Subject[PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding
Message-ID<q92Gn-3AZ-29@gated-at.bofh.it>
In reply to#1225478
Add DT binding for Broadcom Cygnus PCIe PHYs

Signed-off-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Arun Parameswaran <aparames@broadcom.com>
Reviewed-by: JD (Jiandong) Zheng <jdzheng@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
---
 .../bindings/phy/brcm,cygnus-pcie-phy.txt          | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt

diff --git a/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
new file mode 100644
index 0000000..ba41143
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
@@ -0,0 +1,30 @@
+Broadcom Cygnus PCIe PHY
+
+Required properties:
+- compatible: Must be "brcm,cygnus-pcie-phy"
+- reg: base address and length of the PCIe PHY block
+- #phy-cells: must be <1>
+The first cell is the PHY ID:
+0 - PCIe RC 0
+1 - PCIe RC 1
+
+Example:
+	pcie_phy: phy@0301d0a0 {
+		compatible = "brcm,cygnus-pcie-phy";
+		reg = <0x0301d0a0 0x14>;
+		#phy-cells = <1>;
+	};
+
+	pcie0: pcie@18012000 {
+		...
+		...
+		phys = <&pcie_phy 0>;
+		phy-names = "pcie-phy";
+	};
+
+	pcie1: pcie@18013000 {
+		...
+		...
+		phys = <&pcie_phy 1>;
+		phy-names = "pcie-phy";
+	};
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1227590 — Re: [PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding

FromKishon Vijay Abraham I <kishon@ti.com>
Date2015-09-18 08:20 +0200
SubjectRe: [PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding
Message-ID<q9Xbz-2Jo-11@gated-at.bofh.it>
In reply to#1225479
Hi,

On Tuesday 15 September 2015 11:26 PM, Ray Jui wrote:
> Add DT binding for Broadcom Cygnus PCIe PHYs

DT binding documentation.

-Kishon

> 
> Signed-off-by: Ray Jui <rjui@broadcom.com>
> Reviewed-by: Arun Parameswaran <aparames@broadcom.com>
> Reviewed-by: JD (Jiandong) Zheng <jdzheng@broadcom.com>
> Reviewed-by: Scott Branden <sbranden@broadcom.com>


> ---
>  .../bindings/phy/brcm,cygnus-pcie-phy.txt          | 30 ++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
> 
> diff --git a/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
> new file mode 100644
> index 0000000..ba41143
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
> @@ -0,0 +1,30 @@
> +Broadcom Cygnus PCIe PHY
> +
> +Required properties:
> +- compatible: Must be "brcm,cygnus-pcie-phy"
> +- reg: base address and length of the PCIe PHY block
> +- #phy-cells: must be <1>
> +The first cell is the PHY ID:
> +0 - PCIe RC 0
> +1 - PCIe RC 1
> +
> +Example:
> +	pcie_phy: phy@0301d0a0 {
> +		compatible = "brcm,cygnus-pcie-phy";
> +		reg = <0x0301d0a0 0x14>;
> +		#phy-cells = <1>;
> +	};
> +
> +	pcie0: pcie@18012000 {
> +		...
> +		...
> +		phys = <&pcie_phy 0>;
> +		phy-names = "pcie-phy";
> +	};
> +
> +	pcie1: pcie@18013000 {
> +		...
> +		...
> +		phys = <&pcie_phy 1>;
> +		phy-names = "pcie-phy";
> +	};
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1228347 — Re: [PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding

FromRay Jui <rjui@broadcom.com>
Date2015-09-19 02:00 +0200
SubjectRe: [PATCH v3 1/2] dt-bindings: Add Broadcom Cygnus PCIe PHY binding
Message-ID<qadJo-1cU-3@gated-at.bofh.it>
In reply to#1227590

On 9/17/2015 11:17 PM, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Tuesday 15 September 2015 11:26 PM, Ray Jui wrote:
>> Add DT binding for Broadcom Cygnus PCIe PHYs
> 
> DT binding documentation.
> 
> -Kishon
> 

Yes will fix the commit message.

>>
>> Signed-off-by: Ray Jui <rjui@broadcom.com>
>> Reviewed-by: Arun Parameswaran <aparames@broadcom.com>
>> Reviewed-by: JD (Jiandong) Zheng <jdzheng@broadcom.com>
>> Reviewed-by: Scott Branden <sbranden@broadcom.com>
> 
> 
>> ---
>>  .../bindings/phy/brcm,cygnus-pcie-phy.txt          | 30 ++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
>>
>> diff --git a/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
>> new file mode 100644
>> index 0000000..ba41143
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt
>> @@ -0,0 +1,30 @@
>> +Broadcom Cygnus PCIe PHY
>> +
>> +Required properties:
>> +- compatible: Must be "brcm,cygnus-pcie-phy"
>> +- reg: base address and length of the PCIe PHY block
>> +- #phy-cells: must be <1>
>> +The first cell is the PHY ID:
>> +0 - PCIe RC 0
>> +1 - PCIe RC 1
>> +
>> +Example:
>> +	pcie_phy: phy@0301d0a0 {
>> +		compatible = "brcm,cygnus-pcie-phy";
>> +		reg = <0x0301d0a0 0x14>;
>> +		#phy-cells = <1>;
>> +	};
>> +
>> +	pcie0: pcie@18012000 {
>> +		...
>> +		...
>> +		phys = <&pcie_phy 0>;
>> +		phy-names = "pcie-phy";
>> +	};
>> +
>> +	pcie1: pcie@18013000 {
>> +		...
>> +		...
>> +		phys = <&pcie_phy 1>;
>> +		phy-names = "pcie-phy";
>> +	};
>>

Note this binding document will now change due to required changes in
the phy driver following code review comments. Each phy will now be
represented by a child node and #phy-cells will become 0 for each of the
child.

Thanks,

Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web