Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1225402 > unrolled thread
| Started by | Luis de Bethencourt <luis@debethencourt.com> |
|---|---|
| First post | 2015-09-15 18:40 +0200 |
| Last post | 2015-09-16 21:30 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver Luis de Bethencourt <luis@debethencourt.com> - 2015-09-15 18:40 +0200
Re: [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver Tejun Heo <tj@kernel.org> - 2015-09-16 19:50 +0200
Re: [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver Luis de Bethencourt <luis@debethencourt.com> - 2015-09-16 21:00 +0200
Re: [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver Tejun Heo <tj@kernel.org> - 2015-09-16 21:30 +0200
| From | Luis de Bethencourt <luis@debethencourt.com> |
|---|---|
| Date | 2015-09-15 18:40 +0200 |
| Subject | [PATCH v2] ata: pata_macio: Fix module autoload for OF platform driver |
| Message-ID | <q91qW-1Tn-23@gated-at.bofh.it> |
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.
Link: https://lkml.org/lkml/2015/7/30/519
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
drivers/ata/pata_macio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index b002858..e60adbb 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1344,6 +1344,7 @@ static struct of_device_id pata_macio_match[] =
},
{},
};
+MODULE_DEVICE_TABLE(of, pata_macio_patch);
static struct macio_driver pata_macio_driver =
{
--
2.4.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2015-09-16 19:50 +0200 |
| Message-ID | <q9p0e-309-7@gated-at.bofh.it> |
| In reply to | #1225402 |
On Tue, Sep 15, 2015 at 06:31:14PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > Link: https://lkml.org/lkml/2015/7/30/519 > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> Where should this patch be applied? for-4.4? for-4.3-fixes w/ or w/o stable cc'd? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Luis de Bethencourt <luis@debethencourt.com> |
|---|---|
| Date | 2015-09-16 21:00 +0200 |
| Message-ID | <q9q5Z-4xy-23@gated-at.bofh.it> |
| In reply to | #1226321 |
On Wed, Sep 16, 2015 at 01:48:23PM -0400, Tejun Heo wrote: > On Tue, Sep 15, 2015 at 06:31:14PM +0200, Luis de Bethencourt wrote: > > This platform driver has a OF device ID table but the OF module > > alias information is not created so module autoloading won't work. > > > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > > that information so modules have the correct aliases built-in and > > autoloading works correctly. > > > > Link: https://lkml.org/lkml/2015/7/30/519 > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > > Where should this patch be applied? for-4.4? for-4.3-fixes w/ or w/o > stable cc'd? > > Thanks. > > -- > tejun Hi Tejun, Other drivers with the same problem are applying this in 4.3-fixes. I don't think it is critical enough to deserve a cc: Stable. Thanks for review, Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2015-09-16 21:30 +0200 |
| Message-ID | <q9qz1-5ll-31@gated-at.bofh.it> |
| In reply to | #1225402 |
On Tue, Sep 15, 2015 at 06:31:14PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > Link: https://lkml.org/lkml/2015/7/30/519 > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> Applied to libata/for-4.3-fixes. Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web