Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225341 > unrolled thread

[PATCH] ata: pata_macio: Fix module autoload for OF platform driver

Back to article view | Back to linux.kernel

Contents

  [PATCH] ata: pata_macio: Fix module autoload for OF platform driver Luis de Bethencourt <luis@debethencourt.com> - 2015-09-15 17:50 +0200
    Re: [PATCH] ata: pata_macio: Fix module autoload for OF platform  driver Tejun Heo <tj@kernel.org> - 2015-09-15 18:00 +0200
      Re: [PATCH] ata: pata_macio: Fix module autoload for OF platform  driver Luis de Bethencourt <luis@debethencourt.com> - 2015-09-15 18:40 +0200

#1225341 — [PATCH] ata: pata_macio: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hello,

This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.

A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519

Thanks,
Luis

 drivers/ata/pata_macio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index a02f76f..aba634e 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1344,6 +1344,7 @@ static struct of_device_id pata_macio_match[] =
 	},
 	{},
 };
+MODULE_DEVICE_TABLE(of, pata_macio_match);
 
 static struct macio_driver pata_macio_driver =
 {
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1225369 — Re: [PATCH] ata: pata_macio: Fix module autoload for OF platform driver

On Tue, Sep 15, 2015 at 05:45:52PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519

Can you please include that in the patch description?  Or at least add
Link: tag?  Also, should this be routed through -stable?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1225396 — Re: [PATCH] ata: pata_macio: Fix module autoload for OF platform driver

On Tue, Sep 15, 2015 at 11:52:10AM -0400, Tejun Heo wrote:
> On Tue, Sep 15, 2015 at 05:45:52PM +0200, Luis de Bethencourt wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> > 
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> > ---
> > 
> > Hello,
> > 
> > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> > that information so modules have the correct aliases built-in and
> > autoloading works correctly.
> > 
> > A longer explanation by Javier Canillas can be found here:
> > https://lkml.org/lkml/2015/7/30/519
> 
> Can you please include that in the patch description?  Or at least add
> Link: tag?  Also, should this be routed through -stable?
> 
> Thanks.
> 
> -- 
> tejun

Tejun,

Sent a second version.

Thank you very much for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web