Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1225410 > unrolled thread

[PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver

Started byLuis de Bethencourt <luis@debethencourt.com>
First post2015-09-15 18:50 +0200
Last post2015-09-19 04:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver Luis de Bethencourt <luis@debethencourt.com> - 2015-09-15 18:50 +0200
    Re: [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver Corey Minyard <minyard@acm.org> - 2015-09-19 04:00 +0200

#1225410 — [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver

FromLuis de Bethencourt <luis@debethencourt.com>
Date2015-09-15 18:50 +0200
Subject[PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver
Message-ID<q91AC-24K-15@gated-at.bofh.it>
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
 drivers/char/ipmi/ipmi_si_intf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 967b73a..43e1fb24 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2784,6 +2784,7 @@ static struct of_device_id ipmi_match[] =
 	  .data = (void *)(unsigned long) SI_BT },
 	{},
 };
+MODULE_DEVICE_TABLE(of, ipmi_match);
 
 static struct platform_driver ipmi_driver = {
 	.driver = {
-- 
2.4.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1228365

FromCorey Minyard <minyard@acm.org>
Date2015-09-19 04:00 +0200
Message-ID<qafBw-3Qh-1@gated-at.bofh.it>
In reply to#1225410
This is there now in the main kernel, but it's further down.  Perhaps it
should be moved.

-corey

On 09/15/2015 11:42 AM, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/char/ipmi/ipmi_si_intf.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 967b73a..43e1fb24 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2784,6 +2784,7 @@ static struct of_device_id ipmi_match[] =
>  	  .data = (void *)(unsigned long) SI_BT },
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, ipmi_match);
>  
>  static struct platform_driver ipmi_driver = {
>  	.driver = {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web