Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223942 > unrolled thread

Re: [PATCH] clk: ti: clk-7xx: Remove hardwired ABE clock configuration

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] clk: ti: clk-7xx: Remove hardwired ABE clock  configuration Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-14 11:00 +0200
    Re: [PATCH] clk: ti: clk-7xx: Remove hardwired ABE clock  configuration Tero Kristo <t-kristo@ti.com> - 2015-09-16 08:50 +0200

#1223942 — Re: [PATCH] clk: ti: clk-7xx: Remove hardwired ABE clock configuration

Hi Tero,

On 08/24/2015 10:35 AM, Peter Ujfalusi wrote:
> The ABE related clocks should be configured via DT and not have it wired
> inside of the kernel.

can you take a look at this patch? It will not cause any regression since we
do not have audio support mainline and the pending series does not need this
part anymore.

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Tero,
> 
> the ABE PLL configuration can, and will be done for dra7xx in DT with the
> assigned-clocks/rate/parent feature so no need to have this anymore.
> 
> Regards,
> Peter
> 
>  drivers/clk/ti/clk-7xx.c | 18 +-----------------
>  1 file changed, 1 insertion(+), 17 deletions(-)
> 
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index 9b5b289e6334..a911d7de3377 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -18,7 +18,6 @@
>  
>  #include "clock.h"
>  
> -#define DRA7_DPLL_ABE_DEFFREQ				180633600
>  #define DRA7_DPLL_GMAC_DEFFREQ				1000000000
>  #define DRA7_DPLL_USB_DEFFREQ				960000000
>  
> @@ -313,27 +312,12 @@ static struct ti_dt_clk dra7xx_clks[] = {
>  int __init dra7xx_dt_clk_init(void)
>  {
>  	int rc;
> -	struct clk *abe_dpll_mux, *sys_clkin2, *dpll_ck, *hdcp_ck;
> +	struct clk *dpll_ck, *hdcp_ck;
>  
>  	ti_dt_clocks_register(dra7xx_clks);
>  
>  	omap2_clk_disable_autoidle_all();
>  
> -	abe_dpll_mux = clk_get_sys(NULL, "abe_dpll_sys_clk_mux");
> -	sys_clkin2 = clk_get_sys(NULL, "sys_clkin2");
> -	dpll_ck = clk_get_sys(NULL, "dpll_abe_ck");
> -
> -	rc = clk_set_parent(abe_dpll_mux, sys_clkin2);
> -	if (!rc)
> -		rc = clk_set_rate(dpll_ck, DRA7_DPLL_ABE_DEFFREQ);
> -	if (rc)
> -		pr_err("%s: failed to configure ABE DPLL!\n", __func__);
> -
> -	dpll_ck = clk_get_sys(NULL, "dpll_abe_m2x2_ck");
> -	rc = clk_set_rate(dpll_ck, DRA7_DPLL_ABE_DEFFREQ * 2);
> -	if (rc)
> -		pr_err("%s: failed to configure ABE DPLL m2x2!\n", __func__);
> -
>  	dpll_ck = clk_get_sys(NULL, "dpll_gmac_ck");
>  	rc = clk_set_rate(dpll_ck, DRA7_DPLL_GMAC_DEFFREQ);
>  	if (rc)
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1225747

On 09/14/2015 11:52 AM, Peter Ujfalusi wrote:
> Hi Tero,
>
> On 08/24/2015 10:35 AM, Peter Ujfalusi wrote:
>> The ABE related clocks should be configured via DT and not have it wired
>> inside of the kernel.
>
> can you take a look at this patch? It will not cause any regression since we
> do not have audio support mainline and the pending series does not need this
> part anymore.

This patch looks okay to me. So, you are saying this doesn't depend on 
anything? Isn't this causing any boot-time issues with the ABE DPLL left 
dangling with boot setup, potentially blocking PM? I am just wondering 
if we should group this patch with the rest of the audio support patches 
for dra7.

-Tero

>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> Hi Tero,
>>
>> the ABE PLL configuration can, and will be done for dra7xx in DT with the
>> assigned-clocks/rate/parent feature so no need to have this anymore.
>>
>> Regards,
>> Peter
>>
>>   drivers/clk/ti/clk-7xx.c | 18 +-----------------
>>   1 file changed, 1 insertion(+), 17 deletions(-)
>>
>> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
>> index 9b5b289e6334..a911d7de3377 100644
>> --- a/drivers/clk/ti/clk-7xx.c
>> +++ b/drivers/clk/ti/clk-7xx.c
>> @@ -18,7 +18,6 @@
>>
>>   #include "clock.h"
>>
>> -#define DRA7_DPLL_ABE_DEFFREQ				180633600
>>   #define DRA7_DPLL_GMAC_DEFFREQ				1000000000
>>   #define DRA7_DPLL_USB_DEFFREQ				960000000
>>
>> @@ -313,27 +312,12 @@ static struct ti_dt_clk dra7xx_clks[] = {
>>   int __init dra7xx_dt_clk_init(void)
>>   {
>>   	int rc;
>> -	struct clk *abe_dpll_mux, *sys_clkin2, *dpll_ck, *hdcp_ck;
>> +	struct clk *dpll_ck, *hdcp_ck;
>>
>>   	ti_dt_clocks_register(dra7xx_clks);
>>
>>   	omap2_clk_disable_autoidle_all();
>>
>> -	abe_dpll_mux = clk_get_sys(NULL, "abe_dpll_sys_clk_mux");
>> -	sys_clkin2 = clk_get_sys(NULL, "sys_clkin2");
>> -	dpll_ck = clk_get_sys(NULL, "dpll_abe_ck");
>> -
>> -	rc = clk_set_parent(abe_dpll_mux, sys_clkin2);
>> -	if (!rc)
>> -		rc = clk_set_rate(dpll_ck, DRA7_DPLL_ABE_DEFFREQ);
>> -	if (rc)
>> -		pr_err("%s: failed to configure ABE DPLL!\n", __func__);
>> -
>> -	dpll_ck = clk_get_sys(NULL, "dpll_abe_m2x2_ck");
>> -	rc = clk_set_rate(dpll_ck, DRA7_DPLL_ABE_DEFFREQ * 2);
>> -	if (rc)
>> -		pr_err("%s: failed to configure ABE DPLL m2x2!\n", __func__);
>> -
>>   	dpll_ck = clk_get_sys(NULL, "dpll_gmac_ck");
>>   	rc = clk_set_rate(dpll_ck, DRA7_DPLL_GMAC_DEFFREQ);
>>   	if (rc)
>>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web