Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1223578 > unrolled thread
| Started by | Anjali Menon <cse.anjalimenon@gmail.com> |
|---|---|
| First post | 2015-09-13 13:00 +0200 |
| Last post | 2015-09-14 07:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: dgnc: Fixed line over 80 characters long Anjali Menon <cse.anjalimenon@gmail.com> - 2015-09-13 13:00 +0200
Re: [PATCH] staging: dgnc: Fixed line over 80 characters long Greg KH <gregkh@linuxfoundation.org> - 2015-09-14 07:10 +0200
| From | Anjali Menon <cse.anjalimenon@gmail.com> |
|---|---|
| Date | 2015-09-13 13:00 +0200 |
| Subject | [PATCH] staging: dgnc: Fixed line over 80 characters long |
| Message-ID | <q8daP-5pP-25@gated-at.bofh.it> |
This is a patch that fixes line over 80 characters coding style warning detected by checkpatch.pl. WARNING: line over 80 characters Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com> --- drivers/staging/dgnc/dgnc_mgmt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c index b13318a..81c793a 100644 --- a/drivers/staging/dgnc/dgnc_mgmt.c +++ b/drivers/staging/dgnc/dgnc_mgmt.c @@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) di.info_bdstate = dgnc_Board[brd]->dpastatus; di.info_ioport = 0; di.info_physaddr = (ulong) dgnc_Board[brd]->membase; - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; + di.info_physsize = (ulong) dgnc_Board[brd]->membase + - dgnc_Board[brd]->membase_end; if (dgnc_Board[brd]->state != BOARD_FAILED) di.info_nports = dgnc_Board[brd]->nasync; else -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-09-14 07:10 +0200 |
| Message-ID | <q8ubD-4LN-5@gated-at.bofh.it> |
| In reply to | #1223578 |
On Sun, Sep 13, 2015 at 04:22:00PM +0530, Anjali Menon wrote: > This is a patch that fixes line over 80 characters coding style > warning detected by checkpatch.pl. > > WARNING: line over 80 characters > > Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com> > --- > drivers/staging/dgnc/dgnc_mgmt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c > index b13318a..81c793a 100644 > --- a/drivers/staging/dgnc/dgnc_mgmt.c > +++ b/drivers/staging/dgnc/dgnc_mgmt.c > @@ -148,7 +148,8 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > di.info_bdstate = dgnc_Board[brd]->dpastatus; > di.info_ioport = 0; > di.info_physaddr = (ulong) dgnc_Board[brd]->membase; > - di.info_physsize = (ulong) dgnc_Board[brd]->membase - dgnc_Board[brd]->membase_end; > + di.info_physsize = (ulong) dgnc_Board[brd]->membase > + - dgnc_Board[brd]->membase_end; This looks worse than it did before, there's better ways to make this line shorter. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web