Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1220362 > unrolled thread
| Started by | Jonathan Corbet <corbet@lwn.net> |
|---|---|
| First post | 2015-09-07 21:20 +0200 |
| Last post | 2015-09-17 17:40 +0200 |
| Articles | 7 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH] locking/static_keys: fix a silly typo Jonathan Corbet <corbet@lwn.net> - 2015-09-07 21:20 +0200
[tip:locking/urgent] locking/static_keys: Fix a silly typo tip-bot for Jonathan Corbet <tipbot@zytor.com> - 2015-09-08 09:10 +0200
Re: [PATCH] locking/static_keys: fix a silly typo Ingo Molnar <mingo@kernel.org> - 2015-09-08 09:10 +0200
Re: [PATCH] locking/static_keys: fix a silly typo Jason Baron <jbaron@akamai.com> - 2015-09-08 18:40 +0200
Re: [PATCH] locking/static_keys: fix a silly typo Ingo Molnar <mingo@kernel.org> - 2015-09-13 10:20 +0200
Re: [PATCH] locking/static_keys: fix a silly typo Chuck Ebbert <cebbert.lkml@gmail.com> - 2015-09-17 03:10 +0200
Re: [PATCH] locking/static_keys: fix a silly typo Jonathan Corbet <corbet@lwn.net> - 2015-09-17 17:40 +0200
| From | Jonathan Corbet <corbet@lwn.net> |
|---|---|
| Date | 2015-09-07 21:20 +0200 |
| Subject | [PATCH] locking/static_keys: fix a silly typo |
| Message-ID | <q6a7n-6db-11@gated-at.bofh.it> |
412758cb2670 (jump label, locking/static_keys: Update docs) introduced a typo that might as well get fixed. Signed-off-by: Jonathan Corbet <corbet@lwn.net> --- Documentation/static-keys.txt | 2 +- include/linux/jump_label.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/static-keys.txt b/Documentation/static-keys.txt index f4cb0b2..ec91158 100644 --- a/Documentation/static-keys.txt +++ b/Documentation/static-keys.txt @@ -16,7 +16,7 @@ The updated API replacements are: DEFINE_STATIC_KEY_TRUE(key); DEFINE_STATIC_KEY_FALSE(key); static_key_likely() -statick_key_unlikely() +static_key_unlikely() 0) Abstract diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h index 7f653e8..0684bd3 100644 --- a/include/linux/jump_label.h +++ b/include/linux/jump_label.h @@ -22,7 +22,7 @@ * DEFINE_STATIC_KEY_TRUE(key); * DEFINE_STATIC_KEY_FALSE(key); * static_key_likely() - * statick_key_unlikely() + * static_key_unlikely() * * Jump labels provide an interface to generate dynamic branches using * self-modifying code. Assuming toolchain and architecture support, if we -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | tip-bot for Jonathan Corbet <tipbot@zytor.com> |
|---|---|
| Date | 2015-09-08 09:10 +0200 |
| Subject | [tip:locking/urgent] locking/static_keys: Fix a silly typo |
| Message-ID | <q6lct-5wa-7@gated-at.bofh.it> |
| In reply to | #1220362 |
Commit-ID: edcd591c77a48da753456f92daf8bb50fe9bac93
Gitweb: http://git.kernel.org/tip/edcd591c77a48da753456f92daf8bb50fe9bac93
Author: Jonathan Corbet <corbet@lwn.net>
AuthorDate: Mon, 7 Sep 2015 13:18:03 -0600
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 8 Sep 2015 09:02:17 +0200
locking/static_keys: Fix a silly typo
Commit:
412758cb2670 ("jump label, locking/static_keys: Update docs")
introduced a typo that might as well get fixed.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jason Baron <jbaron@akamai.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20150907131803.54c027e1@lwn.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
Documentation/static-keys.txt | 2 +-
include/linux/jump_label.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/static-keys.txt b/Documentation/static-keys.txt
index f4cb0b2..ec91158 100644
--- a/Documentation/static-keys.txt
+++ b/Documentation/static-keys.txt
@@ -16,7 +16,7 @@ The updated API replacements are:
DEFINE_STATIC_KEY_TRUE(key);
DEFINE_STATIC_KEY_FALSE(key);
static_key_likely()
-statick_key_unlikely()
+static_key_unlikely()
0) Abstract
diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
index 7f653e8..0684bd3 100644
--- a/include/linux/jump_label.h
+++ b/include/linux/jump_label.h
@@ -22,7 +22,7 @@
* DEFINE_STATIC_KEY_TRUE(key);
* DEFINE_STATIC_KEY_FALSE(key);
* static_key_likely()
- * statick_key_unlikely()
+ * static_key_unlikely()
*
* Jump labels provide an interface to generate dynamic branches using
* self-modifying code. Assuming toolchain and architecture support, if we
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2015-09-08 09:10 +0200 |
| Message-ID | <q6lcu-5wa-17@gated-at.bofh.it> |
| In reply to | #1220362 |
* Jonathan Corbet <corbet@lwn.net> wrote: > 412758cb2670 (jump label, locking/static_keys: Update docs) introduced a > typo that might as well get fixed. > > Signed-off-by: Jonathan Corbet <corbet@lwn.net> > --- > Documentation/static-keys.txt | 2 +- > include/linux/jump_label.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/static-keys.txt b/Documentation/static-keys.txt > index f4cb0b2..ec91158 100644 > --- a/Documentation/static-keys.txt > +++ b/Documentation/static-keys.txt > @@ -16,7 +16,7 @@ The updated API replacements are: > DEFINE_STATIC_KEY_TRUE(key); > DEFINE_STATIC_KEY_FALSE(key); > static_key_likely() > -statick_key_unlikely() > +static_key_unlikely() Thancks, applied! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jason Baron <jbaron@akamai.com> |
|---|---|
| Date | 2015-09-08 18:40 +0200 |
| Message-ID | <q6u67-1i4-17@gated-at.bofh.it> |
| In reply to | #1220362 |
On 09/07/2015 03:18 PM, Jonathan Corbet wrote: > 412758cb2670 (jump label, locking/static_keys: Update docs) introduced a > typo that might as well get fixed. > > Signed-off-by: Jonathan Corbet <corbet@lwn.net> > --- > Documentation/static-keys.txt | 2 +- > include/linux/jump_label.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/static-keys.txt b/Documentation/static-keys.txt > index f4cb0b2..ec91158 100644 > --- a/Documentation/static-keys.txt > +++ b/Documentation/static-keys.txt > @@ -16,7 +16,7 @@ The updated API replacements are: > DEFINE_STATIC_KEY_TRUE(key); > DEFINE_STATIC_KEY_FALSE(key); > static_key_likely() > -statick_key_unlikely() > +static_key_unlikely() > > 0) Abstract > > diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h > index 7f653e8..0684bd3 100644 > --- a/include/linux/jump_label.h > +++ b/include/linux/jump_label.h > @@ -22,7 +22,7 @@ > * DEFINE_STATIC_KEY_TRUE(key); > * DEFINE_STATIC_KEY_FALSE(key); > * static_key_likely() > - * statick_key_unlikely() > + * static_key_unlikely() > * > * Jump labels provide an interface to generate dynamic branches using > * self-modifying code. Assuming toolchain and architecture support, if we > Thanks. I actually messed this up further. That's supposed to be, 'static_branch_likely()', and 'static_branch_unlikely()'. So: s/static_key_likely()/static_branch_likely() and s/static_key_unlikely()/static_branch_unlikely() The rest of the doc appears to have it correctly. There are a few more typos in there as well: 1) s/addtion/addition 2) " The inc()/dec() interface is meant to be used exclusively from the inc()/dec() for a given key. " Was supposed to read: " The inc()/dec() interface is meant to be used exclusively from the enable()/disable() interface for a given key. " However, I think we should just delete this sentence. As the API inherently doesn't prevent this. The user just may need to be aware to properly serialize operations. Thanks, -Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2015-09-13 10:20 +0200 |
| Message-ID | <q8aFY-217-1@gated-at.bofh.it> |
| In reply to | #1220974 |
* Jason Baron <jbaron@akamai.com> wrote: > On 09/07/2015 03:18 PM, Jonathan Corbet wrote: > > 412758cb2670 (jump label, locking/static_keys: Update docs) introduced a > > typo that might as well get fixed. > > > > Signed-off-by: Jonathan Corbet <corbet@lwn.net> > > --- > > Documentation/static-keys.txt | 2 +- > > include/linux/jump_label.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/static-keys.txt b/Documentation/static-keys.txt > > index f4cb0b2..ec91158 100644 > > --- a/Documentation/static-keys.txt > > +++ b/Documentation/static-keys.txt > > @@ -16,7 +16,7 @@ The updated API replacements are: > > DEFINE_STATIC_KEY_TRUE(key); > > DEFINE_STATIC_KEY_FALSE(key); > > static_key_likely() > > -statick_key_unlikely() > > +static_key_unlikely() > > > > 0) Abstract > > > > diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h > > index 7f653e8..0684bd3 100644 > > --- a/include/linux/jump_label.h > > +++ b/include/linux/jump_label.h > > @@ -22,7 +22,7 @@ > > * DEFINE_STATIC_KEY_TRUE(key); > > * DEFINE_STATIC_KEY_FALSE(key); > > * static_key_likely() > > - * statick_key_unlikely() > > + * static_key_unlikely() > > * > > * Jump labels provide an interface to generate dynamic branches using > > * self-modifying code. Assuming toolchain and architecture support, if we > > > > Thanks. I actually messed this up further. That's supposed to be, > 'static_branch_likely()', and 'static_branch_unlikely()'. So: > > s/static_key_likely()/static_branch_likely() > > and > > s/static_key_unlikely()/static_branch_unlikely() > > The rest of the doc appears to have it correctly. There are a few more > typos in there as well: > > 1) > > s/addtion/addition > > 2) > > " > The inc()/dec() interface is meant to be used exclusively from the > inc()/dec() for a given key. > " > > Was supposed to read: > > " > The inc()/dec() interface is meant to be used exclusively from the > enable()/disable() interface for a given key. > " > > However, I think we should just delete this sentence. As the API > inherently doesn't prevent this. The user just may need to be aware to > properly serialize operations. Would be nice to turn this into a patch! Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Chuck Ebbert <cebbert.lkml@gmail.com> |
|---|---|
| Date | 2015-09-17 03:10 +0200 |
| Message-ID | <q9vS2-4DE-9@gated-at.bofh.it> |
| In reply to | #1220974 |
On Tue, 08 Sep 2015 12:05:04 -0400 Jason Baron <jbaron@akamai.com> wrote: > > > On 09/07/2015 03:18 PM, Jonathan Corbet wrote: > > 412758cb2670 (jump label, locking/static_keys: Update docs) introduced a > > typo that might as well get fixed. > > > > Signed-off-by: Jonathan Corbet <corbet@lwn.net> > > --- > > Documentation/static-keys.txt | 2 +- > > include/linux/jump_label.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/static-keys.txt b/Documentation/static-keys.txt > > index f4cb0b2..ec91158 100644 > > --- a/Documentation/static-keys.txt > > +++ b/Documentation/static-keys.txt > > @@ -16,7 +16,7 @@ The updated API replacements are: > > DEFINE_STATIC_KEY_TRUE(key); > > DEFINE_STATIC_KEY_FALSE(key); > > static_key_likely() > > -statick_key_unlikely() > > +static_key_unlikely() > > > > 0) Abstract > > > > diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h > > index 7f653e8..0684bd3 100644 > > --- a/include/linux/jump_label.h > > +++ b/include/linux/jump_label.h > > @@ -22,7 +22,7 @@ > > * DEFINE_STATIC_KEY_TRUE(key); > > * DEFINE_STATIC_KEY_FALSE(key); > > * static_key_likely() > > - * statick_key_unlikely() > > + * static_key_unlikely() > > * > > * Jump labels provide an interface to generate dynamic branches using > > * self-modifying code. Assuming toolchain and architecture support, if we > > > > Thanks. I actually messed this up further. That's supposed to be, > 'static_branch_likely()', and 'static_branch_unlikely()'. So: > > s/static_key_likely()/static_branch_likely() > > and > > s/static_key_unlikely()/static_branch_unlikely() > I sent a patch to fix that part on August 25: https://lkml.org/lkml/2015/8/25/288 Did I send it to the wrong person? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jonathan Corbet <corbet@lwn.net> |
|---|---|
| Date | 2015-09-17 17:40 +0200 |
| Message-ID | <q9JrZ-7OO-49@gated-at.bofh.it> |
| In reply to | #1226608 |
On Wed, 16 Sep 2015 21:04:31 -0400 Chuck Ebbert <cebbert.lkml@gmail.com> wrote: > I sent a patch to fix that part on August 25: > https://lkml.org/lkml/2015/8/25/288 > > Did I send it to the wrong person? Well, at that date, I think that the relevant text was only to be found in the tip tree. So the logical targets for the patch would have been the tip maintainers and/or Jason, whose text you were modifying. You copied neither, so it's not entirely surprising that the patch fell on the floor. Apologies, anyway, I certainly didn't mean to step in on something you'd already fixed. I'd suggest resubmitting the remaining parts of that patch when you get a chance. jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web