Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1220562 > unrolled thread

Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps

Started byJiri Olsa <jolsa@redhat.com>
First post2015-09-08 10:10 +0200
Last post2015-09-15 16:20 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps Jiri Olsa <jolsa@redhat.com> - 2015-09-08 10:10 +0200
    Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps Adrian Hunter <adrian.hunter@intel.com> - 2015-09-15 09:00 +0200
      Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps Arnaldo Carvalho de Melo <acme@redhat.com> - 2015-09-15 15:10 +0200
      Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps Arnaldo Carvalho de Melo <acme@redhat.com> - 2015-09-15 16:20 +0200

#1220562 — Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps

FromJiri Olsa <jolsa@redhat.com>
Date2015-09-08 10:10 +0200
SubjectRe: [PATCH V3 00/14] perf tools: Fix gaps propagating maps
Message-ID<q6m8y-6Rc-1@gated-at.bofh.it>
On Tue, Sep 08, 2015 at 10:58:48AM +0300, Adrian Hunter wrote:
> Hi
> 
> Here is V3 of "Fix gaps propagating maps" that fixes some problems
> revealed by to d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads")
> 
> Changes in V3:
> 
> 	perf tools: Remove redundant validation from perf_evlist__propagate_maps
> 		perf_evlist__set_maps also doesn't need to return an error anymore
> 
> 	perf tools: Add evlist->has_user_cpus
> 		Adjusted due to perf_evlist__set_maps change
> 
> 	perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps()
> 		Adjusted due to perf_evlist__set_maps change
> 
> 	perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps
> 		Adjusted due to perf_evlist__set_maps change
> 
> 	perf tools: Fix task exit test setting maps
> 		Adjusted due to perf_evlist__set_maps change
> 
> 	perf tools: Fix software clock events test setting maps
> 		Adjusted due to perf_evlist__set_maps change

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1224678

FromAdrian Hunter <adrian.hunter@intel.com>
Date2015-09-15 09:00 +0200
Message-ID<q8SnE-5Cp-9@gated-at.bofh.it>
In reply to#1220562
On 08/09/15 11:08, Jiri Olsa wrote:
> On Tue, Sep 08, 2015 at 10:58:48AM +0300, Adrian Hunter wrote:
>> Hi
>>
>> Here is V3 of "Fix gaps propagating maps" that fixes some problems
>> revealed by to d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads")
>>
>> Changes in V3:
>>
>> 	perf tools: Remove redundant validation from perf_evlist__propagate_maps
>> 		perf_evlist__set_maps also doesn't need to return an error anymore
>>
>> 	perf tools: Add evlist->has_user_cpus
>> 		Adjusted due to perf_evlist__set_maps change
>>
>> 	perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps()
>> 		Adjusted due to perf_evlist__set_maps change
>>
>> 	perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps
>> 		Adjusted due to perf_evlist__set_maps change
>>
>> 	perf tools: Fix task exit test setting maps
>> 		Adjusted due to perf_evlist__set_maps change
>>
>> 	perf tools: Fix software clock events test setting maps
>> 		Adjusted due to perf_evlist__set_maps change
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Hi Arnaldo

Please don't forget these.  Intel PT is broken on 4.3 without them i.e.

$ tools/perf/perf --version
perf version 4.3.rc1.gd25ed
$ tools/perf/perf record -e intel_pt//u uname
Error:
The sys_perf_event_open() syscall returned with 22 (Invalid argument) for
event (sched:sched_switch).

Regards
Adrian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1225072

FromArnaldo Carvalho de Melo <acme@redhat.com>
Date2015-09-15 15:10 +0200
Message-ID<q8Y9I-5HB-9@gated-at.bofh.it>
In reply to#1224678
Em Tue, Sep 15, 2015 at 09:52:56AM +0300, Adrian Hunter escreveu:
> On 08/09/15 11:08, Jiri Olsa wrote:
> > On Tue, Sep 08, 2015 at 10:58:48AM +0300, Adrian Hunter wrote:
> >> Hi
> >>
> >> Here is V3 of "Fix gaps propagating maps" that fixes some problems
> >> revealed by to d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads")
> >>
> >> Changes in V3:
> >>
> >> 	perf tools: Remove redundant validation from perf_evlist__propagate_maps
> >> 		perf_evlist__set_maps also doesn't need to return an error anymore
> >>
> >> 	perf tools: Add evlist->has_user_cpus
> >> 		Adjusted due to perf_evlist__set_maps change
> >>
> >> 	perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps()
> >> 		Adjusted due to perf_evlist__set_maps change
> >>
> >> 	perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps
> >> 		Adjusted due to perf_evlist__set_maps change
> >>
> >> 	perf tools: Fix task exit test setting maps
> >> 		Adjusted due to perf_evlist__set_maps change
> >>
> >> 	perf tools: Fix software clock events test setting maps
> >> 		Adjusted due to perf_evlist__set_maps change
> > 
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> 
> Hi Arnaldo
> 
> Please don't forget these.  Intel PT is broken on 4.3 without them i.e.
> 
> $ tools/perf/perf --version
> perf version 4.3.rc1.gd25ed
> $ tools/perf/perf record -e intel_pt//u uname
> Error:
> The sys_perf_event_open() syscall returned with 22 (Invalid argument) for
> event (sched:sched_switch).

Ok, so this needs to go to perf/urgent, checking them now.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1225158

FromArnaldo Carvalho de Melo <acme@redhat.com>
Date2015-09-15 16:20 +0200
Message-ID<q8Zfr-7ex-3@gated-at.bofh.it>
In reply to#1224678
Em Tue, Sep 15, 2015 at 09:52:56AM +0300, Adrian Hunter escreveu:
> On 08/09/15 11:08, Jiri Olsa wrote:
> > On Tue, Sep 08, 2015 at 10:58:48AM +0300, Adrian Hunter wrote:
> >> Hi
> >>
> >> Here is V3 of "Fix gaps propagating maps" that fixes some problems
> >> revealed by to d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads")
> >>
> >> Changes in V3:
> >>
> >> 	perf tools: Remove redundant validation from perf_evlist__propagate_maps
> >> 		perf_evlist__set_maps also doesn't need to return an error anymore
> >>
> >> 	perf tools: Add evlist->has_user_cpus
> >> 		Adjusted due to perf_evlist__set_maps change
> >>
> >> 	perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps()
> >> 		Adjusted due to perf_evlist__set_maps change
> >>
> >> 	perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps
> >> 		Adjusted due to perf_evlist__set_maps change
> >>
> >> 	perf tools: Fix task exit test setting maps
> >> 		Adjusted due to perf_evlist__set_maps change
> >>
> >> 	perf tools: Fix software clock events test setting maps
> >> 		Adjusted due to perf_evlist__set_maps change
> > 
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> 
> Hi Arnaldo
> 
> Please don't forget these.  Intel PT is broken on 4.3 without them i.e.
> 
> $ tools/perf/perf --version
> perf version 4.3.rc1.gd25ed
> $ tools/perf/perf record -e intel_pt//u uname
> Error:
> The sys_perf_event_open() syscall returned with 22 (Invalid argument) for
> event (sched:sched_switch).

Ok, applied the series, with just one change, which was patch-cosmetic,
see the other message I'll send.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web