Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1224664 > unrolled thread
| Started by | Valentin Rothberg <valentinrothberg@gmail.com> |
|---|---|
| First post | 2015-09-15 08:30 +0200 |
| Last post | 2015-09-15 16:10 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
spi/bcm63xx: unknown CONFIG_BIG_ENDIAN Valentin Rothberg <valentinrothberg@gmail.com> - 2015-09-15 08:30 +0200
Re: spi/bcm63xx: unknown CONFIG_BIG_ENDIAN Jonas Gorski <jogo@openwrt.org> - 2015-09-15 09:50 +0200
Re: spi/bcm63xx: unknown CONFIG_BIG_ENDIAN Mark Brown <broonie@kernel.org> - 2015-09-15 10:50 +0200
Re: spi/bcm63xx: unknown CONFIG_BIG_ENDIAN Jonas Gorski <jogo@openwrt.org> - 2015-09-15 15:40 +0200
Re: spi/bcm63xx: unknown CONFIG_BIG_ENDIAN Mark Brown <broonie@kernel.org> - 2015-09-15 16:10 +0200
| From | Valentin Rothberg <valentinrothberg@gmail.com> |
|---|---|
| Date | 2015-09-15 08:30 +0200 |
| Subject | spi/bcm63xx: unknown CONFIG_BIG_ENDIAN |
| Message-ID | <q8RUB-54v-1@gated-at.bofh.it> |
Hi Jonas,
your commit 158fcc4e050a ("spi/bcm63xx: replace custom io accessors with
standard ones") has shown up in today's Linux next tree (i.e.,
next-20150915).
This commit adds four #ifdef blocks depending on CONFIG_BIG_ENDIAN,
which is not defined in Kconfig breaking the #ifdef #else conditions.
Is there a patch queued somewhere to add this option to Kconfig?
I found some other candidates like '__BIG_ENDIAN' which is used in other
drivers, or 'CPU_BIG_ENDIAN' which is defined for mips. Maybe they can
be used instead.
I detected this issue witch scripts/checkkconfigsymbols.py.
Kind regards,
Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jonas Gorski <jogo@openwrt.org> |
|---|---|
| Date | 2015-09-15 09:50 +0200 |
| Message-ID | <q8Ta2-6M4-3@gated-at.bofh.it> |
| In reply to | #1224664 |
Hi Valentin,
On 15.09.2015 08:24, Valentin Rothberg wrote:
> Hi Jonas,
>
> your commit 158fcc4e050a ("spi/bcm63xx: replace custom io accessors with
> standard ones") has shown up in today's Linux next tree (i.e.,
> next-20150915).
>
> This commit adds four #ifdef blocks depending on CONFIG_BIG_ENDIAN,
> which is not defined in Kconfig breaking the #ifdef #else conditions.
>
> Is there a patch queued somewhere to add this option to Kconfig?
>
> I found some other candidates like '__BIG_ENDIAN' which is used in other
> drivers, or 'CPU_BIG_ENDIAN' which is defined for mips. Maybe they can
> be used instead.
You are right, and I had fixed this in my V2 patchset from saturday, but
appearently this wasn't fast enough.
Mark? If you can drop patches 2 to 4 that would be easiest for me, but if
you don't do rebases on your for-next branch, then I'll rewrite the
patches to apply on top of the already applied old versions and send a v3.
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-09-15 10:50 +0200 |
| Message-ID | <q8U66-86T-3@gated-at.bofh.it> |
| In reply to | #1224724 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Sep 15, 2015 at 09:40:30AM +0200, Jonas Gorski wrote: > Mark? If you can drop patches 2 to 4 that would be easiest for me, but if > you don't do rebases on your for-next branch, then I'll rewrite the > patches to apply on top of the already applied old versions and send a v3. No, please submit incremental modifications as incremental modifications.
[toc] | [prev] | [next] | [standalone]
| From | Jonas Gorski <jogo@openwrt.org> |
|---|---|
| Date | 2015-09-15 15:40 +0200 |
| Message-ID | <q8YCK-6fP-17@gated-at.bofh.it> |
| In reply to | #1224769 |
On 15.09.2015 10:40, Mark Brown wrote: > On Tue, Sep 15, 2015 at 09:40:30AM +0200, Jonas Gorski wrote: > >> Mark? If you can drop patches 2 to 4 that would be easiest for me, but if >> you don't do rebases on your for-next branch, then I'll rewrite the >> patches to apply on top of the already applied old versions and send a v3. > > No, please submit incremental modifications as incremental > modifications. IS there anything I can do to avoid this happining again, like a patchwork where I can mark my older versions as superseded? I admit I didn't expect partial application of the (old) series. Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2015-09-15 16:10 +0200 |
| Message-ID | <q8Z5M-73c-31@gated-at.bofh.it> |
| In reply to | #1225103 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Sep 15, 2015 at 03:34:17PM +0200, Jonas Gorski wrote: > On 15.09.2015 10:40, Mark Brown wrote: > > No, please submit incremental modifications as incremental > > modifications. > IS there anything I can do to avoid this happining again, like a patchwork > where I can mark my older versions as superseded? I admit I didn't expect > partial application of the (old) series. No, not really - the main thing here was that there didn't seem to have been any discussion about the original series.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web