Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1225009 > unrolled thread
| Started by | Pavel Machek <pavel@ucw.cz> |
|---|---|
| First post | 2015-09-15 13:30 +0200 |
| Last post | 2015-09-15 14:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 10/13] twl4030_charger: add software controlled linear charging mode. Pavel Machek <pavel@ucw.cz> - 2015-09-15 13:30 +0200
Re: [Gta04-owner] [PATCH 10/13] twl4030_charger: add software controlled linear charging mode. Christ van Willegen <cvwillegen@gmail.com> - 2015-09-15 14:10 +0200
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2015-09-15 13:30 +0200 |
| Subject | Re: [PATCH 10/13] twl4030_charger: add software controlled linear charging mode. |
| Message-ID | <q8WAW-3m7-13@gated-at.bofh.it> |
On Thu 2015-07-30 10:11:24, NeilBrown wrote:
>
> Add a 'continuous' option for usb charging which enables
> the "linear" charging mode of the twl4030.
>
> Linear charging does a good job with not-so-reliable power sources.
> Auto mode does not work well as it switches off when voltage drops
> momentarily. Care must be taken not to over-charge.
Can you explain how the user can "care not to over-charge"?
> @@ -750,6 +784,17 @@ static int twl4030_bci_get_property(struct power_supply *psy,
> is_charging = state & TWL4030_MSTATEC_USB;
> else
> is_charging = state & TWL4030_MSTATEC_AC;
> + if (!is_charging) {
> + u8 s;
> + twl4030_bci_read(TWL4030_BCIMDEN, &s);
> + if (psy->desc->type == POWER_SUPPLY_TYPE_USB)
> + is_charging = s & 1;
> + else
> + is_charging = s & 2;
> + if (is_charging)
> + /* A little white lie */
> + state = TWL4030_MSTATEC_QUICK1;
I'm not sure... can't this white lie turn into black smoke?
Like.. normally, when battery is below something (like 3.5V) it must
not be quick-charged (because something is very wrong with it). Are
you just forcing the quick charge here?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Christ van Willegen <cvwillegen@gmail.com> |
|---|---|
| Date | 2015-09-15 14:10 +0200 |
| Subject | Re: [Gta04-owner] [PATCH 10/13] twl4030_charger: add software controlled linear charging mode. |
| Message-ID | <q8XdE-4lR-19@gated-at.bofh.it> |
| In reply to | #1225009 |
Hi all, On Tue, Sep 15, 2015 at 1:28 PM, Pavel Machek <pavel@ucw.cz> wrote: > On Thu 2015-07-30 10:11:24, NeilBrown wrote: >> >> Add a 'continuous' option for usb charging which enables >> the "linear" charging mode of the twl4030. >> >> Linear charging does a good job with not-so-reliable power sources. >> Auto mode does not work well as it switches off when voltage drops >> momentarily. Care must be taken not to over-charge. > > Can you explain how the user can "care not to over-charge"? Just my $0.02, I assumed (whoops!) that Neil mean that the _code_ should take care not to over-charge... but not sure how he intended to to that. Anyway, that was my interpretation of the (indeed, it could be explained in different ways...) comment. Christ van Willegen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web