Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1224386 > unrolled thread
| Started by | Nicolas Joseph <nicolas.joseph@homecomputing.fr> |
|---|---|
| First post | 2015-09-14 20:10 +0200 |
| Last post | 2015-09-15 11:40 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging/rtl8192u: remove unused function Nicolas Joseph <nicolas.joseph@homecomputing.fr> - 2015-09-14 20:10 +0200
Re: [PATCH] staging/rtl8192u: remove unused function Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-14 20:30 +0200
Re: [PATCH] staging/rtl8192u: remove unused function Nicolas Joseph <nicolas.joseph@homecomputing.fr> - 2015-09-15 11:30 +0200
[PATCH] staging/rtl8192u: remove unused function Nicolas Joseph <nicolas.joseph@homecomputing.fr> - 2015-09-15 11:40 +0200
| From | Nicolas Joseph <nicolas.joseph@homecomputing.fr> |
|---|---|
| Date | 2015-09-14 20:10 +0200 |
| Subject | [PATCH] staging/rtl8192u: remove unused function |
| Message-ID | <q8Gmv-5nU-31@gated-at.bofh.it> |
Remove N_DBPSOfRate used in ComputeTxTime, remove by
commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
---
drivers/staging/rtl8192u/r8192U_core.c | 44 ----------------------------------
1 file changed, 44 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index b143b36..80a6a4f 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -1227,50 +1227,6 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
return 0;
}
-u16 N_DBPSOfRate(u16 DataRate)
-{
- u16 N_DBPS = 24;
-
- switch (DataRate) {
- case 60:
- N_DBPS = 24;
- break;
-
- case 90:
- N_DBPS = 36;
- break;
-
- case 120:
- N_DBPS = 48;
- break;
-
- case 180:
- N_DBPS = 72;
- break;
-
- case 240:
- N_DBPS = 96;
- break;
-
- case 360:
- N_DBPS = 144;
- break;
-
- case 480:
- N_DBPS = 192;
- break;
-
- case 540:
- N_DBPS = 216;
- break;
-
- default:
- break;
- }
-
- return N_DBPS;
-}
-
short rtl819xU_tx_cmd(struct net_device *dev, struct sk_buff *skb)
{
struct r8192_priv *priv = ieee80211_priv(dev);
--
2.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Raphaël Beamonte <raphael.beamonte@gmail.com> |
|---|---|
| Date | 2015-09-14 20:30 +0200 |
| Message-ID | <q8GFP-5Kz-3@gated-at.bofh.it> |
| In reply to | #1224386 |
2015-09-14 14:00 GMT-04:00 Nicolas Joseph <nicolas.joseph@homecomputing.fr>:
> Remove N_DBPSOfRate used in ComputeTxTime, remove by
> commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
>
> Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 44 ----------------------------------
> 1 file changed, 44 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index b143b36..80a6a4f 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -1227,50 +1227,6 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
> return 0;
> }
>
> -u16 N_DBPSOfRate(u16 DataRate)
> -{
> - u16 N_DBPS = 24;
> -
> - switch (DataRate) {
> - case 60:
> - N_DBPS = 24;
> - break;
> -
> - case 90:
> - N_DBPS = 36;
> - break;
> -
> - case 120:
> - N_DBPS = 48;
> - break;
> -
> - case 180:
> - N_DBPS = 72;
> - break;
> -
> - case 240:
> - N_DBPS = 96;
> - break;
> -
> - case 360:
> - N_DBPS = 144;
> - break;
> -
> - case 480:
> - N_DBPS = 192;
> - break;
> -
> - case 540:
> - N_DBPS = 216;
> - break;
> -
> - default:
> - break;
> - }
> -
> - return N_DBPS;
> -}
> -
> short rtl819xU_tx_cmd(struct net_device *dev, struct sk_buff *skb)
> {
> struct r8192_priv *priv = ieee80211_priv(dev);
> --
> 2.5.2
>
Not sure the commit message is really clear. Something like this seems
more clean to me:
"Remove unused function N_DBPSOfRate. This function was only
used by function ComputeTxTime that was removed in a previous
commit."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Joseph <nicolas.joseph@homecomputing.fr> |
|---|---|
| Date | 2015-09-15 11:30 +0200 |
| Message-ID | <q8UIR-FE-71@gated-at.bofh.it> |
| In reply to | #1224392 |
Le 14/09/15 à 14:25, Raphaël Beamonte a écrit : > Not sure the commit message is really clear. Something like this seems > more clean to me: > "Remove unused function N_DBPSOfRate. This function was only > used by function ComputeTxTime that was removed in a previous > commit." Indeed, is more clear. I repost my path with this commit message, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Joseph <nicolas.joseph@homecomputing.fr> |
|---|---|
| Date | 2015-09-15 11:40 +0200 |
| Message-ID | <q8USu-QT-39@gated-at.bofh.it> |
| In reply to | #1224392 |
Remove unused function N_DBPSOfRate. This function was only used by
function ComputeTxTime that was removed in the previous
commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
---
drivers/staging/rtl8192u/r8192U_core.c | 44 ----------------------------------
1 file changed, 44 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index b143b36..80a6a4f 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -1227,50 +1227,6 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
return 0;
}
-u16 N_DBPSOfRate(u16 DataRate)
-{
- u16 N_DBPS = 24;
-
- switch (DataRate) {
- case 60:
- N_DBPS = 24;
- break;
-
- case 90:
- N_DBPS = 36;
- break;
-
- case 120:
- N_DBPS = 48;
- break;
-
- case 180:
- N_DBPS = 72;
- break;
-
- case 240:
- N_DBPS = 96;
- break;
-
- case 360:
- N_DBPS = 144;
- break;
-
- case 480:
- N_DBPS = 192;
- break;
-
- case 540:
- N_DBPS = 216;
- break;
-
- default:
- break;
- }
-
- return N_DBPS;
-}
-
short rtl819xU_tx_cmd(struct net_device *dev, struct sk_buff *skb)
{
struct r8192_priv *priv = ieee80211_priv(dev);
--
2.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web