Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1224167 > unrolled thread

LTP and commit e1d7ba8735551ed7 ("time: Always make sure wall_to_monotonic isn't positive")

Back to article view | Back to linux.kernel

Contents

  LTP and commit e1d7ba8735551ed7 ("time: Always make sure  wall_to_monotonic isn't positive") Mark Rutland <mark.rutland@arm.com> - 2015-09-14 15:50 +0200
    Re: LTP and commit e1d7ba8735551ed7 ("time: Always make sure  wall_to_monotonic isn't positive") Cyril Hrubis <chrubis@suse.cz> - 2015-09-15 10:40 +0200

#1224167 — LTP and commit e1d7ba8735551ed7 ("time: Always make sure wall_to_monotonic isn't positive")

Hi,

While testing v4.3-rc1 with the LTP, we spotted failures in a couple of
timekeeping tests, which seem to be a result of commit e1d7ba8735551ed7
("time: Always make sure wall_to_monotonic isn't positive").

In both cases this is because the new time would be before the boot
time, so I guess these are covered by the caveat at the end of the
commit message.

settimeofday01 [1] tries tries to settimeofday() with a timeval 100s and
100ns, while clock_gettime02 [2] tries to clock_settime to 1s and
100ns. Neither expect -EINVAL, and report failure with the new
behaviour.

While I don't know that any "real" software is affected, I thought I
should let you know.

Thanks,
Mark.

[1] https://github.com/linux-test-project/ltp/blob/20150903/testcases/kernel/syscalls/settimeofday/settimeofday01.c
[2] https://github.com/linux-test-project/ltp/blob/20150903/testcases/kernel/timers/clock_settime/clock_settime02.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1224763

Hi!
> While testing v4.3-rc1 with the LTP, we spotted failures in a couple of
> timekeeping tests, which seem to be a result of commit e1d7ba8735551ed7
> ("time: Always make sure wall_to_monotonic isn't positive").
> 
> In both cases this is because the new time would be before the boot
> time, so I guess these are covered by the caveat at the end of the
> commit message.
> 
> settimeofday01 [1] tries tries to settimeofday() with a timeval 100s and
> 100ns, while clock_gettime02 [2] tries to clock_settime to 1s and
> 100ns. Neither expect -EINVAL, and report failure with the new
> behaviour.
> 
> While I don't know that any "real" software is affected, I thought I
> should let you know.

Thanks for the report, we allready have patch for the first testcase on
the mailing list that initializes the the timeval value to current time
+ small amount. I will have a look at the second test as well.

> [1] https://github.com/linux-test-project/ltp/blob/20150903/testcases/kernel/syscalls/settimeofday/settimeofday01.c
> [2] https://github.com/linux-test-project/ltp/blob/20150903/testcases/kernel/timers/clock_settime/clock_settime02.c

-- 
Cyril Hrubis
chrubis@suse.cz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web