Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1222165 > unrolled thread

[RFC][PATCH] mm: make zbud znd zpool to depend on zswap

Started bySergey Senozhatsky <sergey.senozhatsky@gmail.com>
First post2015-09-10 14:40 +0200
Last post2015-09-15 08:20 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [RFC][PATCH] mm: make zbud znd zpool to depend on zswap Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-09-10 14:40 +0200
    Re: [RFC][PATCH] mm: make zbud znd zpool to depend on zswap Dan Streetman <ddstreet@ieee.org> - 2015-09-15 08:10 +0200
      Re: [RFC][PATCH] mm: make zbud znd zpool to depend on zswap Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-15 08:20 +0200

#1222165 — [RFC][PATCH] mm: make zbud znd zpool to depend on zswap

FromSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date2015-09-10 14:40 +0200
Subject[RFC][PATCH] mm: make zbud znd zpool to depend on zswap
Message-ID<q79iX-1uR-37@gated-at.bofh.it>
There are no zbud and zpool users besides zswap so enabling
(and building) CONFIG_ZPOOL and CONFIG_ZBUD make sense only
when CONFIG_ZSWAP is enabled. In other words, make those
options to depend on CONFIG_ZSWAP.

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
 mm/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/Kconfig b/mm/Kconfig
index 3455a8d..eb48422 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -563,6 +563,7 @@ config ZSWAP
 
 config ZPOOL
 	tristate "Common API for compressed memory storage"
+	depends on ZSWAP
 	default n
 	help
 	  Compressed memory storage API.  This allows using either zbud or
@@ -570,6 +571,7 @@ config ZPOOL
 
 config ZBUD
 	tristate "Low density storage for compressed pages"
+	depends on ZSWAP
 	default n
 	help
 	  A special purpose allocator for storing compressed pages.
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1224654

FromDan Streetman <ddstreet@ieee.org>
Date2015-09-15 08:10 +0200
Message-ID<q8RBf-4I0-5@gated-at.bofh.it>
In reply to#1222165
On Thu, Sep 10, 2015 at 8:28 AM, Sergey Senozhatsky
<sergey.senozhatsky@gmail.com> wrote:
> There are no zbud and zpool users besides zswap so enabling
> (and building) CONFIG_ZPOOL and CONFIG_ZBUD make sense only
> when CONFIG_ZSWAP is enabled. In other words, make those
> options to depend on CONFIG_ZSWAP.

Let's wait on this until the patches to add zpool support to zram go
one way or the other.  If they don't make it in, I'm fine with this,
and even moving the zpool.h header into mm/ instead of include/linux/

>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
>  mm/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 3455a8d..eb48422 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -563,6 +563,7 @@ config ZSWAP
>
>  config ZPOOL
>         tristate "Common API for compressed memory storage"
> +       depends on ZSWAP
>         default n
>         help
>           Compressed memory storage API.  This allows using either zbud or
> @@ -570,6 +571,7 @@ config ZPOOL
>
>  config ZBUD
>         tristate "Low density storage for compressed pages"
> +       depends on ZSWAP
>         default n
>         help
>           A special purpose allocator for storing compressed pages.
> --
> 2.5.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1224661

FromSergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Date2015-09-15 08:20 +0200
Message-ID<q8RKW-4Tg-7@gated-at.bofh.it>
In reply to#1224654
On (09/15/15 02:06), Dan Streetman wrote:
> > There are no zbud and zpool users besides zswap so enabling
> > (and building) CONFIG_ZPOOL and CONFIG_ZBUD make sense only
> > when CONFIG_ZSWAP is enabled. In other words, make those
> > options to depend on CONFIG_ZSWAP.
> 
> Let's wait on this until the patches to add zpool support to zram go
> one way or the other.  If they don't make it in, I'm fine with this,
> and even moving the zpool.h header into mm/ instead of include/linux/
> 

agree.

	-ss

> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > ---
> >  mm/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/mm/Kconfig b/mm/Kconfig
> > index 3455a8d..eb48422 100644
> > --- a/mm/Kconfig
> > +++ b/mm/Kconfig
> > @@ -563,6 +563,7 @@ config ZSWAP
> >
> >  config ZPOOL
> >         tristate "Common API for compressed memory storage"
> > +       depends on ZSWAP
> >         default n
> >         help
> >           Compressed memory storage API.  This allows using either zbud or
> > @@ -570,6 +571,7 @@ config ZPOOL
> >
> >  config ZBUD
> >         tristate "Low density storage for compressed pages"
> > +       depends on ZSWAP
> >         default n
> >         help
> >           A special purpose allocator for storing compressed pages.
> > --
> > 2.5.1
> >
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web