Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1224349 > unrolled thread
| Started by | Mikael Pettersson <mikpelinux@gmail.com> |
|---|---|
| First post | 2015-09-14 19:10 +0200 |
| Last post | 2015-09-14 20:10 +0200 |
| Articles | 9 — 4 participants |
Back to article view | Back to linux.kernel
[4.3-rc1 regression] modular 8250 doesn't load Mikael Pettersson <mikpelinux@gmail.com> - 2015-09-14 19:10 +0200
Re: [4.3-rc1 regression] modular 8250 doesn't load Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-14 20:00 +0200
Re: [4.3-rc1 regression] modular 8250 doesn't load Mikael Pettersson <mikpelinux@gmail.com> - 2015-09-14 20:10 +0200
Re: [4.3-rc1 regression] modular 8250 doesn't load Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-14 21:00 +0200
Re: [4.3-rc1 regression] modular 8250 doesn't load Mikael Pettersson <mikpelinux@gmail.com> - 2015-09-14 22:50 +0200
Re: [4.3-rc1 regression] modular 8250 doesn't load Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-14 23:20 +0200
[PATCH] Re: [4.3-rc1 regression] modular 8250 doesn't load Jonathan McDowell <noodles@earth.li> - 2015-09-21 22:50 +0200
Re: [4.3-rc1 regression] modular 8250 doesn't load Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-14 23:20 +0200
Re: [4.3-rc1 regression] modular 8250 doesn't load Albino B Neto <bino@riseup.net> - 2015-09-14 20:10 +0200
| From | Mikael Pettersson <mikpelinux@gmail.com> |
|---|---|
| Date | 2015-09-14 19:10 +0200 |
| Subject | [4.3-rc1 regression] modular 8250 doesn't load |
| Message-ID | <q8Fqp-432-9@gated-at.bofh.it> |
I have CONFIG_SERIAL_8250=m. With 4.2 '/sbin/modprobe 8250' worked and resulted in: [ 41.354550] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled [ 41.375156] serial8250: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A With 4.3-rc1 however the command fails and logs the following: [ 34.140300] 8250_base: module license 'unspecified' taints kernel. [ 34.141846] Disabling lock debugging due to kernel taint [ 34.143388] 8250_base: Unknown symbol uart_insert_char (err 0) [ 34.144908] 8250_base: Unknown symbol uart_handle_dcd_change (err 0) [ 34.146439] 8250_base: Unknown symbol __pm_runtime_resume (err 0) [ 34.147901] 8250_base: Unknown symbol tty_termios_encode_baud_rate (err 0) [ 34.149354] 8250_base: Unknown symbol uart_handle_cts_change (err 0) [ 34.150798] 8250_base: Unknown symbol __pm_runtime_suspend (err 0) [ 34.152240] 8250_base: Unknown symbol nr_irqs (err 0) Relevant .config fragments: CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y CONFIG_MODVERSIONS=y # CONFIG_SERIAL_NONSTANDARD is not set CONFIG_SERIAL_8250=m # CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set # CONFIG_SERIAL_8250_PNP is not set # CONFIG_SERIAL_8250_PCI is not set CONFIG_SERIAL_8250_NR_UARTS=4 CONFIG_SERIAL_8250_RUNTIME_UARTS=4 # CONFIG_SERIAL_8250_EXTENDED is not set # CONFIG_SERIAL_8250_DW is not set # CONFIG_SERIAL_8250_FINTEK is not set # CONFIG_SERIAL_UARTLITE is not set CONFIG_SERIAL_CORE=m # CONFIG_SERIAL_JSM is not set # CONFIG_SERIAL_SCCNXP is not set # CONFIG_SERIAL_SC16IS7XX is not set # CONFIG_SERIAL_ALTERA_JTAGUART is not set # CONFIG_SERIAL_ALTERA_UART is not set # CONFIG_SERIAL_ARC is not set # CONFIG_SERIAL_RP2 is not set # CONFIG_SERIAL_FSL_LPUART is not set /Mikael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-09-14 20:00 +0200 |
| Message-ID | <q8GcO-4Xj-9@gated-at.bofh.it> |
| In reply to | #1224349 |
On Mon, Sep 14, 2015 at 07:08:10PM +0200, Mikael Pettersson wrote: > I have CONFIG_SERIAL_8250=m. With 4.2 '/sbin/modprobe 8250' worked > and resulted in: > > [ 41.354550] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled > [ 41.375156] serial8250: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A > > With 4.3-rc1 however the command fails and logs the following: > > [ 34.140300] 8250_base: module license 'unspecified' taints kernel. Oops, need to fix that. > [ 34.141846] Disabling lock debugging due to kernel taint > [ 34.143388] 8250_base: Unknown symbol uart_insert_char (err 0) > [ 34.144908] 8250_base: Unknown symbol uart_handle_dcd_change (err 0) > [ 34.146439] 8250_base: Unknown symbol __pm_runtime_resume (err 0) > [ 34.147901] 8250_base: Unknown symbol tty_termios_encode_baud_rate (err 0) > [ 34.149354] 8250_base: Unknown symbol uart_handle_cts_change (err 0) > [ 34.150798] 8250_base: Unknown symbol __pm_runtime_suspend (err 0) > [ 34.152240] 8250_base: Unknown symbol nr_irqs (err 0) Are you sure you did 'modprobe' and not 'insmod'? Peter, care to send a module license fix for this new module you created? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Mikael Pettersson <mikpelinux@gmail.com> |
|---|---|
| Date | 2015-09-14 20:10 +0200 |
| Message-ID | <q8Gmu-5nU-11@gated-at.bofh.it> |
| In reply to | #1224375 |
Greg Kroah-Hartman writes: > On Mon, Sep 14, 2015 at 07:08:10PM +0200, Mikael Pettersson wrote: > > I have CONFIG_SERIAL_8250=m. With 4.2 '/sbin/modprobe 8250' worked > > and resulted in: > > > > [ 41.354550] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled > > [ 41.375156] serial8250: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A > > > > With 4.3-rc1 however the command fails and logs the following: > > > > [ 34.140300] 8250_base: module license 'unspecified' taints kernel. > > Oops, need to fix that. > > > [ 34.141846] Disabling lock debugging due to kernel taint > > [ 34.143388] 8250_base: Unknown symbol uart_insert_char (err 0) > > [ 34.144908] 8250_base: Unknown symbol uart_handle_dcd_change (err 0) > > [ 34.146439] 8250_base: Unknown symbol __pm_runtime_resume (err 0) > > [ 34.147901] 8250_base: Unknown symbol tty_termios_encode_baud_rate (err 0) > > [ 34.149354] 8250_base: Unknown symbol uart_handle_cts_change (err 0) > > [ 34.150798] 8250_base: Unknown symbol __pm_runtime_suspend (err 0) > > [ 34.152240] 8250_base: Unknown symbol nr_irqs (err 0) > > Are you sure you did 'modprobe' and not 'insmod'? Yes, I used modprobe. I double-checked. > Peter, care to send a module license fix for this new module you > created? /Mikael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-09-14 21:00 +0200 |
| Message-ID | <q8H8S-6mh-19@gated-at.bofh.it> |
| In reply to | #1224382 |
On Mon, Sep 14, 2015 at 08:06:21PM +0200, Mikael Pettersson wrote: > Greg Kroah-Hartman writes: > > On Mon, Sep 14, 2015 at 07:08:10PM +0200, Mikael Pettersson wrote: > > > I have CONFIG_SERIAL_8250=m. With 4.2 '/sbin/modprobe 8250' worked > > > and resulted in: > > > > > > [ 41.354550] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled > > > [ 41.375156] serial8250: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A > > > > > > With 4.3-rc1 however the command fails and logs the following: > > > > > > [ 34.140300] 8250_base: module license 'unspecified' taints kernel. > > > > Oops, need to fix that. > > > > > [ 34.141846] Disabling lock debugging due to kernel taint > > > [ 34.143388] 8250_base: Unknown symbol uart_insert_char (err 0) > > > [ 34.144908] 8250_base: Unknown symbol uart_handle_dcd_change (err 0) > > > [ 34.146439] 8250_base: Unknown symbol __pm_runtime_resume (err 0) > > > [ 34.147901] 8250_base: Unknown symbol tty_termios_encode_baud_rate (err 0) > > > [ 34.149354] 8250_base: Unknown symbol uart_handle_cts_change (err 0) > > > [ 34.150798] 8250_base: Unknown symbol __pm_runtime_suspend (err 0) > > > [ 34.152240] 8250_base: Unknown symbol nr_irqs (err 0) > > > > Are you sure you did 'modprobe' and not 'insmod'? > > Yes, I used modprobe. I double-checked. Then your build should have failed if these functions are not being exported properly by your .config. Most of these are in the serial_core module, is that present/loaded? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Mikael Pettersson <mikpelinux@gmail.com> |
|---|---|
| Date | 2015-09-14 22:50 +0200 |
| Message-ID | <q8IRk-qR-19@gated-at.bofh.it> |
| In reply to | #1224411 |
Greg Kroah-Hartman writes: > On Mon, Sep 14, 2015 at 08:06:21PM +0200, Mikael Pettersson wrote: > > Greg Kroah-Hartman writes: > > > On Mon, Sep 14, 2015 at 07:08:10PM +0200, Mikael Pettersson wrote: > > > > I have CONFIG_SERIAL_8250=m. With 4.2 '/sbin/modprobe 8250' worked > > > > and resulted in: > > > > > > > > [ 41.354550] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled > > > > [ 41.375156] serial8250: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A > > > > > > > > With 4.3-rc1 however the command fails and logs the following: > > > > > > > > [ 34.140300] 8250_base: module license 'unspecified' taints kernel. > > > > > > Oops, need to fix that. > > > > > > > [ 34.141846] Disabling lock debugging due to kernel taint > > > > [ 34.143388] 8250_base: Unknown symbol uart_insert_char (err 0) > > > > [ 34.144908] 8250_base: Unknown symbol uart_handle_dcd_change (err 0) > > > > [ 34.146439] 8250_base: Unknown symbol __pm_runtime_resume (err 0) > > > > [ 34.147901] 8250_base: Unknown symbol tty_termios_encode_baud_rate (err 0) > > > > [ 34.149354] 8250_base: Unknown symbol uart_handle_cts_change (err 0) > > > > [ 34.150798] 8250_base: Unknown symbol __pm_runtime_suspend (err 0) > > > > [ 34.152240] 8250_base: Unknown symbol nr_irqs (err 0) > > > > > > Are you sure you did 'modprobe' and not 'insmod'? > > > > Yes, I used modprobe. I double-checked. > > Then your build should have failed if these functions are not being > exported properly by your .config. Most of these are in the serial_core > module, is that present/loaded? Yes, serial_core is loaded. uart_insert_char is EXPORT_SYMBOL_GPL, so could the missing license tag be preventing 8250_core from binding to it? (I haven't checked the other symbols but I assume they are also _GPL.) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-09-14 23:20 +0200 |
| Message-ID | <q8Jkl-1e5-1@gated-at.bofh.it> |
| In reply to | #1224446 |
On Mon, Sep 14, 2015 at 02:12:43PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Sep 14, 2015 at 10:42:24PM +0200, Mikael Pettersson wrote:
> > Greg Kroah-Hartman writes:
> > > On Mon, Sep 14, 2015 at 08:06:21PM +0200, Mikael Pettersson wrote:
> > > > Greg Kroah-Hartman writes:
> > > > > On Mon, Sep 14, 2015 at 07:08:10PM +0200, Mikael Pettersson wrote:
> > > > > > I have CONFIG_SERIAL_8250=m. With 4.2 '/sbin/modprobe 8250' worked
> > > > > > and resulted in:
> > > > > >
> > > > > > [ 41.354550] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
> > > > > > [ 41.375156] serial8250: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
> > > > > >
> > > > > > With 4.3-rc1 however the command fails and logs the following:
> > > > > >
> > > > > > [ 34.140300] 8250_base: module license 'unspecified' taints kernel.
> > > > >
> > > > > Oops, need to fix that.
> > > > >
> > > > > > [ 34.141846] Disabling lock debugging due to kernel taint
> > > > > > [ 34.143388] 8250_base: Unknown symbol uart_insert_char (err 0)
> > > > > > [ 34.144908] 8250_base: Unknown symbol uart_handle_dcd_change (err 0)
> > > > > > [ 34.146439] 8250_base: Unknown symbol __pm_runtime_resume (err 0)
> > > > > > [ 34.147901] 8250_base: Unknown symbol tty_termios_encode_baud_rate (err 0)
> > > > > > [ 34.149354] 8250_base: Unknown symbol uart_handle_cts_change (err 0)
> > > > > > [ 34.150798] 8250_base: Unknown symbol __pm_runtime_suspend (err 0)
> > > > > > [ 34.152240] 8250_base: Unknown symbol nr_irqs (err 0)
> > > > >
> > > > > Are you sure you did 'modprobe' and not 'insmod'?
> > > >
> > > > Yes, I used modprobe. I double-checked.
> > >
> > > Then your build should have failed if these functions are not being
> > > exported properly by your .config. Most of these are in the serial_core
> > > module, is that present/loaded?
> >
> > Yes, serial_core is loaded.
> >
> > uart_insert_char is EXPORT_SYMBOL_GPL, so could the missing license tag be preventing
> > 8250_core from binding to it? (I haven't checked the other symbols but I assume they
> > are also _GPL.)
>
> Ah, crap, yes, you are right. You can test this with a simple:
> MODULE_LICENSE("GPL");
> line added to the 8250_base file.
Wait, 8250_base.c has a module license line.
Can you provide a full .config file?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jonathan McDowell <noodles@earth.li> |
|---|---|
| Date | 2015-09-21 22:50 +0200 |
| Subject | [PATCH] Re: [4.3-rc1 regression] modular 8250 doesn't load |
| Message-ID | <qbgc9-NQ-7@gated-at.bofh.it> |
| In reply to | #1224455 |
In article <20150914211827.GA3440@kroah.com> (earth.lists.linux-kernel)
you wrote:
> On Mon, Sep 14, 2015 at 02:12:43PM -0700, Greg Kroah-Hartman wrote:
> > On Mon, Sep 14, 2015 at 10:42:24PM +0200, Mikael Pettersson wrote:
> > > Greg Kroah-Hartman writes: uart_insert_char is EXPORT_SYMBOL_GPL,
> > > so could the missing license tag be preventing 8250_core from
> > > binding to it? (I haven't checked the other symbols but I assume
> > > they are also _GPL.)
> >
> > Ah, crap, yes, you are right. You can test this with a simple:
> > MODULE_LICENSE("GPL"); line added to the 8250_base file.
> Wait, 8250_base.c has a module license line.
8250_base.c doesn't exist; it is built from 8250_port.c and 8250_dma.c,
neither of which have a MODULE_LICENSE line. Adding
MODULE_LICENSE("GPL") as per below fixes the issue for me (on 4.3-rc2):
-----
Author: Jonathan McDowell <noodles@earth.li>
Date: Mon Sep 21 21:20:53 2015 +0100
Add missing module license for 8250_base.ko
The split of the 8250 driver into a 8250_base/8250.ko resulted in a
lack of a license for the 8250_base.ko module. This caused the module
to fail to load and the kernel to be tainted. Add the appropriate
MODULE_LICENSE to 8250_port.c, which is always compiled into
8250_base.ko
Signed-off-by: Jonathan McDowell <noodles@earth.li>
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 54e6c8d..b1e0ba3 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -2910,3 +2910,5 @@ int serial8250_console_setup(struct uart_port *port, char *options, bool probe)
}
#endif /* CONFIG_SERIAL_8250_CONSOLE */
+
+MODULE_LICENSE("GPL");
-----
J.
--
Even the Evening Herald slags me off.
This .sig brought to you by the letter U and the number 21
Product of the Republic of HuggieTag
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-09-14 23:20 +0200 |
| Message-ID | <q8Jkl-1e5-3@gated-at.bofh.it> |
| In reply to | #1224446 |
On Mon, Sep 14, 2015 at 10:42:24PM +0200, Mikael Pettersson wrote:
> Greg Kroah-Hartman writes:
> > On Mon, Sep 14, 2015 at 08:06:21PM +0200, Mikael Pettersson wrote:
> > > Greg Kroah-Hartman writes:
> > > > On Mon, Sep 14, 2015 at 07:08:10PM +0200, Mikael Pettersson wrote:
> > > > > I have CONFIG_SERIAL_8250=m. With 4.2 '/sbin/modprobe 8250' worked
> > > > > and resulted in:
> > > > >
> > > > > [ 41.354550] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
> > > > > [ 41.375156] serial8250: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
> > > > >
> > > > > With 4.3-rc1 however the command fails and logs the following:
> > > > >
> > > > > [ 34.140300] 8250_base: module license 'unspecified' taints kernel.
> > > >
> > > > Oops, need to fix that.
> > > >
> > > > > [ 34.141846] Disabling lock debugging due to kernel taint
> > > > > [ 34.143388] 8250_base: Unknown symbol uart_insert_char (err 0)
> > > > > [ 34.144908] 8250_base: Unknown symbol uart_handle_dcd_change (err 0)
> > > > > [ 34.146439] 8250_base: Unknown symbol __pm_runtime_resume (err 0)
> > > > > [ 34.147901] 8250_base: Unknown symbol tty_termios_encode_baud_rate (err 0)
> > > > > [ 34.149354] 8250_base: Unknown symbol uart_handle_cts_change (err 0)
> > > > > [ 34.150798] 8250_base: Unknown symbol __pm_runtime_suspend (err 0)
> > > > > [ 34.152240] 8250_base: Unknown symbol nr_irqs (err 0)
> > > >
> > > > Are you sure you did 'modprobe' and not 'insmod'?
> > >
> > > Yes, I used modprobe. I double-checked.
> >
> > Then your build should have failed if these functions are not being
> > exported properly by your .config. Most of these are in the serial_core
> > module, is that present/loaded?
>
> Yes, serial_core is loaded.
>
> uart_insert_char is EXPORT_SYMBOL_GPL, so could the missing license tag be preventing
> 8250_core from binding to it? (I haven't checked the other symbols but I assume they
> are also _GPL.)
Ah, crap, yes, you are right. You can test this with a simple:
MODULE_LICENSE("GPL");
line added to the 8250_base file.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Albino B Neto <bino@riseup.net> |
|---|---|
| Date | 2015-09-14 20:10 +0200 |
| Message-ID | <q8Gmu-5nU-19@gated-at.bofh.it> |
| In reply to | #1224349 |
2015-09-14 14:08 GMT-03:00 Mikael Pettersson <mikpelinux@gmail.com>: > I have CONFIG_SERIAL_8250=m. With 4.2 '/sbin/modprobe 8250' worked > and resulted in: > > [ 41.354550] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled > [ 41.375156] serial8250: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A > Fix in code. > CONFIG_SERIAL_8250=m > # CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set > # CONFIG_SERIAL_8250_PNP is not set > # CONFIG_SERIAL_8250_PCI is not set > CONFIG_SERIAL_8250_NR_UARTS=4 > CONFIG_SERIAL_8250_RUNTIME_UARTS=4 > # CONFIG_SERIAL_8250_EXTENDED is not set > # CONFIG_SERIAL_8250_DW is not set > # CONFIG_SERIAL_8250_FINTEK is not set Do you use commands modprobe for load ? Albino -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web