Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1223672 > unrolled thread
| Started by | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| First post | 2015-09-13 16:00 +0200 |
| Last post | 2015-09-14 20:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] serial: sccnxp: convert devm irq to non devm version Julia Lawall <Julia.Lawall@lip6.fr> - 2015-09-13 16:00 +0200
Re: [PATCH] serial: sccnxp: convert devm irq to non devm version Fabio Estevam <festevam@gmail.com> - 2015-09-14 18:20 +0200
Re: [PATCH] serial: sccnxp: convert devm irq to non devm version Julia Lawall <julia.lawall@lip6.fr> - 2015-09-14 20:50 +0200
| From | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| Date | 2015-09-13 16:00 +0200 |
| Subject | [PATCH] serial: sccnxp: convert devm irq to non devm version |
| Message-ID | <q8fYZ-ZJ-5@gated-at.bofh.it> |
There seems to be no need to request an irq with a devm function, since the
irq is being freed explicitly.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Compile tested only.
drivers/tty/serial/sccnxp.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c
index fcf803f..d0d5fa9 100644
--- a/drivers/tty/serial/sccnxp.c
+++ b/drivers/tty/serial/sccnxp.c
@@ -963,11 +963,9 @@ static int sccnxp_probe(struct platform_device *pdev)
sccnxp_write(&s->port[0], SCCNXP_IMR_REG, 0);
if (!s->poll) {
- ret = devm_request_threaded_irq(&pdev->dev, s->irq, NULL,
- sccnxp_ist,
- IRQF_TRIGGER_FALLING |
- IRQF_ONESHOT,
- dev_name(&pdev->dev), s);
+ ret = request_threaded_irq(s->irq, NULL, sccnxp_ist,
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ dev_name(&pdev->dev), s);
if (!ret)
return 0;
@@ -994,7 +992,7 @@ static int sccnxp_remove(struct platform_device *pdev)
struct sccnxp_port *s = platform_get_drvdata(pdev);
if (!s->poll)
- devm_free_irq(&pdev->dev, s->irq, s);
+ free_irq(s->irq, s);
else
del_timer_sync(&s->timer);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Fabio Estevam <festevam@gmail.com> |
|---|---|
| Date | 2015-09-14 18:20 +0200 |
| Message-ID | <q8EE2-2St-17@gated-at.bofh.it> |
| In reply to | #1223672 |
On Sun, Sep 13, 2015 at 10:44 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> --- a/drivers/tty/serial/sccnxp.c
> +++ b/drivers/tty/serial/sccnxp.c
> @@ -963,11 +963,9 @@ static int sccnxp_probe(struct platform_device *pdev)
> sccnxp_write(&s->port[0], SCCNXP_IMR_REG, 0);
>
> if (!s->poll) {
> - ret = devm_request_threaded_irq(&pdev->dev, s->irq, NULL,
> - sccnxp_ist,
> - IRQF_TRIGGER_FALLING |
> - IRQF_ONESHOT,
> - dev_name(&pdev->dev), s);
> + ret = request_threaded_irq(s->irq, NULL, sccnxp_ist,
> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> + dev_name(&pdev->dev), s);
> if (!ret)
> return 0;
>
> @@ -994,7 +992,7 @@ static int sccnxp_remove(struct platform_device *pdev)
> struct sccnxp_port *s = platform_get_drvdata(pdev);
>
> if (!s->poll)
> - devm_free_irq(&pdev->dev, s->irq, s);
> + free_irq(s->irq, s);
Couldn't we just remove the devm_free_irq() and keep using
devm_request_threaded_irq()?
Like this:
--- a/drivers/tty/serial/sccnxp.c
+++ b/drivers/tty/serial/sccnxp.c
@@ -993,9 +993,7 @@ static int sccnxp_remove(struct platform_device *pdev)
int i;
struct sccnxp_port *s = platform_get_drvdata(pdev);
- if (!s->poll)
- devm_free_irq(&pdev->dev, s->irq, s);
- else
+ if (s->poll)
del_timer_sync(&s->timer);
for (i = 0; i < s->uart.nr; i++)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2015-09-14 20:50 +0200 |
| Message-ID | <q8GZb-688-1@gated-at.bofh.it> |
| In reply to | #1224291 |
On Mon, 14 Sep 2015, Fabio Estevam wrote:
> On Sun, Sep 13, 2015 at 10:44 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
> > --- a/drivers/tty/serial/sccnxp.c
> > +++ b/drivers/tty/serial/sccnxp.c
> > @@ -963,11 +963,9 @@ static int sccnxp_probe(struct platform_device *pdev)
> > sccnxp_write(&s->port[0], SCCNXP_IMR_REG, 0);
> >
> > if (!s->poll) {
> > - ret = devm_request_threaded_irq(&pdev->dev, s->irq, NULL,
> > - sccnxp_ist,
> > - IRQF_TRIGGER_FALLING |
> > - IRQF_ONESHOT,
> > - dev_name(&pdev->dev), s);
> > + ret = request_threaded_irq(s->irq, NULL, sccnxp_ist,
> > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> > + dev_name(&pdev->dev), s);
> > if (!ret)
> > return 0;
> >
> > @@ -994,7 +992,7 @@ static int sccnxp_remove(struct platform_device *pdev)
> > struct sccnxp_port *s = platform_get_drvdata(pdev);
> >
> > if (!s->poll)
> > - devm_free_irq(&pdev->dev, s->irq, s);
> > + free_irq(s->irq, s);
>
> Couldn't we just remove the devm_free_irq() and keep using
> devm_request_threaded_irq()?
>
> Like this:
I assumed that if the person went to the trouble of putting it there, it
was because the interrupt handler needs some data that is freed later in
the remove function and interrupts have to be turned off at this point. I
can look into it more though, but the interactions are not always easy to
spot.
julia
>
> --- a/drivers/tty/serial/sccnxp.c
> +++ b/drivers/tty/serial/sccnxp.c
> @@ -993,9 +993,7 @@ static int sccnxp_remove(struct platform_device *pdev)
> int i;
> struct sccnxp_port *s = platform_get_drvdata(pdev);
>
> - if (!s->poll)
> - devm_free_irq(&pdev->dev, s->irq, s);
> - else
> + if (s->poll)
> del_timer_sync(&s->timer);
>
> for (i = 0; i < s->uart.nr; i++)
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web