Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1224395 > unrolled thread

Re: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request

Started byMark Brown <broonie@kernel.org>
First post2015-09-14 20:30 +0200
Last post2015-09-16 12:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read  request Mark Brown <broonie@kernel.org> - 2015-09-14 20:30 +0200
    Re: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read  request Vignesh R <vigneshr@ti.com> - 2015-09-16 12:10 +0200

#1224395 — Re: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request

FromMark Brown <broonie@kernel.org>
Date2015-09-14 20:30 +0200
SubjectRe: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request
Message-ID<q8GFQ-5Kz-17@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Fri, Sep 04, 2015 at 02:00:00PM +0530, Vignesh R wrote:

> +	if (spi->master->spi_mtd_mmap_read) {
> +		return  spi->master->spi_mtd_mmap_read(spi, from, len,
> +						       retlen, buf,
> +						       nor->read_opcode,
> +						       nor->addr_width,
> +						       dummy);
> +	}

We should be calling some API provided by the SPI core here, not peering
directly into the ops struture.

[toc] | [next] | [standalone]


#1225917

FromVignesh R <vigneshr@ti.com>
Date2015-09-16 12:10 +0200
Message-ID<q9hP5-1id-43@gated-at.bofh.it>
In reply to#1224395

On 09/14/2015 11:57 PM, Mark Brown wrote:
> On Fri, Sep 04, 2015 at 02:00:00PM +0530, Vignesh R wrote:
> 
>> +	if (spi->master->spi_mtd_mmap_read) {
>> +		return  spi->master->spi_mtd_mmap_read(spi, from, len,
>> +						       retlen, buf,
>> +						       nor->read_opcode,
>> +						       nor->addr_width,
>> +						       dummy);
>> +	}
> 
> We should be calling some API provided by the SPI core here, not peering
> directly into the ops struture.
> 

Ok..
-- 
Regards
Vignesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web