Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1222857 > unrolled thread
| Started by | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| First post | 2015-09-11 15:50 +0200 |
| Last post | 2015-09-11 17:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: hdsp: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-11 15:50 +0200
Re: [PATCH] ALSA: hdsp: fix memory leak Takashi Iwai <tiwai@suse.de> - 2015-09-11 17:40 +0200
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2015-09-11 15:50 +0200 |
| Subject | [PATCH] ALSA: hdsp: fix memory leak |
| Message-ID | <q7wSe-3el-21@gated-at.bofh.it> |
If the size of the firmware is less than expected size then we are exiting with the error code but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- sound/pci/rme9652/hdsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 9bba275..2875b4f 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -5112,6 +5112,7 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp) dev_err(hdsp->card->dev, "too short firmware size %d (expected %d)\n", (int)fw->size, HDSP_FIRMWARE_SIZE); + release_firmware(fw); return -EINVAL; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2015-09-11 17:40 +0200 |
| Message-ID | <q7yAF-5N1-5@gated-at.bofh.it> |
| In reply to | #1222857 |
On Fri, 11 Sep 2015 15:40:38 +0200, Sudip Mukherjee wrote: > > If the size of the firmware is less than expected size then we are > exiting with the error code but we missed releasing the firmware. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Applied, thanks. Takashi > --- > sound/pci/rme9652/hdsp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c > index 9bba275..2875b4f 100644 > --- a/sound/pci/rme9652/hdsp.c > +++ b/sound/pci/rme9652/hdsp.c > @@ -5112,6 +5112,7 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp) > dev_err(hdsp->card->dev, > "too short firmware size %d (expected %d)\n", > (int)fw->size, HDSP_FIRMWARE_SIZE); > + release_firmware(fw); > return -EINVAL; > } > > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web