Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1222634 > unrolled thread
| Started by | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| First post | 2015-09-11 11:00 +0200 |
| Last post | 2015-09-14 05:10 +0200 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-11 11:00 +0200
Re: [PATCH 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan Shawn Lin <shawn.lin@rock-chips.com> - 2015-09-14 05:10 +0200
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2015-09-11 11:00 +0200 |
| Subject | [PATCH 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan |
| Message-ID | <q7slA-54q-19@gated-at.bofh.it> |
This patch adds phys and phy-names for sdhci-of-arasan as optional
properties, and details the example as well.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
index da541c3..0264d5f 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
@@ -1,11 +1,12 @@
Device Tree Bindings for the Arasan SDHCI Controller
- The bindings follow the mmc[1], clock[2] and interrupt[3] bindings. Only
- deviations are documented here.
+ The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] bindings.
+ Only deviations are documented here.
[1] Documentation/devicetree/bindings/mmc/mmc.txt
[2] Documentation/devicetree/bindings/clock/clock-bindings.txt
[3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
+ [4] Documentation/devicetree/bindings/phy/phy-bindings.txt
Required Properties:
- compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
@@ -16,6 +17,9 @@ Required Properties:
- interrupts: Interrupt specifier
- interrupt-parent: Phandle for the interrupt controller that services
interrupts for this device.
+Optional Properties:
+ - phys: From PHY bindings: Phandle for the Generic PHY for arasan.
+ - phy-names: MUST be "phy_arasan".
Example:
sdhci@e0100000 {
@@ -25,4 +29,6 @@ Example:
clocks = <&clkc 21>, <&clkc 32>;
interrupt-parent = <&gic>;
interrupts = <0 24 4>;
+ phys = <&emmc_phy>;
+ phy-names = "phy_arasan";
} ;
--
2.3.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2015-09-14 05:10 +0200 |
| Subject | Re: [PATCH 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan |
| Message-ID | <q8sjv-24u-11@gated-at.bofh.it> |
| In reply to | #1222634 |
在 2015/9/14 10:47, Sören Brinkmann 写道: > Hi Shawn, > > On Fri, 2015-09-11 at 04:55PM +0800, Shawn Lin wrote: >> This patch adds phys and phy-names for sdhci-of-arasan as optional >> properties, and details the example as well. >> >> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> >> --- >> >> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> index da541c3..0264d5f 100644 >> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> @@ -1,11 +1,12 @@ >> Device Tree Bindings for the Arasan SDHCI Controller >> >> - The bindings follow the mmc[1], clock[2] and interrupt[3] bindings. Only >> - deviations are documented here. >> + The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] bindings. >> + Only deviations are documented here. >> >> [1] Documentation/devicetree/bindings/mmc/mmc.txt >> [2] Documentation/devicetree/bindings/clock/clock-bindings.txt >> [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt >> + [4] Documentation/devicetree/bindings/phy/phy-bindings.txt >> >> Required Properties: >> - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or >> @@ -16,6 +17,9 @@ Required Properties: >> - interrupts: Interrupt specifier >> - interrupt-parent: Phandle for the interrupt controller that services >> interrupts for this device. >> +Optional Properties: >> + - phys: From PHY bindings: Phandle for the Generic PHY for arasan. >> + - phy-names: MUST be "phy_arasan". > > This might be a dumb question, but, is the external phy actually > optional? Or is it mandatory for certain implementations of the IP. > In the latter case, it should probably be a mandatory property depending > on the compatible string matching an implementation that requires an > external phy (accordingly, the implementation might have to treat it From my soc team's reponse, there is no way to bypass controller to IO if no phy supported. So it should be the latter case you mentioned for arasan.sdhci-5.1. Thanks for point out it, really helpful. I will fix it in v2. > that way too). > > Sören > > > -- Best Regards Shawn Lin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web