Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221778 > unrolled thread

Re: [PATCH v3 2/4] clk: qcom: Add support for RCGs with shared branches

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 2/4] clk: qcom: Add support for RCGs with shared  branches Stephen Boyd <sboyd@codeaurora.org> - 2015-09-10 00:50 +0200
    Re: [PATCH v3 2/4] clk: qcom: Add support for RCGs with shared  branches Georgi Djakov <georgi.djakov@linaro.org> - 2015-09-10 18:40 +0200

#1221778 — Re: [PATCH v3 2/4] clk: qcom: Add support for RCGs with shared branches

On 08/13, Georgi Djakov wrote:
> diff --git a/drivers/clk/qcom/clk-rcg.h b/drivers/clk/qcom/clk-rcg.h
> index 56028bb31d87..0693b9e0b15e 100644
> --- a/drivers/clk/qcom/clk-rcg.h
> +++ b/drivers/clk/qcom/clk-rcg.h
> @@ -153,8 +153,8 @@ extern const struct clk_ops clk_dyn_rcg_ops;
>   * @hid_width: number of bits in half integer divider
>   * @parent_map: map from software's parent index to hardware's src_sel field
>   * @freq_tbl: frequency table
> + * @current_freq: last cached frequency when using branches with shared RCGs
>   * @clkr: regmap clock handle
> - * @lock: register lock

Thanks.

>   *
>   */
>  struct clk_rcg2 {
> diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
> index 9aec1761fd29..681faf2dcdc5 100644
> --- a/drivers/clk/qcom/clk-rcg2.c
> +++ b/drivers/clk/qcom/clk-rcg2.c
> +
> +static int clk_rcg2_shared_enable(struct clk_hw *hw)
> +{
> +	struct clk_rcg2 *rcg = to_clk_rcg2(hw);
> +	const char *name = clk_hw_get_name(hw);
> +
> +	if (!rcg->current_freq) {
> +		pr_err("%s: Please set rate before enabling\n", name);

Why? Can't we find the current freq during recalc_rate?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1222294

On 09/10/2015 01:46 AM, Stephen Boyd wrote:
> On 08/13, Georgi Djakov wrote:
[..]
>> diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
>> index 9aec1761fd29..681faf2dcdc5 100644
>> --- a/drivers/clk/qcom/clk-rcg2.c
>> +++ b/drivers/clk/qcom/clk-rcg2.c
>> +
>> +static int clk_rcg2_shared_enable(struct clk_hw *hw)
>> +{
>> +	struct clk_rcg2 *rcg = to_clk_rcg2(hw);
>> +	const char *name = clk_hw_get_name(hw);
>> +
>> +	if (!rcg->current_freq) {
>> +		pr_err("%s: Please set rate before enabling\n", name);
> 
> Why? Can't we find the current freq during recalc_rate?
> 

Yes, thank you!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web