Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1222253 > unrolled thread
| Started by | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| First post | 2015-09-10 17:10 +0200 |
| Last post | 2015-09-19 00:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-09-10 17:10 +0200
Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-10 17:30 +0200
Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-09-18 15:50 +0200
Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-19 00:10 +0200
| From | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| Date | 2015-09-10 17:10 +0200 |
| Subject | [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name |
| Message-ID | <q7bE6-54z-5@gated-at.bofh.it> |
From: Josh Wu <josh.wu@atmel.com>
Correct the led labels in at91sam9n12ek.
Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
index efa75064d38a..186a1705f8d3 100644
--- a/arch/arm/boot/dts/at91sam9n12ek.dts
+++ b/arch/arm/boot/dts/at91sam9n12ek.dts
@@ -204,13 +204,13 @@
};
d9 {
- label = "d6";
+ label = "d9";
gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
linux,default-trigger = "nand-disk";
};
d10 {
- label = "d7";
+ label = "d10";
gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
--
2.1.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2015-09-10 17:30 +0200 |
| Message-ID | <q7bXs-5rc-15@gated-at.bofh.it> |
| In reply to | #1222253 |
Hi,
On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
> From: Josh Wu <josh.wu@atmel.com>
>
> Correct the led labels in at91sam9n12ek.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
> index efa75064d38a..186a1705f8d3 100644
> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
> @@ -204,13 +204,13 @@
> };
>
> d9 {
> - label = "d6";
> + label = "d9";
> gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "nand-disk";
> };
>
> d10 {
> - label = "d7";
> + label = "d10";
> gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
The only concern being that this renaming will break userspace software
assuming the LEDs are wrongly named. Is there anything that has been
released by atmel that uses the wrong names (and my guess is yess and
that is why there are named as such) and do you care about it?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| Date | 2015-09-18 15:50 +0200 |
| Message-ID | <qa4d4-4d9-17@gated-at.bofh.it> |
| In reply to | #1222261 |
Le 10/09/2015 17:24, Alexandre Belloni a écrit :
> Hi,
>
> On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
>> From: Josh Wu <josh.wu@atmel.com>
>>
>> Correct the led labels in at91sam9n12ek.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>> ---
>> arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
>> index efa75064d38a..186a1705f8d3 100644
>> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
>> @@ -204,13 +204,13 @@
>> };
>>
>> d9 {
>> - label = "d6";
>> + label = "d9";
>> gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "nand-disk";
>> };
>>
>> d10 {
>> - label = "d7";
>> + label = "d10";
>> gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
>> linux,default-trigger = "heartbeat";
>> };
>
> The only concern being that this renaming will break userspace software
> assuming the LEDs are wrongly named. Is there anything that has been
> released by atmel that uses the wrong names (and my guess is yess and
> that is why there are named as such) and do you care about it?
My guess is that the label was wrongly named from the beginning and no
board revision had the "d6" nor "d7" names.
It makes sense to rename them for the evaluation kit...
Bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2015-09-19 00:10 +0200 |
| Message-ID | <qac0W-7kT-19@gated-at.bofh.it> |
| In reply to | #1227877 |
Hi, On 18/09/2015 at 15:46:33 +0200, Nicolas Ferre wrote : > > The only concern being that this renaming will break userspace software > > assuming the LEDs are wrongly named. Is there anything that has been > > released by atmel that uses the wrong names (and my guess is yess and > > that is why there are named as such) and do you care about it? > > My guess is that the label was wrongly named from the beginning and no > board revision had the "d6" nor "d7" names. > It makes sense to rename them for the evaluation kit... > Yeah, I'm fine with the change. I was simply warning that it may break some demos Atmel distributed before (but I didn't ever seen or used those anyway so I may be wrong). -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web