Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223012 > unrolled thread

Re: [PATCH] firmware: qcom: scm: Add function stubs for ARM64

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] firmware: qcom: scm: Add function stubs for ARM64 Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-11 20:00 +0200
    Re: [PATCH] firmware: qcom: scm: Add function stubs for ARM64 Andy Gross <agross@codeaurora.org> - 2015-09-11 21:30 +0200

#1223012 — Re: [PATCH] firmware: qcom: scm: Add function stubs for ARM64

On Fri, Sep 11, 2015 at 12:50:56PM -0500, Andy Gross wrote:
> This patch adds stubs for the SCM functions exposed in the QCOM SCM API.
> 
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
>  drivers/firmware/Makefile      |    4 +++
>  drivers/firmware/qcom_scm-64.c |   63 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 drivers/firmware/qcom_scm-64.c
> 
> diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
> index 4a4b897..2f810c2 100644
> --- a/drivers/firmware/Makefile
> +++ b/drivers/firmware/Makefile
> @@ -12,8 +12,12 @@ obj-$(CONFIG_ISCSI_IBFT_FIND)	+= iscsi_ibft_find.o
>  obj-$(CONFIG_ISCSI_IBFT)	+= iscsi_ibft.o
>  obj-$(CONFIG_FIRMWARE_MEMMAP)	+= memmap.o
>  obj-$(CONFIG_QCOM_SCM)		+= qcom_scm.o
> +ifdef CONFIG_ARM64
> +obj-$(CONFIG_QCOM_SCM)		+= qcom_scm-64.o
> +else
>  obj-$(CONFIG_QCOM_SCM)		+= qcom_scm-32.o
>  CFLAGS_qcom_scm-32.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1)
> +endif

Can we not start doing stuff like this.  Use the Kconfig to control what
you build, not the Makefile system.

config QCOM_SCM_32
	def_bool y
	depends on QCOM_SCM && ARM

config QCOM_SCM_64
	def_bool y
	depends on QCOM_SCM && ARM64

and then use those in the makefile.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1223059

On Fri, Sep 11, 2015 at 06:56:49PM +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 11, 2015 at 12:50:56PM -0500, Andy Gross wrote:
> > This patch adds stubs for the SCM functions exposed in the QCOM SCM API.
> > 
> > Signed-off-by: Andy Gross <agross@codeaurora.org>
> > ---
> >  drivers/firmware/Makefile      |    4 +++
> >  drivers/firmware/qcom_scm-64.c |   63 ++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 67 insertions(+)
> >  create mode 100644 drivers/firmware/qcom_scm-64.c
> > 
> > diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
> > index 4a4b897..2f810c2 100644
> > --- a/drivers/firmware/Makefile
> > +++ b/drivers/firmware/Makefile
> > @@ -12,8 +12,12 @@ obj-$(CONFIG_ISCSI_IBFT_FIND)	+= iscsi_ibft_find.o
> >  obj-$(CONFIG_ISCSI_IBFT)	+= iscsi_ibft.o
> >  obj-$(CONFIG_FIRMWARE_MEMMAP)	+= memmap.o
> >  obj-$(CONFIG_QCOM_SCM)		+= qcom_scm.o
> > +ifdef CONFIG_ARM64
> > +obj-$(CONFIG_QCOM_SCM)		+= qcom_scm-64.o
> > +else
> >  obj-$(CONFIG_QCOM_SCM)		+= qcom_scm-32.o
> >  CFLAGS_qcom_scm-32.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1)
> > +endif
> 
> Can we not start doing stuff like this.  Use the Kconfig to control what
> you build, not the Makefile system.
> 
> config QCOM_SCM_32
> 	def_bool y
> 	depends on QCOM_SCM && ARM
> 
> config QCOM_SCM_64
> 	def_bool y
> 	depends on QCOM_SCM && ARM64
> 
> and then use those in the makefile.

That's a fair implementation.  There is going to be a bit of work
going into getting the 64 bit SCM un-stubbed.  So I can respin to incorporate
your comments or we can wait for the unstubbing.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web