Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1221545 > unrolled thread
| Started by | Christoph Hellwig <hch@lst.de> |
|---|---|
| First post | 2015-09-09 18:10 +0200 |
| Last post | 2015-09-11 21:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c Christoph Hellwig <hch@lst.de> - 2015-09-09 18:10 +0200
Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c Mike Snitzer <snitzer@redhat.com> - 2015-09-11 20:30 +0200
Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c James Bottomley <jbottomley@odin.com> - 2015-09-11 21:00 +0200
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2015-09-09 18:10 +0200 |
| Subject | Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c |
| Message-ID | <q6Q6D-7ZD-27@gated-at.bofh.it> |
Does this fix the issue for you? My Kconfig-fu isn't the best, but the idea behind this is that dm-mpath will depend on SCSI if SCSI_DH is set. If SCSI_DH is not set it will use the stubs and not care about SCSI. diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig index b597273..e9ea681 100644 --- a/drivers/md/Kconfig +++ b/drivers/md/Kconfig @@ -393,7 +393,7 @@ config DM_MULTIPATH # of SCSI_DH if the latter isn't defined but if # it is, DM_MULTIPATH must depend on it. We get a build # error if SCSI_DH=m and DM_MULTIPATH=y - depends on SCSI_DH || !SCSI_DH + depends on !SCSI_DH || SCSI ---help--- Allow volume managers to support multipath hardware. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Mike Snitzer <snitzer@redhat.com> |
|---|---|
| Date | 2015-09-11 20:30 +0200 |
| Message-ID | <q7Bfb-1g5-9@gated-at.bofh.it> |
| In reply to | #1221545 |
On Wed, Sep 09 2015 at 12:04pm -0400, Christoph Hellwig <hch@lst.de> wrote: > Does this fix the issue for you? My Kconfig-fu isn't the best, > but the idea behind this is that dm-mpath will depend on SCSI > if SCSI_DH is set. If SCSI_DH is not set it will use the stubs > and not care about SCSI. > > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > index b597273..e9ea681 100644 > --- a/drivers/md/Kconfig > +++ b/drivers/md/Kconfig > @@ -393,7 +393,7 @@ config DM_MULTIPATH > # of SCSI_DH if the latter isn't defined but if > # it is, DM_MULTIPATH must depend on it. We get a build > # error if SCSI_DH=m and DM_MULTIPATH=y > - depends on SCSI_DH || !SCSI_DH > + depends on !SCSI_DH || SCSI > ---help--- > Allow volume managers to support multipath hardware. > I verified (with next-20150911) that without your patch I saw the reported problem using the provided randconfig (that had CONFIG_SCSI_DH=y and CONFIG_DM_MULTIPATH=y): drivers/built-in.o: In function `activate_path': /root/snitm/git/linux/drivers/md/dm-mpath.c:1225: undefined reference to `scsi_dh_activate' drivers/built-in.o: In function `parse_path': /root/snitm/git/linux/drivers/md/dm-mpath.c:581: undefined reference to `scsi_dh_attached_handler_name' /root/snitm/git/linux/drivers/md/dm-mpath.c:600: undefined reference to `scsi_dh_attach' /root/snitm/git/linux/drivers/md/dm-mpath.c:615: undefined reference to `scsi_dh_set_params' make: *** [vmlinux] Error 1 But with your patch the build completes successfully. James, please feel free to pull in Christoph's patch and add my: Tested-by: Mike Snitzer <snitzer@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | James Bottomley <jbottomley@odin.com> |
|---|---|
| Date | 2015-09-11 21:00 +0200 |
| Message-ID | <q7BIe-1Oi-9@gated-at.bofh.it> |
| In reply to | #1221545 |
T24gV2VkLCAyMDE1LTA5LTA5IGF0IDE4OjA0ICswMjAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90 ZToNCj4gRG9lcyB0aGlzIGZpeCB0aGUgaXNzdWUgZm9yIHlvdT8gIE15IEtjb25maWctZnUgaXNu J3QgdGhlIGJlc3QsDQo+IGJ1dCB0aGUgaWRlYSBiZWhpbmQgdGhpcyBpcyB0aGF0IGRtLW1wYXRo IHdpbGwgZGVwZW5kIG9uIFNDU0kNCj4gaWYgU0NTSV9ESCBpcyBzZXQuICBJZiBTQ1NJX0RIIGlz IG5vdCBzZXQgaXQgd2lsbCB1c2UgdGhlIHN0dWJzDQo+IGFuZCBub3QgY2FyZSBhYm91dCBTQ1NJ Lg0KDQpJIGFzc3VtZSBJJ20gT0sgdG8gYWRkDQoNClNpZ25lZC1vZmYtYnk6IENocmlzdG9waCBI ZWxsd2lnIDxoY2hAbHN0LmRlPg0KDQooSSdsbCBhc3N1bWUgc28gaWYgeW91IGRvbid0IHJlcGx5 KQ0KDQpKYW1lcw0KDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21kL0tjb25maWcgYi9kcml2ZXJz L21kL0tjb25maWcNCj4gaW5kZXggYjU5NzI3My4uZTllYTY4MSAxMDA2NDQNCj4gLS0tIGEvZHJp dmVycy9tZC9LY29uZmlnDQo+ICsrKyBiL2RyaXZlcnMvbWQvS2NvbmZpZw0KPiBAQCAtMzkzLDcg KzM5Myw3IEBAIGNvbmZpZyBETV9NVUxUSVBBVEgNCj4gIAkjIG9mIFNDU0lfREggaWYgdGhlIGxh dHRlciBpc24ndCBkZWZpbmVkIGJ1dCBpZg0KPiAgCSMgaXQgaXMsIERNX01VTFRJUEFUSCBtdXN0 IGRlcGVuZCBvbiBpdC4gIFdlIGdldCBhIGJ1aWxkDQo+ICAJIyBlcnJvciBpZiBTQ1NJX0RIPW0g YW5kIERNX01VTFRJUEFUSD15DQo+IC0JZGVwZW5kcyBvbiBTQ1NJX0RIIHx8ICFTQ1NJX0RIDQo+ ICsJZGVwZW5kcyBvbiAhU0NTSV9ESCB8fCBTQ1NJDQo+ICAJLS0taGVscC0tLQ0KPiAgCSAgQWxs b3cgdm9sdW1lIG1hbmFnZXJzIHRvIHN1cHBvcnQgbXVsdGlwYXRoIGhhcmR3YXJlLg0KPiAgDQoN Cg0KDQo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web