Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221774 > unrolled thread

[PATCH 1/1] mm: kmemleak: remove unneeded initialization of object to NULL

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/1] mm: kmemleak: remove unneeded initialization of object to NULL Alexey Klimov <alexey.klimov@linaro.org> - 2015-09-10 00:40 +0200
    Re: [PATCH 1/1] mm: kmemleak: remove unneeded initialization of  object to NULL Catalin Marinas <catalin.marinas@arm.com> - 2015-09-10 11:20 +0200

#1221774 — [PATCH 1/1] mm: kmemleak: remove unneeded initialization of object to NULL

Few lines below object is reinitialized by lookup_object()
so we don't need to init it by NULL in the beginning of
find_and_get_object().

Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
---
 mm/kmemleak.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index f532f6a..444a771 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -488,7 +488,7 @@ static void put_object(struct kmemleak_object *object)
 static struct kmemleak_object *find_and_get_object(unsigned long ptr, int alias)
 {
 	unsigned long flags;
-	struct kmemleak_object *object = NULL;
+	struct kmemleak_object *object;
 
 	rcu_read_lock();
 	read_lock_irqsave(&kmemleak_lock, flags);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1222055 — Re: [PATCH 1/1] mm: kmemleak: remove unneeded initialization of object to NULL

On Thu, Sep 10, 2015 at 01:33:49AM +0300, Alexey Klimov wrote:
> Few lines below object is reinitialized by lookup_object()
> so we don't need to init it by NULL in the beginning of
> find_and_get_object().
> 
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web