Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1220462 > unrolled thread
| Started by | Zhang Zhen <zhenzhang.zhang@huawei.com> |
|---|---|
| First post | 2015-09-08 04:50 +0200 |
| Last post | 2015-09-09 20:30 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case Zhang Zhen <zhenzhang.zhang@huawei.com> - 2015-09-08 04:50 +0200
Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case Sergey Dyasly <dserrg@gmail.com> - 2015-09-08 20:20 +0200
Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case Zhang Zhen <zhenzhang.zhang@huawei.com> - 2015-09-09 03:40 +0200
Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case Nicolas Pitre <nicolas.pitre@linaro.org> - 2015-09-09 05:20 +0200
Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case Sergey Dyasly <dserrg@gmail.com> - 2015-09-09 20:30 +0200
| From | Zhang Zhen <zhenzhang.zhang@huawei.com> |
|---|---|
| Date | 2015-09-08 04:50 +0200 |
| Subject | [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case |
| Message-ID | <q6h8S-7Zt-9@gated-at.bofh.it> |
The arch-specific IOREMAP_MAX_ORDER is introduced in commit: ff0daca([ARM] Add section support to ioremap) and commit: a069c89 ([ARM] 3705/1: add supersection support to ioremap()). But supersections and sections mappings are only used in !SMP && !LPAE case. Otherwise, mapping is created using the usual 4K pages. In most cases without !SMP && !LPAE, the big alignment cause high fragmentation issue in vmalloc area. Here we use arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case, otherwise use generic IOREMAP_MAX_ORDER in include/linux/vmalloc.h. Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> --- arch/arm/include/asm/memory.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h index b7f6fb4..3209012 100644 --- a/arch/arm/include/asm/memory.h +++ b/arch/arm/include/asm/memory.h @@ -76,10 +76,12 @@ */ #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & 0x000fffff)) +#if !defined(CONFIG_SMP) && !defined(CONFIG_ARM_LPAE) /* * Allow 16MB-aligned ioremap pages */ #define IOREMAP_MAX_ORDER 24 +#endif #else /* CONFIG_MMU */ -- 1.9.1 . -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Sergey Dyasly <dserrg@gmail.com> |
|---|---|
| Date | 2015-09-08 20:20 +0200 |
| Subject | Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case |
| Message-ID | <q6vER-3Dl-5@gated-at.bofh.it> |
| In reply to | #1220462 |
On 08.09.2015 5:45, Zhang Zhen wrote: > The arch-specific IOREMAP_MAX_ORDER is introduced in > commit: ff0daca([ARM] Add section support to ioremap) and > commit: a069c89 ([ARM] 3705/1: add supersection support to ioremap()). > But supersections and sections mappings are only used in !SMP && !LPAE case. > Otherwise, mapping is created using the usual 4K pages. > > In most cases without !SMP && !LPAE, the big alignment cause high fragmentation > issue in vmalloc area. > Here we use arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case, > otherwise use generic IOREMAP_MAX_ORDER in include/linux/vmalloc.h. > > Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> > --- > arch/arm/include/asm/memory.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > index b7f6fb4..3209012 100644 > --- a/arch/arm/include/asm/memory.h > +++ b/arch/arm/include/asm/memory.h > @@ -76,10 +76,12 @@ > */ > #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & 0x000fffff)) > > +#if !defined(CONFIG_SMP) && !defined(CONFIG_ARM_LPAE) > /* > * Allow 16MB-aligned ioremap pages > */ > #define IOREMAP_MAX_ORDER 24 > +#endif > > #else /* CONFIG_MMU */ > Hmm... This looks exactly like my old patch - http://thread.gmane.org/gmane.linux.kernel.mm/127620 (Thanks to Vladimir for pointing that out!) Hasn't there been any progress about this issue? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Zhang Zhen <zhenzhang.zhang@huawei.com> |
|---|---|
| Date | 2015-09-09 03:40 +0200 |
| Subject | Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case |
| Message-ID | <q6CwG-51h-5@gated-at.bofh.it> |
| In reply to | #1221027 |
On 2015/9/9 2:12, Sergey Dyasly wrote: > On 08.09.2015 5:45, Zhang Zhen wrote: >> The arch-specific IOREMAP_MAX_ORDER is introduced in >> commit: ff0daca([ARM] Add section support to ioremap) and >> commit: a069c89 ([ARM] 3705/1: add supersection support to ioremap()). >> But supersections and sections mappings are only used in !SMP && !LPAE case. >> Otherwise, mapping is created using the usual 4K pages. >> >> In most cases without !SMP && !LPAE, the big alignment cause high fragmentation >> issue in vmalloc area. >> Here we use arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case, >> otherwise use generic IOREMAP_MAX_ORDER in include/linux/vmalloc.h. >> >> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> >> --- >> arch/arm/include/asm/memory.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h >> index b7f6fb4..3209012 100644 >> --- a/arch/arm/include/asm/memory.h >> +++ b/arch/arm/include/asm/memory.h >> @@ -76,10 +76,12 @@ >> */ >> #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & 0x000fffff)) >> >> +#if !defined(CONFIG_SMP) && !defined(CONFIG_ARM_LPAE) >> /* >> * Allow 16MB-aligned ioremap pages >> */ >> #define IOREMAP_MAX_ORDER 24 >> +#endif >> >> #else /* CONFIG_MMU */ >> > > Hmm... This looks exactly like my old patch - > http://thread.gmane.org/gmane.linux.kernel.mm/127620 > (Thanks to Vladimir for pointing that out!) > > Hasn't there been any progress about this issue? > Oh sorry i didn't notice your old patch. I send this patch because we encountered high fragmentation issue in vmalloc area and the link about this issue. http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/313040.html Let's drop my patch. Besides, i just want to know why this patch is not included into the upstream kernel? Thanks! > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Pitre <nicolas.pitre@linaro.org> |
|---|---|
| Date | 2015-09-09 05:20 +0200 |
| Subject | Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case |
| Message-ID | <q6E5r-7qJ-1@gated-at.bofh.it> |
| In reply to | #1221027 |
On Tue, 8 Sep 2015, Sergey Dyasly wrote: > On 08.09.2015 5:45, Zhang Zhen wrote: > > The arch-specific IOREMAP_MAX_ORDER is introduced in > > commit: ff0daca([ARM] Add section support to ioremap) and > > commit: a069c89 ([ARM] 3705/1: add supersection support to ioremap()). > > But supersections and sections mappings are only used in !SMP && !LPAE case. > > Otherwise, mapping is created using the usual 4K pages. > > > > In most cases without !SMP && !LPAE, the big alignment cause high > > fragmentation > > issue in vmalloc area. > > Here we use arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case, > > otherwise use generic IOREMAP_MAX_ORDER in include/linux/vmalloc.h. > > > > Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> > > --- > > arch/arm/include/asm/memory.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > > index b7f6fb4..3209012 100644 > > --- a/arch/arm/include/asm/memory.h > > +++ b/arch/arm/include/asm/memory.h > > @@ -76,10 +76,12 @@ > > */ > > #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & > > 0x000fffff)) > > > > +#if !defined(CONFIG_SMP) && !defined(CONFIG_ARM_LPAE) > > /* > > * Allow 16MB-aligned ioremap pages > > */ > > #define IOREMAP_MAX_ORDER 24 > > +#endif > > > > #else /* CONFIG_MMU */ > > > > Hmm... This looks exactly like my old patch - > http://thread.gmane.org/gmane.linux.kernel.mm/127620 > (Thanks to Vladimir for pointing that out!) > > Hasn't there been any progress about this issue? IMHO the patch makes sense. Did you send it to RMK's patch system? Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sergey Dyasly <dserrg@gmail.com> |
|---|---|
| Date | 2015-09-09 20:30 +0200 |
| Subject | Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case |
| Message-ID | <q6Si6-2Bs-5@gated-at.bofh.it> |
| In reply to | #1221205 |
On 09.09.2015 6:10, Nicolas Pitre wrote: > On Tue, 8 Sep 2015, Sergey Dyasly wrote: > >> On 08.09.2015 5:45, Zhang Zhen wrote: >>> The arch-specific IOREMAP_MAX_ORDER is introduced in >>> commit: ff0daca([ARM] Add section support to ioremap) and >>> commit: a069c89 ([ARM] 3705/1: add supersection support to ioremap()). >>> But supersections and sections mappings are only used in !SMP && !LPAE case. >>> Otherwise, mapping is created using the usual 4K pages. >>> >>> In most cases without !SMP && !LPAE, the big alignment cause high >>> fragmentation >>> issue in vmalloc area. >>> Here we use arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case, >>> otherwise use generic IOREMAP_MAX_ORDER in include/linux/vmalloc.h. >>> >>> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> >>> --- >>> arch/arm/include/asm/memory.h | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h >>> index b7f6fb4..3209012 100644 >>> --- a/arch/arm/include/asm/memory.h >>> +++ b/arch/arm/include/asm/memory.h >>> @@ -76,10 +76,12 @@ >>> */ >>> #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & >>> 0x000fffff)) >>> >>> +#if !defined(CONFIG_SMP) && !defined(CONFIG_ARM_LPAE) >>> /* >>> * Allow 16MB-aligned ioremap pages >>> */ >>> #define IOREMAP_MAX_ORDER 24 >>> +#endif >>> >>> #else /* CONFIG_MMU */ >>> >> Hmm... This looks exactly like my old patch - >> http://thread.gmane.org/gmane.linux.kernel.mm/127620 >> (Thanks to Vladimir for pointing that out!) >> >> Hasn't there been any progress about this issue? > IMHO the patch makes sense. > > Did you send it to RMK's patch system? Ok, submitted it to the patch system. Thanks! > > > Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web