Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1216041 > unrolled thread

[PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc

Started byHemant Kumar <hemant@linux.vnet.ibm.com>
First post2015-08-31 08:50 +0200
Last post2015-09-08 17:20 +0200
Articles 9 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc Hemant Kumar <hemant@linux.vnet.ibm.com> - 2015-08-31 08:50 +0200
    [PATCH v6 2/2] perf,kvm/powerpc: Add hcall related info to kvm_perf.h Hemant Kumar <hemant@linux.vnet.ibm.com> - 2015-08-31 08:50 +0200
    Re: [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-31 22:20 +0200
      Re: [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc Hemant Kumar <hemant@linux.vnet.ibm.com> - 2015-09-01 08:50 +0200
        Re: [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-04 23:00 +0200
          Re: [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc Michael Ellerman <mpe@ellerman.id.au> - 2015-09-07 07:20 +0200
            Re: [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc Hemant Kumar <hemant@linux.vnet.ibm.com> - 2015-09-08 07:00 +0200
              Re: [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc Michael Ellerman <mpe@ellerman.id.au> - 2015-09-08 10:40 +0200
                Re: [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-08 17:20 +0200

#1216041 — [PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc

FromHemant Kumar <hemant@linux.vnet.ibm.com>
Date2015-08-31 08:50 +0200
Subject[PATCH v6 1/2] perf,kvm/powerpc: Add kvm_perf.h for powerpc
Message-ID<q3r4K-8lH-13@gated-at.bofh.it>
To analyze the exit events with perf, we need to export the related
tracepoints through kvm_perf.h. kvm_perf.h is to be added in the
arch/powerpc directory, where the kvm tracepoints needed to trace the
KVM exit events are defined.

To indicate that the tracepoints are book3s_hv specific, suffix _HV has
been added to the tracepoint macros. Additionally, we also need to
define the generic macros (albeit, with null strings) suffix, because
the preprocessor looks for them in the generic code in builtin-kvm.c.

Signed-off-by: Hemant Kumar <hemant@linux.vnet.ibm.com>
---
Changes since v5:
- Moved back the tracepoint definitions from kvm_perf_book3s.h to kvm_perf.h

 arch/powerpc/include/uapi/asm/kvm_perf.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 arch/powerpc/include/uapi/asm/kvm_perf.h

diff --git a/arch/powerpc/include/uapi/asm/kvm_perf.h b/arch/powerpc/include/uapi/asm/kvm_perf.h
new file mode 100644
index 0000000..68f105e
--- /dev/null
+++ b/arch/powerpc/include/uapi/asm/kvm_perf.h
@@ -0,0 +1,21 @@
+#ifndef _ASM_POWERPC_KVM_PERF_H
+#define _ASM_POWERPC_KVM_PERF_H
+
+#include <asm/kvm.h>
+
+#define DECODE_STR_LEN 40
+
+#define VCPU_ID "vcpu_id"
+
+/* For Book3S_HV machines */
+#define KVM_ENTRY_TRACE_HV "kvm_hv:kvm_guest_enter"
+#define KVM_EXIT_TRACE_HV "kvm_hv:kvm_guest_exit"
+#define KVM_EXIT_REASON_HV "trap"
+
+/* This is to shut the compiler up */
+#define KVM_ENTRY_TRACE ""
+#define KVM_EXIT_TRACE ""
+#define KVM_EXIT_REASON ""
+
+
+#endif /* _ASM_POWERPC_KVM_PERF_H */
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1216042 — [PATCH v6 2/2] perf,kvm/powerpc: Add hcall related info to kvm_perf.h

FromHemant Kumar <hemant@linux.vnet.ibm.com>
Date2015-08-31 08:50 +0200
Subject[PATCH v6 2/2] perf,kvm/powerpc: Add hcall related info to kvm_perf.h
Message-ID<q3r4K-8lH-19@gated-at.bofh.it>
In reply to#1216041
To analyze the hcalls with perf kvm stat, we need the hcall related
tracepoint information to be exported.

This patch adds hcall tracepoints "kvm_hv:kvm_hcall_enter" and
"kvm_hv:kvm_hcall_exit" to kvm_perf.h. So, perf will now know to look
for these tracepoints if "perf kvm stat record" is invoked to collect
guest hcall statistics.

Signed-off-by: Hemant Kumar <hemant@linux.vnet.ibm.com>
---
 arch/powerpc/include/uapi/asm/kvm_perf.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/powerpc/include/uapi/asm/kvm_perf.h b/arch/powerpc/include/uapi/asm/kvm_perf.h
index 68f105e..2af6290 100644
--- a/arch/powerpc/include/uapi/asm/kvm_perf.h
+++ b/arch/powerpc/include/uapi/asm/kvm_perf.h
@@ -12,6 +12,10 @@
 #define KVM_EXIT_TRACE_HV "kvm_hv:kvm_guest_exit"
 #define KVM_EXIT_REASON_HV "trap"
 
+#define KVM_HCALL_ENTRY_TRACE_HV "kvm_hv:kvm_hcall_enter"
+#define KVM_HCALL_EXIT_TRACE_HV "kvm_hv:kvm_hcall_exit"
+#define KVM_HCALL_REASON_HV "req"
+
 /* This is to shut the compiler up */
 #define KVM_ENTRY_TRACE ""
 #define KVM_EXIT_TRACE ""
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1216422

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-08-31 22:20 +0200
Message-ID<q3DID-1oI-27@gated-at.bofh.it>
In reply to#1216041
Em Mon, Aug 31, 2015 at 12:18:00PM +0530, Hemant Kumar escreveu:
> To analyze the exit events with perf, we need to export the related
> tracepoints through kvm_perf.h. kvm_perf.h is to be added in the
> arch/powerpc directory, where the kvm tracepoints needed to trace the
> KVM exit events are defined.
> 
> To indicate that the tracepoints are book3s_hv specific, suffix _HV has
> been added to the tracepoint macros. Additionally, we also need to
> define the generic macros (albeit, with null strings) suffix, because
> the preprocessor looks for them in the generic code in builtin-kvm.c.
> 
> Signed-off-by: Hemant Kumar <hemant@linux.vnet.ibm.com>

humm, there are two patchkits, this one with two patches, the other with
3, this one for the kernel, the other one for tools/, but for the tools/
part to work, does this one needs to be applied first?

Should I try to process the 5 together, applying thest two first?

I see there are no acks from powerpc arch maintainers, how should we
proceed here? If there are no problems with the arch bits, and if it is
just to enable the tooling part, again, should I process the 5 as just
one series?

- Arnaldo

> ---
> Changes since v5:
> - Moved back the tracepoint definitions from kvm_perf_book3s.h to kvm_perf.h
> 
>  arch/powerpc/include/uapi/asm/kvm_perf.h | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 arch/powerpc/include/uapi/asm/kvm_perf.h
> 
> diff --git a/arch/powerpc/include/uapi/asm/kvm_perf.h b/arch/powerpc/include/uapi/asm/kvm_perf.h
> new file mode 100644
> index 0000000..68f105e
> --- /dev/null
> +++ b/arch/powerpc/include/uapi/asm/kvm_perf.h
> @@ -0,0 +1,21 @@
> +#ifndef _ASM_POWERPC_KVM_PERF_H
> +#define _ASM_POWERPC_KVM_PERF_H
> +
> +#include <asm/kvm.h>
> +
> +#define DECODE_STR_LEN 40
> +
> +#define VCPU_ID "vcpu_id"
> +
> +/* For Book3S_HV machines */
> +#define KVM_ENTRY_TRACE_HV "kvm_hv:kvm_guest_enter"
> +#define KVM_EXIT_TRACE_HV "kvm_hv:kvm_guest_exit"
> +#define KVM_EXIT_REASON_HV "trap"
> +
> +/* This is to shut the compiler up */
> +#define KVM_ENTRY_TRACE ""
> +#define KVM_EXIT_TRACE ""
> +#define KVM_EXIT_REASON ""
> +
> +
> +#endif /* _ASM_POWERPC_KVM_PERF_H */
> -- 
> 1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1216629

FromHemant Kumar <hemant@linux.vnet.ibm.com>
Date2015-09-01 08:50 +0200
Message-ID<q3Nyi-7dR-15@gated-at.bofh.it>
In reply to#1216422
(cc'ing Michael Ellerman with this reply)

Hi Arnaldo,

On 09/01/2015 01:43 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Aug 31, 2015 at 12:18:00PM +0530, Hemant Kumar escreveu:
>> To analyze the exit events with perf, we need to export the related
>> tracepoints through kvm_perf.h. kvm_perf.h is to be added in the
>> arch/powerpc directory, where the kvm tracepoints needed to trace the
>> KVM exit events are defined.
>>
>> To indicate that the tracepoints are book3s_hv specific, suffix _HV has
>> been added to the tracepoint macros. Additionally, we also need to
>> define the generic macros (albeit, with null strings) suffix, because
>> the preprocessor looks for them in the generic code in builtin-kvm.c.
>>
>> Signed-off-by: Hemant Kumar <hemant@linux.vnet.ibm.com>
> humm, there are two patchkits, this one with two patches, the other with
> 3, this one for the kernel, the other one for tools/, but for the tools/
> part to work, does this one needs to be applied first?
>
> Should I try to process the 5 together, applying thest two first?

Yes, this patchset needs to be applied before applying the other patchset,
since there is a direct dependency on these two for the tooling part to
work.

> I see there are no acks from powerpc arch maintainers, how should we
> proceed here? If there are no problems with the arch bits, and if it is
> just to enable the tooling part, again, should I process the 5 as just
> one series?

The reason to split the earlier patchset into two was to separate the
tooling/perf/ and arch/powerpc/ side patches, as asked by Michael..

Here is the link to that discussion :
http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg86916.html

If Michael is ok with the patches, you can process all the 5 patches 
together. Michael?


> - Arnaldo
>
>> ---
>> Changes since v5:
>> - Moved back the tracepoint definitions from kvm_perf_book3s.h to kvm_perf.h
>>
>>   arch/powerpc/include/uapi/asm/kvm_perf.h | 21 +++++++++++++++++++++
>>   1 file changed, 21 insertions(+)
>>   create mode 100644 arch/powerpc/include/uapi/asm/kvm_perf.h
>>
>> diff --git a/arch/powerpc/include/uapi/asm/kvm_perf.h b/arch/powerpc/include/uapi/asm/kvm_perf.h
>> new file mode 100644
>> index 0000000..68f105e
>> --- /dev/null
>> +++ b/arch/powerpc/include/uapi/asm/kvm_perf.h
>> @@ -0,0 +1,21 @@
>> +#ifndef _ASM_POWERPC_KVM_PERF_H
>> +#define _ASM_POWERPC_KVM_PERF_H
>> +
>> +#include <asm/kvm.h>
>> +
>> +#define DECODE_STR_LEN 40
>> +
>> +#define VCPU_ID "vcpu_id"
>> +
>> +/* For Book3S_HV machines */
>> +#define KVM_ENTRY_TRACE_HV "kvm_hv:kvm_guest_enter"
>> +#define KVM_EXIT_TRACE_HV "kvm_hv:kvm_guest_exit"
>> +#define KVM_EXIT_REASON_HV "trap"
>> +
>> +/* This is to shut the compiler up */
>> +#define KVM_ENTRY_TRACE ""
>> +#define KVM_EXIT_TRACE ""
>> +#define KVM_EXIT_REASON ""
>> +
>> +
>> +#endif /* _ASM_POWERPC_KVM_PERF_H */
>> -- 
>> 1.9.3
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

-- 
Thanks,
Hemant Kumar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1219313

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-09-04 23:00 +0200
Message-ID<q56fw-4On-7@gated-at.bofh.it>
In reply to#1216629
Em Tue, Sep 01, 2015 at 12:18:47PM +0530, Hemant Kumar escreveu:
> >Should I try to process the 5 together, applying thest two first?
 
> Yes, this patchset needs to be applied before applying the other patchset,
> since there is a direct dependency on these two for the tooling part to
> work.
 
> >I see there are no acks from powerpc arch maintainers, how should we
> >proceed here? If there are no problems with the arch bits, and if it is
> >just to enable the tooling part, again, should I process the 5 as just
> >one series?
 
> The reason to split the earlier patchset into two was to separate the
> tooling/perf/ and arch/powerpc/ side patches, as asked by Michael..
 
> Here is the link to that discussion :
> http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg86916.html
 
> If Michael is ok with the patches, you can process all the 5 patches
> together. Michael?

Michael?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1219929

FromMichael Ellerman <mpe@ellerman.id.au>
Date2015-09-07 07:20 +0200
Message-ID<q5X0v-4nq-23@gated-at.bofh.it>
In reply to#1219313
On Fri, 2015-09-04 at 17:51 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Sep 01, 2015 at 12:18:47PM +0530, Hemant Kumar escreveu:
> > >Should I try to process the 5 together, applying thest two first?
>  
> > Yes, this patchset needs to be applied before applying the other patchset,
> > since there is a direct dependency on these two for the tooling part to
> > work.
>  
> > >I see there are no acks from powerpc arch maintainers, how should we
> > >proceed here? If there are no problems with the arch bits, and if it is
> > >just to enable the tooling part, again, should I process the 5 as just
> > >one series?
>  
> > The reason to split the earlier patchset into two was to separate the
> > tooling/perf/ and arch/powerpc/ side patches, as asked by Michael..
>  
> > Here is the link to that discussion :
> > http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg86916.html
>  
> > If Michael is ok with the patches, you can process all the 5 patches
> > together. Michael?
> 
> Michael?

I'm not particularly happy with it.

Can we at least remove this hunk from the uapi header:

+/* This is to shut the compiler up */
+#define KVM_ENTRY_TRACE ""
+#define KVM_EXIT_TRACE ""
+#define KVM_EXIT_REASON ""


cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1220476

FromHemant Kumar <hemant@linux.vnet.ibm.com>
Date2015-09-08 07:00 +0200
Message-ID<q6jaG-2po-5@gated-at.bofh.it>
In reply to#1219929

On 09/07/2015 10:40 AM, Michael Ellerman wrote:
> On Fri, 2015-09-04 at 17:51 -0300, Arnaldo Carvalho de Melo wrote:
>> Em Tue, Sep 01, 2015 at 12:18:47PM +0530, Hemant Kumar escreveu:
>>>> Should I try to process the 5 together, applying thest two first?
>>   
>>> Yes, this patchset needs to be applied before applying the other patchset,
>>> since there is a direct dependency on these two for the tooling part to
>>> work.
>>   
>>>> I see there are no acks from powerpc arch maintainers, how should we
>>>> proceed here? If there are no problems with the arch bits, and if it is
>>>> just to enable the tooling part, again, should I process the 5 as just
>>>> one series?
>>   
>>> The reason to split the earlier patchset into two was to separate the
>>> tooling/perf/ and arch/powerpc/ side patches, as asked by Michael..
>>   
>>> Here is the link to that discussion :
>>> http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg86916.html
>>   
>>> If Michael is ok with the patches, you can process all the 5 patches
>>> together. Michael?
>> Michael?
> I'm not particularly happy with it.
>
> Can we at least remove this hunk from the uapi header:
>
> +/* This is to shut the compiler up */
> +#define KVM_ENTRY_TRACE ""
> +#define KVM_EXIT_TRACE ""
> +#define KVM_EXIT_REASON ""
>

Agreed, I didn't like this too, but I kept this because of the generic
perf userspace code that looks for KVM_{ENTRY,EXIT}_TRACE and
KVM_EXIT_REASON. We can remove this and put this hunk in the
userspace side.

Arnaldo,
Can we remove the dependency on uapi altogether (also suggested
by Scott) because it doesn't seem to fulfill much purpose? Rather,
hardcode the events in the userspace completely (since, tracepoint
event names are unlikely to change) ? Some of what is being done
by x86 already in kvm-stat.c where its defining kvm_events_tp[] and
its not using the macros, rather, the tracepoints directly. Macros are
only being used in builtin-kvm.c where the tracepoint names are
matched with KVM_{ENTRY,EXIT}_TRACE and when we are looking
for the key KVM_EXIT_REASON.

-- 
Thanks,
Hemant Kumar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1220601

FromMichael Ellerman <mpe@ellerman.id.au>
Date2015-09-08 10:40 +0200
Message-ID<q6mBz-7oT-5@gated-at.bofh.it>
In reply to#1220476
On Tue, 2015-09-08 at 10:26 +0530, Hemant Kumar wrote:
> 
> On 09/07/2015 10:40 AM, Michael Ellerman wrote:
> > On Fri, 2015-09-04 at 17:51 -0300, Arnaldo Carvalho de Melo wrote:
> >> Em Tue, Sep 01, 2015 at 12:18:47PM +0530, Hemant Kumar escreveu:
> >>>> Should I try to process the 5 together, applying thest two first?
> >>   
> >>> Yes, this patchset needs to be applied before applying the other patchset,
> >>> since there is a direct dependency on these two for the tooling part to
> >>> work.
> >>   
> >>>> I see there are no acks from powerpc arch maintainers, how should we
> >>>> proceed here? If there are no problems with the arch bits, and if it is
> >>>> just to enable the tooling part, again, should I process the 5 as just
> >>>> one series?
> >>   
> >>> The reason to split the earlier patchset into two was to separate the
> >>> tooling/perf/ and arch/powerpc/ side patches, as asked by Michael..
> >>   
> >>> Here is the link to that discussion :
> >>> http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg86916.html
> >>   
> >>> If Michael is ok with the patches, you can process all the 5 patches
> >>> together. Michael?
> >> Michael?
> > I'm not particularly happy with it.
> >
> > Can we at least remove this hunk from the uapi header:
> >
> > +/* This is to shut the compiler up */
> > +#define KVM_ENTRY_TRACE ""
> > +#define KVM_EXIT_TRACE ""
> > +#define KVM_EXIT_REASON ""
> >
> 
> Agreed, I didn't like this too, but I kept this because of the generic
> perf userspace code that looks for KVM_{ENTRY,EXIT}_TRACE and
> KVM_EXIT_REASON. We can remove this and put this hunk in the
> userspace side.

Yes please.

> Arnaldo,
> Can we remove the dependency on uapi altogether (also suggested
> by Scott) because it doesn't seem to fulfill much purpose? Rather,
> hardcode the events in the userspace completely (since, tracepoint
> event names are unlikely to change) ? Some of what is being done
> by x86 already in kvm-stat.c where its defining kvm_events_tp[] and
> its not using the macros, rather, the tracepoints directly. Macros are
> only being used in builtin-kvm.c where the tracepoint names are
> matched with KVM_{ENTRY,EXIT}_TRACE and when we are looking
> for the key KVM_EXIT_REASON.

That would certainly make me a lot happier with it.

Also think about what would happen if the tracepoint names *did* change. The
perf code would want to try and work with both the old and new names, so at
that point you'd end up hard coding the names in the perf code anyway.

cheers



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1220924

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2015-09-08 17:20 +0200
Message-ID<q6sQG-80Q-23@gated-at.bofh.it>
In reply to#1220601
Em Tue, Sep 08, 2015 at 06:33:45PM +1000, Michael Ellerman escreveu:
> On Tue, 2015-09-08 at 10:26 +0530, Hemant Kumar wrote:
> > 
> > On 09/07/2015 10:40 AM, Michael Ellerman wrote:
> > > On Fri, 2015-09-04 at 17:51 -0300, Arnaldo Carvalho de Melo wrote:
> > >> Em Tue, Sep 01, 2015 at 12:18:47PM +0530, Hemant Kumar escreveu:
> > >>>> Should I try to process the 5 together, applying thest two first?
> > >>   
> > >>> Yes, this patchset needs to be applied before applying the other patchset,
> > >>> since there is a direct dependency on these two for the tooling part to
> > >>> work.
> > >>   
> > >>>> I see there are no acks from powerpc arch maintainers, how should we
> > >>>> proceed here? If there are no problems with the arch bits, and if it is
> > >>>> just to enable the tooling part, again, should I process the 5 as just
> > >>>> one series?
> > >>   
> > >>> The reason to split the earlier patchset into two was to separate the
> > >>> tooling/perf/ and arch/powerpc/ side patches, as asked by Michael..
> > >>   
> > >>> Here is the link to that discussion :
> > >>> http://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg86916.html
> > >>   
> > >>> If Michael is ok with the patches, you can process all the 5 patches
> > >>> together. Michael?
> > >> Michael?
> > > I'm not particularly happy with it.
> > >
> > > Can we at least remove this hunk from the uapi header:
> > >
> > > +/* This is to shut the compiler up */
> > > +#define KVM_ENTRY_TRACE ""
> > > +#define KVM_EXIT_TRACE ""
> > > +#define KVM_EXIT_REASON ""
> > >
> > 
> > Agreed, I didn't like this too, but I kept this because of the generic
> > perf userspace code that looks for KVM_{ENTRY,EXIT}_TRACE and
> > KVM_EXIT_REASON. We can remove this and put this hunk in the
> > userspace side.
> 
> Yes please.
> 
> > Arnaldo,
> > Can we remove the dependency on uapi altogether (also suggested
> > by Scott) because it doesn't seem to fulfill much purpose? Rather,
> > hardcode the events in the userspace completely (since, tracepoint
> > event names are unlikely to change) ? Some of what is being done
> > by x86 already in kvm-stat.c where its defining kvm_events_tp[] and
> > its not using the macros, rather, the tracepoints directly. Macros are
> > only being used in builtin-kvm.c where the tracepoint names are
> > matched with KVM_{ENTRY,EXIT}_TRACE and when we are looking
> > for the key KVM_EXIT_REASON.
> 
> That would certainly make me a lot happier with it.
> 
> Also think about what would happen if the tracepoint names *did* change. The
> perf code would want to try and work with both the old and new names, so at
> that point you'd end up hard coding the names in the perf code anyway.

Yeah, seems like we have a plan :-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web