Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1220397 > unrolled thread
| Started by | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| First post | 2015-09-07 23:00 +0200 |
| Last post | 2015-09-07 23:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] stmmac: fix check for phydev being open Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-09-07 23:00 +0200
Re: [PATCH v2] stmmac: fix check for phydev being open Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-09-07 23:10 +0200
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2015-09-07 23:00 +0200 |
| Subject | Re: [PATCH v2] stmmac: fix check for phydev being open |
| Message-ID | <q6bGa-8hQ-15@gated-at.bofh.it> |
On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
> Current implementation via IS_ERR(phydev) may make no sense because
> of_phy_attach() returns NULL on failure instead of error value.
>
> Still for checking result of phy_connect() IS_ERR() is useful.
>
> To address both situations we use combined IS_ERR_OR_NULL() check.
>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Cc: David Miller <davem@davemloft.net>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> ---
>
> Changes compared to v1:
> * Use IS_ERR_OR_NULL() instead of discrete checks for null and err
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 864b476..7985d8a 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -837,7 +837,7 @@ static int stmmac_init_phy(struct net_device *dev)
> interface);
> }
>
> - if (IS_ERR(phydev)) {
> + if (IS_ERR_OR_NULL(phydev)) {
> pr_err("%s: Could not attach to PHY\n", dev->name);
> return PTR_ERR(phydev);
Hm, in case of phydev == NULL, you're going to return 0 here... is that
what you want?
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alexey Brodkin <Alexey.Brodkin@synopsys.com> |
|---|---|
| Date | 2015-09-07 23:10 +0200 |
| Message-ID | <q6bPR-gZ-33@gated-at.bofh.it> |
| In reply to | #1220397 |
Hi Sergei, On Mon, 2015-09-07 at 23:53 +-0300, Sergei Shtylyov wrote: +AD4- On 09/07/2015 11:50 PM, Alexey Brodkin wrote: +AD4- +AD4- +AD4- Current implementation via IS+AF8-ERR(phydev) may make no sense because +AD4- +AD4- of+AF8-phy+AF8-attach() returns NULL on failure instead of error value. +AD4- +AD4- +AD4- +AD4- Still for checking result of phy+AF8-connect() IS+AF8-ERR() is useful. +AD4- +AD4- +AD4- +AD4- To address both situations we use combined IS+AF8-ERR+AF8-OR+AF8-NULL() check. +AD4- +AD4- +AD4- +AD4- Cc: Giuseppe Cavallaro +ADw-peppe.cavallaro+AEA-st.com+AD4- +AD4- +AD4- Cc: linux-kernel+AEA-vger.kernel.org +AD4- +AD4- Cc: stable+AEA-vger.kernel.org +AD4- +AD4- Cc: David Miller +ADw-davem+AEA-davemloft.net+AD4- +AD4- +AD4- Cc: Sergei Shtylyov +ADw-sergei.shtylyov+AEA-cogentembedded.com+AD4- +AD4- +AD4- Signed-off-by: Alexey Brodkin +ADw-abrodkin+AEA-synopsys.com+AD4- +AD4- +AD4- --- +AD4- +AD4- +AD4- +AD4- Changes compared to v1: +AD4- +AD4- +ACo- Use IS+AF8-ERR+AF8-OR+AF8-NULL() instead of discrete checks for null and err +AD4- +AD4- +AD4- +AD4- drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c +AHw- 2 +-- +AD4- +AD4- 1 file changed, 1 insertion(+-), 1 deletion(-) +AD4- +AD4- +AD4- +AD4- diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c +AD4- +AD4- index 864b476..7985d8a 100644 +AD4- +AD4- --- a/drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c +AD4- +AD4- +-+-+- b/drivers/net/ethernet/stmicro/stmmac/stmmac+AF8-main.c +AD4- +AD4- +AEAAQA- -837,7 +-837,7 +AEAAQA- static int stmmac+AF8-init+AF8-phy(struct net+AF8-device +ACo-dev) +AD4- +AD4- interface)+ADs- +AD4- +AD4- +AH0- +AD4- +AD4- +AD4- +AD4- - if (IS+AF8-ERR(phydev)) +AHs- +AD4- +AD4- +- if (IS+AF8-ERR+AF8-OR+AF8-NULL(phydev)) +AHs- +AD4- +AD4- pr+AF8-err(+ACIAJQ-s: Could not attach to PHY+AFw-n+ACI-, dev-+AD4-name)+ADs- +AD4- +AD4- return PTR+AF8-ERR(phydev)+ADs- +AD4- +AD4- Hm, in case of phydev +AD0APQ- NULL, you're going to return 0 here... is that +AD4- what you want? Ah, right. So then the question would be what's a proper error code for +ACE-phydev: -ENOENT or -ENODEV? -Alexey-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web