Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1221336 > unrolled thread
| Started by | Baptiste Reynal <b.reynal@virtualopensystems.com> |
|---|---|
| First post | 2015-09-09 11:30 +0200 |
| Last post | 2015-09-09 22:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC PATCH v4 3/3] vfio: platform: return device properties as arrays of unsigned integers Baptiste Reynal <b.reynal@virtualopensystems.com> - 2015-09-09 11:30 +0200
Re: [RFC PATCH v4 3/3] vfio: platform: return device properties as arrays of unsigned integers Alex Williamson <alex.williamson@redhat.com> - 2015-09-09 22:50 +0200
| From | Baptiste Reynal <b.reynal@virtualopensystems.com> |
|---|---|
| Date | 2015-09-09 11:30 +0200 |
| Subject | [RFC PATCH v4 3/3] vfio: platform: return device properties as arrays of unsigned integers |
| Message-ID | <q6JRy-7mz-71@gated-at.bofh.it> |
From: Antonios Motakis <a.motakis@virtualopensystems.com>
Certain properties of a device are accessible as an array of unsigned
integers, either u64, u32, u16, or u8. Let the VFIO user query this
type of device properties.
Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
Signed-off-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
---
drivers/vfio/platform/properties.c | 62 +++++++++++++++++++++++++++++++++++++-
1 file changed, 61 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/platform/properties.c b/drivers/vfio/platform/properties.c
index 8bf9c8f..625e2d3 100644
--- a/drivers/vfio/platform/properties.c
+++ b/drivers/vfio/platform/properties.c
@@ -70,7 +70,67 @@ static int dev_property_get_uint(struct device *dev, uint32_t *flags,
char *name, uint32_t type, unsigned *lenp,
void __user *datap, unsigned long datasz)
{
- return -EINVAL;
+ int ret, n;
+ u8 *out;
+ size_t sz;
+ int (*func)(const struct device *, const char *, void *, size_t)
+ = NULL;
+
+ switch (type) {
+ case VFIO_DEV_PROPERTY_TYPE_U64:
+ sz = sizeof(u64);
+ func = (int (*)(const struct device *,
+ const char *, void *, size_t))
+ device_property_read_u64_array;
+ break;
+ case VFIO_DEV_PROPERTY_TYPE_U32:
+ sz = sizeof(u32);
+ func = (int (*)(const struct device *,
+ const char *, void *, size_t))
+ device_property_read_u32_array;
+ break;
+ case VFIO_DEV_PROPERTY_TYPE_U16:
+ sz = sizeof(u16);
+ func = (int (*)(const struct device *,
+ const char *, void *, size_t))
+ device_property_read_u16_array;
+ break;
+ case VFIO_DEV_PROPERTY_TYPE_U8:
+ sz = sizeof(u8);
+ func = (int (*)(const struct device *,
+ const char *, void *, size_t))
+ device_property_read_u8_array;
+ break;
+
+ default:
+ return -EINVAL;
+ }
+
+ /* get size of array */
+ n = func(dev, name, NULL, 0);
+ if (n < 0)
+ return n;
+
+ if (lenp)
+ *lenp = n * sz;
+
+ if (n * sz > datasz)
+ return -EOVERFLOW;
+
+ out = kcalloc(n, sz, GFP_KERNEL);
+ if (!out)
+ return -ENOMEM;
+
+ ret = func(dev, name, out, n);
+ if (ret)
+ goto out;
+
+ if (copy_to_user(datap, out, n * sz))
+ ret = -EFAULT;
+
+out:
+ kfree(out);
+ return ret;
}
int vfio_platform_dev_properties(struct device *dev, uint32_t *flags,
--
2.5.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alex Williamson <alex.williamson@redhat.com> |
|---|---|
| Date | 2015-09-09 22:50 +0200 |
| Subject | Re: [RFC PATCH v4 3/3] vfio: platform: return device properties as arrays of unsigned integers |
| Message-ID | <q6UtA-5EP-11@gated-at.bofh.it> |
| In reply to | #1221336 |
On Wed, 2015-09-09 at 11:17 +0200, Baptiste Reynal wrote:
> From: Antonios Motakis <a.motakis@virtualopensystems.com>
>
> Certain properties of a device are accessible as an array of unsigned
> integers, either u64, u32, u16, or u8. Let the VFIO user query this
> type of device properties.
>
> Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
> Signed-off-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
> ---
> drivers/vfio/platform/properties.c | 62 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 61 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/platform/properties.c b/drivers/vfio/platform/properties.c
> index 8bf9c8f..625e2d3 100644
> --- a/drivers/vfio/platform/properties.c
> +++ b/drivers/vfio/platform/properties.c
> @@ -70,7 +70,67 @@ static int dev_property_get_uint(struct device *dev, uint32_t *flags,
> char *name, uint32_t type, unsigned *lenp,
> void __user *datap, unsigned long datasz)
> {
> - return -EINVAL;
> + int ret, n;
> + u8 *out;
> + size_t sz;
> + int (*func)(const struct device *, const char *, void *, size_t)
> + = NULL;
> +
> + switch (type) {
> + case VFIO_DEV_PROPERTY_TYPE_U64:
> + sz = sizeof(u64);
> + func = (int (*)(const struct device *,
> + const char *, void *, size_t))
> + device_property_read_u64_array;
> + break;
> + case VFIO_DEV_PROPERTY_TYPE_U32:
> + sz = sizeof(u32);
> + func = (int (*)(const struct device *,
> + const char *, void *, size_t))
> + device_property_read_u32_array;
> + break;
> + case VFIO_DEV_PROPERTY_TYPE_U16:
> + sz = sizeof(u16);
> + func = (int (*)(const struct device *,
> + const char *, void *, size_t))
> + device_property_read_u16_array;
> + break;
> + case VFIO_DEV_PROPERTY_TYPE_U8:
> + sz = sizeof(u8);
> + func = (int (*)(const struct device *,
> + const char *, void *, size_t))
> + device_property_read_u8_array;
> + break;
> +
> + default:
> + return -EINVAL;
> + }
> +
> + /* get size of array */
> + n = func(dev, name, NULL, 0);
> + if (n < 0)
> + return n;
> +
> + if (lenp)
> + *lenp = n * sz;
Why is this conditional?
> +
> + if (n * sz > datasz)
> + return -EOVERFLOW;
Ugh, this isn't E2BIG or ENOSPC...
> +
> + out = kcalloc(n, sz, GFP_KERNEL);
> + if (!out)
> + return -ENOMEM;
> +
> + ret = func(dev, name, out, n);
> + if (ret)
> + goto out;
> +
> + if (copy_to_user(datap, out, n * sz))
> + ret = -EFAULT;
> +
> +out:
> + kfree(out);
> + return ret;
> }
>
> int vfio_platform_dev_properties(struct device *dev, uint32_t *flags,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web