Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1221704 > unrolled thread
| Started by | Sergei Trofimovich <slyich@gmail.com> |
|---|---|
| First post | 2015-09-09 23:00 +0200 |
| Last post | 2015-09-10 10:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] net/mac80211/rate.c: fix wrong sizeof() Sergei Trofimovich <slyich@gmail.com> - 2015-09-09 23:00 +0200
Re: [PATCH] net/mac80211/rate.c: fix wrong sizeof() Johannes Berg <johannes@sipsolutions.net> - 2015-09-10 10:20 +0200
| From | Sergei Trofimovich <slyich@gmail.com> |
|---|---|
| Date | 2015-09-09 23:00 +0200 |
| Subject | [PATCH] net/mac80211/rate.c: fix wrong sizeof() |
| Message-ID | <q6UDg-5Q3-3@gated-at.bofh.it> |
From: Sergei Trofimovich <siarheit@google.com>
Noticed by gcc-5.2.0:
net/mac80211/rate.c: In function 'rate_control_cap_mask':
net/mac80211/rate.c:719:25: warning: 'sizeof' on array function parameter 'mcs_mask' will return size of 'u8 * {aka unsigned char *}' [-Wsizeof-array-argument]
for (i = 0; i < sizeof(mcs_mask); i++)
^
CC: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
CC: Johannes Berg <johannes@sipsolutions.net>
CC: "David S. Miller" <davem@davemloft.net>
CC: linux-wireless@vger.kernel.org
CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Sergei Trofimovich <siarheit@google.com>
---
net/mac80211/rate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c
index 9857693..9ce8883 100644
--- a/net/mac80211/rate.c
+++ b/net/mac80211/rate.c
@@ -716,7 +716,7 @@ static bool rate_control_cap_mask(struct ieee80211_sub_if_data *sdata,
/* Filter out rates that the STA does not support */
*mask &= sta->supp_rates[sband->band];
- for (i = 0; i < sizeof(mcs_mask); i++)
+ for (i = 0; i < IEEE80211_HT_MCS_MASK_LEN; i++)
mcs_mask[i] &= sta->ht_cap.mcs.rx_mask[i];
sta_vht_cap = sta->vht_cap.vht_mcs.rx_mcs_map;
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Johannes Berg <johannes@sipsolutions.net> |
|---|---|
| Date | 2015-09-10 10:20 +0200 |
| Message-ID | <q75fk-4cM-3@gated-at.bofh.it> |
| In reply to | #1221704 |
On Wed, 2015-09-09 at 21:56 +0100, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <siarheit@google.com>
>
> Noticed by gcc-5.2.0:
>
> net/mac80211/rate.c: In function 'rate_control_cap_mask':
> net/mac80211/rate.c:719:25: warning: 'sizeof' on array function
> parameter 'mcs_mask' will return size of 'u8 * {aka unsigned char *}'
> [-Wsizeof-array-argument]
> for (i = 0; i < sizeof(mcs_mask); i++)
> ^
>
We already merged a fix for this.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web