Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221584 > unrolled thread

[PATCH] toshiba_acpi: Fix USB Sleep and Music always disabled

Back to article view | Back to linux.kernel

Contents

  [PATCH] toshiba_acpi: Fix USB Sleep and Music always disabled Azael Avalos <coproscefalo@gmail.com> - 2015-09-09 19:30 +0200
    Re: [PATCH] toshiba_acpi: Fix USB Sleep and Music always disabled Darren Hart <dvhart@infradead.org> - 2015-09-10 18:20 +0200

#1221584 — [PATCH] toshiba_acpi: Fix USB Sleep and Music always disabled

Commit e1a949c1b988 ("toshiba_acpi: Refactor *{get, set} functions return
value") made changes on the return type of the HCI/SCI functions, but a
typo on the USB Sleep and Music code is always reporting non existent
support for such feature.

This patch corrects the typo, changing an assignment to a comparison,
making the laptops with actual support for such feature to work again.

Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
---
Darren,

Hopefully this patch can go into one of the 4.3 RCs, as the changes are
there and to avoid shipping a broken feature support.

 drivers/platform/x86/toshiba_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index 6740c51..c434b53 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -938,7 +938,7 @@ static int toshiba_usb_sleep_music_get(struct toshiba_acpi_dev *dev, u32 *state)
 	else if (result == TOS_NOT_SUPPORTED)
 		return -ENODEV;
 
-	return result = TOS_SUCCESS ? 0 : -EIO;
+	return result == TOS_SUCCESS ? 0 : -EIO;
 }
 
 static int toshiba_usb_sleep_music_set(struct toshiba_acpi_dev *dev, u32 state)
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1222278

On Wed, Sep 09, 2015 at 11:25:44AM -0600, Azael Avalos wrote:
> Commit e1a949c1b988 ("toshiba_acpi: Refactor *{get, set} functions return
> value") made changes on the return type of the HCI/SCI functions, but a
> typo on the USB Sleep and Music code is always reporting non existent
> support for such feature.
> 
> This patch corrects the typo, changing an assignment to a comparison,
> making the laptops with actual support for such feature to work again.
> 
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
> ---
> Darren,
> 
> Hopefully this patch can go into one of the 4.3 RCs, as the changes are
> there and to avoid shipping a broken feature support.

Queued for 4.3, thanks Azael.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web