Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1221526 > unrolled thread
| Started by | Laurent Vivier <lvivier@redhat.com> |
|---|---|
| First post | 2015-09-09 17:30 +0200 |
| Last post | 2015-09-10 03:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ibmvsci: make parameters max_id and max_channel read-only Laurent Vivier <lvivier@redhat.com> - 2015-09-09 17:30 +0200
Re: [PATCH] ibmvsci: make parameters max_id and max_channel read-only Brian King <brking@linux.vnet.ibm.com> - 2015-09-09 17:40 +0200
Re: [PATCH] ibmvsci: make parameters max_id and max_channel read-only David Gibson <dgibson@redhat.com> - 2015-09-10 03:00 +0200
| From | Laurent Vivier <lvivier@redhat.com> |
|---|---|
| Date | 2015-09-09 17:30 +0200 |
| Subject | [PATCH] ibmvsci: make parameters max_id and max_channel read-only |
| Message-ID | <q6PtV-717-33@gated-at.bofh.it> |
The value of the parameter is never re-read by the driver,
so a new value is ignored. Let know the user he
can't modify it by removing writable attribute.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 6a41c36..3e76490 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -105,9 +105,9 @@ MODULE_AUTHOR("Dave Boutcher");
MODULE_LICENSE("GPL");
MODULE_VERSION(IBMVSCSI_VERSION);
-module_param_named(max_id, max_id, int, S_IRUGO | S_IWUSR);
+module_param_named(max_id, max_id, int, S_IRUGO);
MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
-module_param_named(max_channel, max_channel, int, S_IRUGO | S_IWUSR);
+module_param_named(max_channel, max_channel, int, S_IRUGO);
MODULE_PARM_DESC(max_channel, "Largest channel value");
module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Brian King <brking@linux.vnet.ibm.com> |
|---|---|
| Date | 2015-09-09 17:40 +0200 |
| Message-ID | <q6PDA-7cp-17@gated-at.bofh.it> |
| In reply to | #1221526 |
On 09/09/2015 10:21 AM, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. Reviewed-by: Brian King <brking@linux.vnet.ibm.com> -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | David Gibson <dgibson@redhat.com> |
|---|---|
| Date | 2015-09-10 03:00 +0200 |
| Subject | Re: [PATCH] ibmvsci: make parameters max_id and max_channel read-only |
| Message-ID | <q6Ynw-2Kg-29@gated-at.bofh.it> |
| In reply to | #1221526 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, 9 Sep 2015 17:21:00 +0200 Laurent Vivier <lvivier@redhat.com> wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. > > Signed-off-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: David Gibson <dgibson@redhat.com> -- David Gibson <dgibson@redhat.com> Senior Software Engineer, Virtualization, Red Hat
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web