Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1210292 > unrolled thread
| Started by | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> |
|---|---|
| First post | 2015-08-20 10:50 +0200 |
| Last post | 2015-09-10 00:20 +0200 |
| Articles | 13 — 5 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v5 0/2] hugetlb: display per-process/per-vma usage Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-08-20 10:50 +0200
[PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-08-20 10:50 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Michal Hocko <mhocko@kernel.org> - 2015-08-20 12:50 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-08-21 01:30 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Michal Hocko <mhocko@kernel.org> - 2015-08-21 08:40 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Pádraig Brady <P@draigBrady.com> - 2015-09-07 03:40 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-09-07 04:30 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-09-07 08:50 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Pádraig Brady <P@draigBrady.com> - 2015-09-07 12:00 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Pádraig Brady <P@draigBrady.com> - 2015-09-07 13:00 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-09-17 12:00 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps Vlastimil Babka <vbabka@suse.cz> - 2015-09-09 17:20 +0200
Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps David Rientjes <rientjes@google.com> - 2015-09-10 00:20 +0200
| From | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> |
|---|---|
| Date | 2015-08-20 10:50 +0200 |
| Subject | [PATCH v5 0/2] hugetlb: display per-process/per-vma usage |
| Message-ID | <pZtHQ-8aH-15@gated-at.bofh.it> |
VGhlIHByZXZpb3VzIHZlcnNpb24gaGFkIGJ1aWxkIGlzc3VlcyBpbiBzb21lIGFyY2hpdGVjdHVy ZXMsIGJlY2F1c2UgaXQNCnJlcXVpcmVkIHRvIG1vdmUgdGhlIGRlZmluaXRpb24gb2YgSFVHRV9N QVhfSFNUQVRFIGFjcm9zcyBoZWFkZXIgZmlsZXMNCmluIG9yZGVyIHRvIGVtYmVkIGEgbmV3IGRh dGEgc3RydWN0dXJlIHN0cnVjdCBodWdldGxiX3VzYWdlIGludG8gc3RydWN0DQptbV9zdHJ1Y3Qu IFRoaXMgd2FzIGEgaGFyZCBwcm9ibGVtIHRvIHNvbHZlLCBzbyBJIHRvb2sgYW5vdGhlciBhcHBy b2FjaA0KaW4gdGhpcyB2ZXJzaW9uLCB3aGVyZSBJIGFkZCBqdXN0IGEgcG9pbnRlciAoc3RydWN0 IGh1Z2V0bGJfdXNhZ2UgKikgdG8NCnN0cnVjdCBtbV9zdHJ1Y3QgYW5kIGR5bmFtaWNhbGx5IGFs bG9jYXRlIGFuZCBsaW5rIGl0Lg0KVGhpcyBtYWtlcyB0aGUgY2hhbmdlcyBsYXJnZXIsIGJ1dCBu byBidWlsZCBpc3N1ZXMuDQoNClRoYW5rcywNCk5hb3lhIEhvcmlndWNoaQ0KLS0tDQpTdW1tYXJ5 Og0KDQpOYW95YSBIb3JpZ3VjaGkgKDIpOg0KICAgICAgbW06IGh1Z2V0bGI6IHByb2M6IGFkZCBI dWdldGxiUGFnZXMgZmllbGQgdG8gL3Byb2MvUElEL3NtYXBzDQogICAgICBtbTogaHVnZXRsYjog cHJvYzogYWRkIEh1Z2V0bGJQYWdlcyBmaWVsZCB0byAvcHJvYy9QSUQvc3RhdHVzDQoNCiBEb2N1 bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL3Byb2MudHh0IHwgMTAgKysrKysrKy0tDQogZnMvaHVnZXRs YmZzL2lub2RlLmMgICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysNCiBmcy9wcm9jL3Rhc2tf bW11LmMgICAgICAgICAgICAgICAgIHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKw0KIGlu Y2x1ZGUvbGludXgvaHVnZXRsYi5oICAgICAgICAgICAgfCAzNiArKysrKysrKysrKysrKysrKysr KysrKysrKysrKw0KIGluY2x1ZGUvbGludXgvbW1fdHlwZXMuaCAgICAgICAgICAgfCAgNyArKysr KysNCiBrZXJuZWwvZm9yay5jICAgICAgICAgICAgICAgICAgICAgIHwgIDMgKysrDQogbW0vaHVn ZXRsYi5jICAgICAgICAgICAgICAgICAgICAgICB8IDQ2ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrDQogbW0vbW1hcC5jICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAx ICsNCiBtbS9ybWFwLmMgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDQgKysrLQ0KIDkgZmls ZXMgY2hhbmdlZCwgMTQ2IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> |
|---|---|
| Date | 2015-08-20 10:50 +0200 |
| Subject | [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <pZtHQ-8aH-27@gated-at.bofh.it> |
| In reply to | #1210292 |
Q3VycmVudGx5IC9wcm9jL1BJRC9zbWFwcyBwcm92aWRlcyBubyB1c2FnZSBpbmZvIGZvciB2bWEo Vk1fSFVHRVRMQiksIHdoaWNoDQppcyBpbmNvbnZlbmllbnQgd2hlbiB3ZSB3YW50IHRvIGtub3cg cGVyLXRhc2sgb3IgcGVyLXZtYSBiYXNlIGh1Z2V0bGIgdXNhZ2UuDQpUbyBzb2x2ZSB0aGlzLCB0 aGlzIHBhdGNoIGFkZHMgYSBuZXcgbGluZSBmb3IgaHVnZXRsYiB1c2FnZSBsaWtlIGJlbG93Og0K DQogIFNpemU6ICAgICAgICAgICAgICAyMDQ4MCBrQg0KICBSc3M6ICAgICAgICAgICAgICAgICAg IDAga0INCiAgUHNzOiAgICAgICAgICAgICAgICAgICAwIGtCDQogIFNoYXJlZF9DbGVhbjogICAg ICAgICAgMCBrQg0KICBTaGFyZWRfRGlydHk6ICAgICAgICAgIDAga0INCiAgUHJpdmF0ZV9DbGVh bjogICAgICAgICAwIGtCDQogIFByaXZhdGVfRGlydHk6ICAgICAgICAgMCBrQg0KICBSZWZlcmVu Y2VkOiAgICAgICAgICAgIDAga0INCiAgQW5vbnltb3VzOiAgICAgICAgICAgICAwIGtCDQogIEFu b25IdWdlUGFnZXM6ICAgICAgICAgMCBrQg0KICBIdWdldGxiUGFnZXM6ICAgICAgMTg0MzIga0IN CiAgU3dhcDogICAgICAgICAgICAgICAgICAwIGtCDQogIEtlcm5lbFBhZ2VTaXplOiAgICAgMjA0 OCBrQg0KICBNTVVQYWdlU2l6ZTogICAgICAgIDIwNDgga0INCiAgTG9ja2VkOiAgICAgICAgICAg ICAgICAwIGtCDQogIFZtRmxhZ3M6IHJkIHdyIG1yIG13IG1lIGRlIGh0DQoNClNpZ25lZC1vZmYt Ynk6IE5hb3lhIEhvcmlndWNoaSA8bi1ob3JpZ3VjaGlAYWguanAubmVjLmNvbT4NCkFja2VkLWJ5 OiBKb2VybiBFbmdlbCA8am9lcm5AbG9nZnMub3JnPg0KQWNrZWQtYnk6IERhdmlkIFJpZW50amVz IDxyaWVudGplc0Bnb29nbGUuY29tPg0KLS0tDQp2MyAtPiB2NDoNCi0gc3VzcGVuZCBBY2tlZC1i eSB0YWcgYmVjYXVzZSB2My0+djQgY2hhbmdlIGlzIG5vdCB0cml2aWFsDQotIEkgc3RhdGVkIGlu IHByZXZpb3VzIGRpc2N1c3Npb24gdGhhdCBIdWdldGxiUGFnZXMgbGluZSBjYW4gY29udGFpbiBw YWdlDQogIHNpemUgaW5mbywgYnV0IHRoYXQncyBub3QgbmVjZXNzYXJ5IGJlY2F1c2Ugd2UgYWxy ZWFkeSBoYXZlIEtlcm5lbFBhZ2VTaXplDQogIGluZm8uDQotIG1lcmdlZCBkb2N1bWVudGF0aW9u IHVwZGF0ZSwgd2hlcmUgdGhlIGN1cnJlbnQgZG9jdW1lbnRhdGlvbiBkb2Vzbid0IG1lbnRpb24N CiAgQW5vbkh1Z2VQYWdlcywgc28gaXQncyBhbHNvIGFkZGVkLg0KLS0tDQogRG9jdW1lbnRhdGlv bi9maWxlc3lzdGVtcy9wcm9jLnR4dCB8ICA3ICsrKysrLS0NCiBmcy9wcm9jL3Rhc2tfbW11LmMg ICAgICAgICAgICAgICAgIHwgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCiAyIGZp bGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1n aXQgdjQuMi1yYzQvRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9wcm9jLnR4dCB2NC4yLXJjNF9w YXRjaGVkL0RvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvcHJvYy50eHQNCmluZGV4IDZmN2ZhZmRl MDg4NC4uMjJlNDAyMTFlZjY0IDEwMDY0NA0KLS0tIHY0LjItcmM0L0RvY3VtZW50YXRpb24vZmls ZXN5c3RlbXMvcHJvYy50eHQNCisrKyB2NC4yLXJjNF9wYXRjaGVkL0RvY3VtZW50YXRpb24vZmls ZXN5c3RlbXMvcHJvYy50eHQNCkBAIC00MjMsNiArNDIzLDggQEAgUHJpdmF0ZV9DbGVhbjogICAg ICAgICAwIGtCDQogUHJpdmF0ZV9EaXJ0eTogICAgICAgICAwIGtCDQogUmVmZXJlbmNlZDogICAg ICAgICAgODkyIGtCDQogQW5vbnltb3VzOiAgICAgICAgICAgICAwIGtCDQorQW5vbkh1Z2VQYWdl czogICAgICAgICAwIGtCDQorSHVnZXRsYlBhZ2VzOiAgICAgICAgICAwIGtCDQogU3dhcDogICAg ICAgICAgICAgICAgICAwIGtCDQogS2VybmVsUGFnZVNpemU6ICAgICAgICA0IGtCDQogTU1VUGFn ZVNpemU6ICAgICAgICAgICA0IGtCDQpAQCAtNDQwLDggKzQ0Miw5IEBAIGluZGljYXRlcyB0aGUg YW1vdW50IG9mIG1lbW9yeSBjdXJyZW50bHkgbWFya2VkIGFzIHJlZmVyZW5jZWQgb3IgYWNjZXNz ZWQuDQogIkFub255bW91cyIgc2hvd3MgdGhlIGFtb3VudCBvZiBtZW1vcnkgdGhhdCBkb2VzIG5v dCBiZWxvbmcgdG8gYW55IGZpbGUuICBFdmVuDQogYSBtYXBwaW5nIGFzc29jaWF0ZWQgd2l0aCBh IGZpbGUgbWF5IGNvbnRhaW4gYW5vbnltb3VzIHBhZ2VzOiB3aGVuIE1BUF9QUklWQVRFDQogYW5k IGEgcGFnZSBpcyBtb2RpZmllZCwgdGhlIGZpbGUgcGFnZSBpcyByZXBsYWNlZCBieSBhIHByaXZh dGUgYW5vbnltb3VzIGNvcHkuDQotIlN3YXAiIHNob3dzIGhvdyBtdWNoIHdvdWxkLWJlLWFub255 bW91cyBtZW1vcnkgaXMgYWxzbyB1c2VkLCBidXQgb3V0IG9uDQotc3dhcC4NCisiQW5vbkh1Z2VQ YWdlcyIgc2hvd3MgdGhlIGFtbW91bnQgb2YgbWVtb3J5IGJhY2tlZCBieSB0cmFuc3BhcmVudCBo dWdlcGFnZS4NCisiSHVnZXRsYlBhZ2VzIiBzaG93cyB0aGUgYW1tb3VudCBvZiBtZW1vcnkgYmFj a2VkIGJ5IGh1Z2V0bGJmcyBwYWdlLg0KKyJTd2FwIiBzaG93cyBob3cgbXVjaCB3b3VsZC1iZS1h bm9ueW1vdXMgbWVtb3J5IGlzIGFsc28gdXNlZCwgYnV0IG91dCBvbiBzd2FwLg0KIA0KICJWbUZs YWdzIiBmaWVsZCBkZXNlcnZlcyBhIHNlcGFyYXRlIGRlc2NyaXB0aW9uLiBUaGlzIG1lbWJlciBy ZXByZXNlbnRzIHRoZSBrZXJuZWwNCiBmbGFncyBhc3NvY2lhdGVkIHdpdGggdGhlIHBhcnRpY3Vs YXIgdmlydHVhbCBtZW1vcnkgYXJlYSBpbiB0d28gbGV0dGVyIGVuY29kZWQNCmRpZmYgLS1naXQg djQuMi1yYzQvZnMvcHJvYy90YXNrX21tdS5jIHY0LjItcmM0X3BhdGNoZWQvZnMvcHJvYy90YXNr X21tdS5jDQppbmRleCBjYTFlMDkxODgxZDQuLjJjMzc5MzhiODJlZSAxMDA2NDQNCi0tLSB2NC4y LXJjNC9mcy9wcm9jL3Rhc2tfbW11LmMNCisrKyB2NC4yLXJjNF9wYXRjaGVkL2ZzL3Byb2MvdGFz a19tbXUuYw0KQEAgLTQ0NSw2ICs0NDUsNyBAQCBzdHJ1Y3QgbWVtX3NpemVfc3RhdHMgew0KIAl1 bnNpZ25lZCBsb25nIGFub255bW91czsNCiAJdW5zaWduZWQgbG9uZyBhbm9ueW1vdXNfdGhwOw0K IAl1bnNpZ25lZCBsb25nIHN3YXA7DQorCXVuc2lnbmVkIGxvbmcgaHVnZXRsYjsNCiAJdTY0IHBz czsNCiB9Ow0KIA0KQEAgLTYxMCwxMiArNjExLDM4IEBAIHN0YXRpYyB2b2lkIHNob3dfc21hcF92 bWFfZmxhZ3Moc3RydWN0IHNlcV9maWxlICptLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkN CiAJc2VxX3B1dGMobSwgJ1xuJyk7DQogfQ0KIA0KKyNpZmRlZiBDT05GSUdfSFVHRVRMQl9QQUdF DQorc3RhdGljIGludCBzbWFwc19odWdldGxiX3JhbmdlKHB0ZV90ICpwdGUsIHVuc2lnbmVkIGxv bmcgaG1hc2ssDQorCQkJCSB1bnNpZ25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGxvbmcgZW5kLA0K KwkJCQkgc3RydWN0IG1tX3dhbGsgKndhbGspDQorew0KKwlzdHJ1Y3QgbWVtX3NpemVfc3RhdHMg Km1zcyA9IHdhbGstPnByaXZhdGU7DQorCXN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hID0gd2Fs ay0+dm1hOw0KKwlzdHJ1Y3QgcGFnZSAqcGFnZSA9IE5VTEw7DQorDQorCWlmIChwdGVfcHJlc2Vu dCgqcHRlKSkgew0KKwkJcGFnZSA9IHZtX25vcm1hbF9wYWdlKHZtYSwgYWRkciwgKnB0ZSk7DQor CX0gZWxzZSBpZiAoaXNfc3dhcF9wdGUoKnB0ZSkpIHsNCisJCXN3cF9lbnRyeV90IHN3cGVudCA9 IHB0ZV90b19zd3BfZW50cnkoKnB0ZSk7DQorDQorCQlpZiAoaXNfbWlncmF0aW9uX2VudHJ5KHN3 cGVudCkpDQorCQkJcGFnZSA9IG1pZ3JhdGlvbl9lbnRyeV90b19wYWdlKHN3cGVudCk7DQorCX0N CisJaWYgKHBhZ2UpDQorCQltc3MtPmh1Z2V0bGIgKz0gaHVnZV9wYWdlX3NpemUoaHN0YXRlX3Zt YSh2bWEpKTsNCisJcmV0dXJuIDA7DQorfQ0KKyNlbmRpZiAvKiBIVUdFVExCX1BBR0UgKi8NCisN CiBzdGF0aWMgaW50IHNob3dfc21hcChzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKnYsIGludCBp c19waWQpDQogew0KIAlzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSA9IHY7DQogCXN0cnVjdCBt ZW1fc2l6ZV9zdGF0cyBtc3M7DQogCXN0cnVjdCBtbV93YWxrIHNtYXBzX3dhbGsgPSB7DQogCQku cG1kX2VudHJ5ID0gc21hcHNfcHRlX3JhbmdlLA0KKyNpZmRlZiBDT05GSUdfSFVHRVRMQl9QQUdF DQorCQkuaHVnZXRsYl9lbnRyeSA9IHNtYXBzX2h1Z2V0bGJfcmFuZ2UsDQorI2VuZGlmDQogCQku bW0gPSB2bWEtPnZtX21tLA0KIAkJLnByaXZhdGUgPSAmbXNzLA0KIAl9Ow0KQEAgLTYzNyw2ICs2 NjQsNyBAQCBzdGF0aWMgaW50IHNob3dfc21hcChzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKnYs IGludCBpc19waWQpDQogCQkgICAiUmVmZXJlbmNlZDogICAgICU4bHUga0JcbiINCiAJCSAgICJB bm9ueW1vdXM6ICAgICAgJThsdSBrQlxuIg0KIAkJICAgIkFub25IdWdlUGFnZXM6ICAlOGx1IGtC XG4iDQorCQkgICAiSHVnZXRsYlBhZ2VzOiAgICU4bHUga0JcbiINCiAJCSAgICJTd2FwOiAgICAg ICAgICAgJThsdSBrQlxuIg0KIAkJICAgIktlcm5lbFBhZ2VTaXplOiAlOGx1IGtCXG4iDQogCQkg ICAiTU1VUGFnZVNpemU6ICAgICU4bHUga0JcbiINCkBAIC02NTEsNiArNjc5LDcgQEAgc3RhdGlj IGludCBzaG93X3NtYXAoc3RydWN0IHNlcV9maWxlICptLCB2b2lkICp2LCBpbnQgaXNfcGlkKQ0K IAkJICAgbXNzLnJlZmVyZW5jZWQgPj4gMTAsDQogCQkgICBtc3MuYW5vbnltb3VzID4+IDEwLA0K IAkJICAgbXNzLmFub255bW91c190aHAgPj4gMTAsDQorCQkgICBtc3MuaHVnZXRsYiA+PiAxMCwN CiAJCSAgIG1zcy5zd2FwID4+IDEwLA0KIAkJICAgdm1hX2tlcm5lbF9wYWdlc2l6ZSh2bWEpID4+ IDEwLA0KIAkJICAgdm1hX21tdV9wYWdlc2l6ZSh2bWEpID4+IDEwLA0KLS0gDQoyLjQuMw0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Date | 2015-08-20 12:50 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <pZvzY-2qY-7@gated-at.bofh.it> |
| In reply to | #1210294 |
On Thu 20-08-15 08:26:26, Naoya Horiguchi wrote:
> Currently /proc/PID/smaps provides no usage info for vma(VM_HUGETLB), which
> is inconvenient when we want to know per-task or per-vma base hugetlb usage.
> To solve this, this patch adds a new line for hugetlb usage like below:
>
> Size: 20480 kB
> Rss: 0 kB
> Pss: 0 kB
> Shared_Clean: 0 kB
> Shared_Dirty: 0 kB
> Private_Clean: 0 kB
> Private_Dirty: 0 kB
> Referenced: 0 kB
> Anonymous: 0 kB
> AnonHugePages: 0 kB
> HugetlbPages: 18432 kB
> Swap: 0 kB
> KernelPageSize: 2048 kB
> MMUPageSize: 2048 kB
> Locked: 0 kB
> VmFlags: rd wr mr mw me de ht
I have only now got to this thread. This is indeed very helpful. I would
just suggest to update Documentation/filesystems/proc.txt to be explicit
that Rss: doesn't count hugetlb pages for historical reasons.
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Acked-by: Joern Engel <joern@logfs.org>
> Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
> ---
> v3 -> v4:
> - suspend Acked-by tag because v3->v4 change is not trivial
> - I stated in previous discussion that HugetlbPages line can contain page
> size info, but that's not necessary because we already have KernelPageSize
> info.
> - merged documentation update, where the current documentation doesn't mention
> AnonHugePages, so it's also added.
> ---
> Documentation/filesystems/proc.txt | 7 +++++--
> fs/proc/task_mmu.c | 29 +++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+), 2 deletions(-)
>
> diff --git v4.2-rc4/Documentation/filesystems/proc.txt v4.2-rc4_patched/Documentation/filesystems/proc.txt
> index 6f7fafde0884..22e40211ef64 100644
> --- v4.2-rc4/Documentation/filesystems/proc.txt
> +++ v4.2-rc4_patched/Documentation/filesystems/proc.txt
> @@ -423,6 +423,8 @@ Private_Clean: 0 kB
> Private_Dirty: 0 kB
> Referenced: 892 kB
> Anonymous: 0 kB
> +AnonHugePages: 0 kB
> +HugetlbPages: 0 kB
> Swap: 0 kB
> KernelPageSize: 4 kB
> MMUPageSize: 4 kB
> @@ -440,8 +442,9 @@ indicates the amount of memory currently marked as referenced or accessed.
> "Anonymous" shows the amount of memory that does not belong to any file. Even
> a mapping associated with a file may contain anonymous pages: when MAP_PRIVATE
> and a page is modified, the file page is replaced by a private anonymous copy.
> -"Swap" shows how much would-be-anonymous memory is also used, but out on
> -swap.
> +"AnonHugePages" shows the ammount of memory backed by transparent hugepage.
> +"HugetlbPages" shows the ammount of memory backed by hugetlbfs page.
> +"Swap" shows how much would-be-anonymous memory is also used, but out on swap.
>
> "VmFlags" field deserves a separate description. This member represents the kernel
> flags associated with the particular virtual memory area in two letter encoded
> diff --git v4.2-rc4/fs/proc/task_mmu.c v4.2-rc4_patched/fs/proc/task_mmu.c
> index ca1e091881d4..2c37938b82ee 100644
> --- v4.2-rc4/fs/proc/task_mmu.c
> +++ v4.2-rc4_patched/fs/proc/task_mmu.c
> @@ -445,6 +445,7 @@ struct mem_size_stats {
> unsigned long anonymous;
> unsigned long anonymous_thp;
> unsigned long swap;
> + unsigned long hugetlb;
> u64 pss;
> };
>
> @@ -610,12 +611,38 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
> seq_putc(m, '\n');
> }
>
> +#ifdef CONFIG_HUGETLB_PAGE
> +static int smaps_hugetlb_range(pte_t *pte, unsigned long hmask,
> + unsigned long addr, unsigned long end,
> + struct mm_walk *walk)
> +{
> + struct mem_size_stats *mss = walk->private;
> + struct vm_area_struct *vma = walk->vma;
> + struct page *page = NULL;
> +
> + if (pte_present(*pte)) {
> + page = vm_normal_page(vma, addr, *pte);
> + } else if (is_swap_pte(*pte)) {
> + swp_entry_t swpent = pte_to_swp_entry(*pte);
> +
> + if (is_migration_entry(swpent))
> + page = migration_entry_to_page(swpent);
> + }
> + if (page)
> + mss->hugetlb += huge_page_size(hstate_vma(vma));
> + return 0;
> +}
> +#endif /* HUGETLB_PAGE */
> +
> static int show_smap(struct seq_file *m, void *v, int is_pid)
> {
> struct vm_area_struct *vma = v;
> struct mem_size_stats mss;
> struct mm_walk smaps_walk = {
> .pmd_entry = smaps_pte_range,
> +#ifdef CONFIG_HUGETLB_PAGE
> + .hugetlb_entry = smaps_hugetlb_range,
> +#endif
> .mm = vma->vm_mm,
> .private = &mss,
> };
> @@ -637,6 +664,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid)
> "Referenced: %8lu kB\n"
> "Anonymous: %8lu kB\n"
> "AnonHugePages: %8lu kB\n"
> + "HugetlbPages: %8lu kB\n"
> "Swap: %8lu kB\n"
> "KernelPageSize: %8lu kB\n"
> "MMUPageSize: %8lu kB\n"
> @@ -651,6 +679,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid)
> mss.referenced >> 10,
> mss.anonymous >> 10,
> mss.anonymous_thp >> 10,
> + mss.hugetlb >> 10,
> mss.swap >> 10,
> vma_kernel_pagesize(vma) >> 10,
> vma_mmu_pagesize(vma) >> 10,
> --
> 2.4.3
> N?????r??y????b?X??ǧv?^?){.n?+????{????zX????ܨ}???Ơz?&j:+v???????zZ+??+zf???h???~????i???z??w?????????&?)ߢf??^jǫy?m??@A?a???0??h???i
--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> |
|---|---|
| Date | 2015-08-21 01:30 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <pZHrr-2Sp-7@gated-at.bofh.it> |
| In reply to | #1210407 |
T24gVGh1LCBBdWcgMjAsIDIwMTUgYXQgMTI6NDk6MjlQTSArMDIwMCwgTWljaGFsIEhvY2tvIHdy b3RlOg0KPiBPbiBUaHUgMjAtMDgtMTUgMDg6MjY6MjYsIE5hb3lhIEhvcmlndWNoaSB3cm90ZToN Cj4gPiBDdXJyZW50bHkgL3Byb2MvUElEL3NtYXBzIHByb3ZpZGVzIG5vIHVzYWdlIGluZm8gZm9y IHZtYShWTV9IVUdFVExCKSwgd2hpY2gNCj4gPiBpcyBpbmNvbnZlbmllbnQgd2hlbiB3ZSB3YW50 IHRvIGtub3cgcGVyLXRhc2sgb3IgcGVyLXZtYSBiYXNlIGh1Z2V0bGIgdXNhZ2UuDQo+ID4gVG8g c29sdmUgdGhpcywgdGhpcyBwYXRjaCBhZGRzIGEgbmV3IGxpbmUgZm9yIGh1Z2V0bGIgdXNhZ2Ug bGlrZSBiZWxvdzoNCj4gPiANCj4gPiAgIFNpemU6ICAgICAgICAgICAgICAyMDQ4MCBrQg0KPiA+ ICAgUnNzOiAgICAgICAgICAgICAgICAgICAwIGtCDQo+ID4gICBQc3M6ICAgICAgICAgICAgICAg ICAgIDAga0INCj4gPiAgIFNoYXJlZF9DbGVhbjogICAgICAgICAgMCBrQg0KPiA+ICAgU2hhcmVk X0RpcnR5OiAgICAgICAgICAwIGtCDQo+ID4gICBQcml2YXRlX0NsZWFuOiAgICAgICAgIDAga0IN Cj4gPiAgIFByaXZhdGVfRGlydHk6ICAgICAgICAgMCBrQg0KPiA+ICAgUmVmZXJlbmNlZDogICAg ICAgICAgICAwIGtCDQo+ID4gICBBbm9ueW1vdXM6ICAgICAgICAgICAgIDAga0INCj4gPiAgIEFu b25IdWdlUGFnZXM6ICAgICAgICAgMCBrQg0KPiA+ICAgSHVnZXRsYlBhZ2VzOiAgICAgIDE4NDMy IGtCDQo+ID4gICBTd2FwOiAgICAgICAgICAgICAgICAgIDAga0INCj4gPiAgIEtlcm5lbFBhZ2VT aXplOiAgICAgMjA0OCBrQg0KPiA+ICAgTU1VUGFnZVNpemU6ICAgICAgICAyMDQ4IGtCDQo+ID4g ICBMb2NrZWQ6ICAgICAgICAgICAgICAgIDAga0INCj4gPiAgIFZtRmxhZ3M6IHJkIHdyIG1yIG13 IG1lIGRlIGh0DQo+IA0KPiBJIGhhdmUgb25seSBub3cgZ290IHRvIHRoaXMgdGhyZWFkLiBUaGlz IGlzIGluZGVlZCB2ZXJ5IGhlbHBmdWwuIEkgd291bGQNCj4ganVzdCBzdWdnZXN0IHRvIHVwZGF0 ZSBEb2N1bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL3Byb2MudHh0IHRvIGJlIGV4cGxpY2l0DQo+IHRo YXQgUnNzOiBkb2Vzbid0IGNvdW50IGh1Z2V0bGIgcGFnZXMgZm9yIGhpc3RvcmljYWwgcmVhc29u cy4NCg0KSSBhZ3JlZSwgSSB3YW50IHRoZSBmb2xsb3dpbmcgZGlmZiB0byBiZSBmb2xkZWQgdG8g dGhpcyBwYXRjaC4NCg0KPiAgDQo+ID4gU2lnbmVkLW9mZi1ieTogTmFveWEgSG9yaWd1Y2hpIDxu LWhvcmlndWNoaUBhaC5qcC5uZWMuY29tPg0KPiA+IEFja2VkLWJ5OiBKb2VybiBFbmdlbCA8am9l cm5AbG9nZnMub3JnPg0KPiA+IEFja2VkLWJ5OiBEYXZpZCBSaWVudGplcyA8cmllbnRqZXNAZ29v Z2xlLmNvbT4NCj4gDQo+IEFja2VkLWJ5OiBNaWNoYWwgSG9ja28gPG1ob2Nrb0BzdXNlLmN6Pg0K DQpUaGFuayB5b3UuDQpOYW95YSBIb3JpZ3VjaGkNCi0tLQ0KRnJvbTogTmFveWEgSG9yaWd1Y2hp IDxuLWhvcmlndWNoaUBhaC5qcC5uZWMuY29tPg0KRGF0ZTogRnJpLCAyMSBBdWcgMjAxNSAwODox MzozMSArMDkwMA0KU3ViamVjdDogW1BBVENIXSBEb2N1bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL3By b2MudHh0OiBnaXZlIGFkZGl0aW9uYWwgY29tbWVudA0KIGFib3V0IGh1Z2V0bGIgdXNhZ2UNCg0K LS0tDQogRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9wcm9jLnR4dCB8IDMgKystDQogMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KDQpkaWZmIC0tZ2l0IGEv RG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9wcm9jLnR4dCBiL0RvY3VtZW50YXRpb24vZmlsZXN5 c3RlbXMvcHJvYy50eHQNCmluZGV4IGY1NjFmYzQ2ZTQxYi4uYjc3NWI2ZmFhZWRhIDEwMDY0NA0K LS0tIGEvRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9wcm9jLnR4dA0KKysrIGIvRG9jdW1lbnRh dGlvbi9maWxlc3lzdGVtcy9wcm9jLnR4dA0KQEAgLTQ0Niw3ICs0NDYsOCBAQCBpbmRpY2F0ZXMg dGhlIGFtb3VudCBvZiBtZW1vcnkgY3VycmVudGx5IG1hcmtlZCBhcyByZWZlcmVuY2VkIG9yIGFj Y2Vzc2VkLg0KIGEgbWFwcGluZyBhc3NvY2lhdGVkIHdpdGggYSBmaWxlIG1heSBjb250YWluIGFu b255bW91cyBwYWdlczogd2hlbiBNQVBfUFJJVkFURQ0KIGFuZCBhIHBhZ2UgaXMgbW9kaWZpZWQs IHRoZSBmaWxlIHBhZ2UgaXMgcmVwbGFjZWQgYnkgYSBwcml2YXRlIGFub255bW91cyBjb3B5Lg0K ICJBbm9uSHVnZVBhZ2VzIiBzaG93cyB0aGUgYW1tb3VudCBvZiBtZW1vcnkgYmFja2VkIGJ5IHRy YW5zcGFyZW50IGh1Z2VwYWdlLg0KLSJIdWdldGxiUGFnZXMiIHNob3dzIHRoZSBhbW1vdW50IG9m IG1lbW9yeSBiYWNrZWQgYnkgaHVnZXRsYmZzIHBhZ2UuDQorIkh1Z2V0bGJQYWdlcyIgc2hvd3Mg dGhlIGFtbW91bnQgb2YgbWVtb3J5IGJhY2tlZCBieSBodWdldGxiZnMgcGFnZSAod2hpY2ggaXMN Citub3QgY291bnRlZCBpbiAiUnNzIiBvciAiUHNzIiBmaWVsZCBmb3IgaGlzdG9yaWNhbCByZWFz b25zLikNCiAiU3dhcCIgc2hvd3MgaG93IG11Y2ggd291bGQtYmUtYW5vbnltb3VzIG1lbW9yeSBp cyBhbHNvIHVzZWQsIGJ1dCBvdXQgb24gc3dhcC4NCiANCiAiVm1GbGFncyIgZmllbGQgZGVzZXJ2 ZXMgYSBzZXBhcmF0ZSBkZXNjcmlwdGlvbi4gVGhpcyBtZW1iZXIgcmVwcmVzZW50cyB0aGUga2Vy bmVsDQotLSANCjIuNC4zDQo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Date | 2015-08-21 08:40 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <pZO9A-44i-5@gated-at.bofh.it> |
| In reply to | #1210786 |
On Thu 20-08-15 23:20:12, Naoya Horiguchi wrote: [...] > From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > Date: Fri, 21 Aug 2015 08:13:31 +0900 > Subject: [PATCH] Documentation/filesystems/proc.txt: give additional comment > about hugetlb usage > > --- > Documentation/filesystems/proc.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt > index f561fc46e41b..b775b6faaeda 100644 > --- a/Documentation/filesystems/proc.txt > +++ b/Documentation/filesystems/proc.txt > @@ -446,7 +446,8 @@ indicates the amount of memory currently marked as referenced or accessed. > a mapping associated with a file may contain anonymous pages: when MAP_PRIVATE > and a page is modified, the file page is replaced by a private anonymous copy. > "AnonHugePages" shows the ammount of memory backed by transparent hugepage. > -"HugetlbPages" shows the ammount of memory backed by hugetlbfs page. > +"HugetlbPages" shows the ammount of memory backed by hugetlbfs page (which is > +not counted in "Rss" or "Pss" field for historical reasons.) > "Swap" shows how much would-be-anonymous memory is also used, but out on swap. > > "VmFlags" field deserves a separate description. This member represents the kernel Thank you! -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Pádraig Brady <P@draigBrady.com> |
|---|---|
| Date | 2015-09-07 03:40 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <q5Tzz-7IK-1@gated-at.bofh.it> |
| In reply to | #1210294 |
On 20/08/15 09:26, Naoya Horiguchi wrote:
> Currently /proc/PID/smaps provides no usage info for vma(VM_HUGETLB), which
> is inconvenient when we want to know per-task or per-vma base hugetlb usage.
> To solve this, this patch adds a new line for hugetlb usage like below:
>
> Size: 20480 kB
> Rss: 0 kB
> Pss: 0 kB
> Shared_Clean: 0 kB
> Shared_Dirty: 0 kB
> Private_Clean: 0 kB
> Private_Dirty: 0 kB
> Referenced: 0 kB
> Anonymous: 0 kB
> AnonHugePages: 0 kB
> HugetlbPages: 18432 kB
> Swap: 0 kB
> KernelPageSize: 2048 kB
> MMUPageSize: 2048 kB
> Locked: 0 kB
> VmFlags: rd wr mr mw me de ht
>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Acked-by: Joern Engel <joern@logfs.org>
> Acked-by: David Rientjes <rientjes@google.com>
> ---
> v3 -> v4:
> - suspend Acked-by tag because v3->v4 change is not trivial
> - I stated in previous discussion that HugetlbPages line can contain page
> size info, but that's not necessary because we already have KernelPageSize
> info.
> - merged documentation update, where the current documentation doesn't mention
> AnonHugePages, so it's also added.
> ---
> Documentation/filesystems/proc.txt | 7 +++++--
> fs/proc/task_mmu.c | 29 +++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+), 2 deletions(-)
>
> diff --git v4.2-rc4/Documentation/filesystems/proc.txt v4.2-rc4_patched/Documentation/filesystems/proc.txt
> index 6f7fafde0884..22e40211ef64 100644
> --- v4.2-rc4/Documentation/filesystems/proc.txt
> +++ v4.2-rc4_patched/Documentation/filesystems/proc.txt
> @@ -423,6 +423,8 @@ Private_Clean: 0 kB
> Private_Dirty: 0 kB
> Referenced: 892 kB
> Anonymous: 0 kB
> +AnonHugePages: 0 kB
> +HugetlbPages: 0 kB
> Swap: 0 kB
> KernelPageSize: 4 kB
> MMUPageSize: 4 kB
> @@ -440,8 +442,9 @@ indicates the amount of memory currently marked as referenced or accessed.
> "Anonymous" shows the amount of memory that does not belong to any file. Even
> a mapping associated with a file may contain anonymous pages: when MAP_PRIVATE
> and a page is modified, the file page is replaced by a private anonymous copy.
> -"Swap" shows how much would-be-anonymous memory is also used, but out on
> -swap.
> +"AnonHugePages" shows the ammount of memory backed by transparent hugepage.
> +"HugetlbPages" shows the ammount of memory backed by hugetlbfs page.
> +"Swap" shows how much would-be-anonymous memory is also used, but out on swap.
There is no distinction between "private" and "shared" in this "huge page" accounting right?
Would it be possible to account for the huge pages in the {Private,Shared}_{Clean,Dirty} fields?
Or otherwise split the huge page accounting into shared/private?
thanks!
Pádraig.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> |
|---|---|
| Date | 2015-09-07 04:30 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <q5UlY-wp-1@gated-at.bofh.it> |
| In reply to | #1219887 |
T24gTW9uLCBTZXAgMDcsIDIwMTUgYXQgMDI6Mjk6NTNBTSArMDEwMCwgUMOhZHJhaWcgQnJhZHkg d3JvdGU6DQo+IE9uIDIwLzA4LzE1IDA5OjI2LCBOYW95YSBIb3JpZ3VjaGkgd3JvdGU6DQo+ID4g Q3VycmVudGx5IC9wcm9jL1BJRC9zbWFwcyBwcm92aWRlcyBubyB1c2FnZSBpbmZvIGZvciB2bWEo Vk1fSFVHRVRMQiksIHdoaWNoDQo+ID4gaXMgaW5jb252ZW5pZW50IHdoZW4gd2Ugd2FudCB0byBr bm93IHBlci10YXNrIG9yIHBlci12bWEgYmFzZSBodWdldGxiIHVzYWdlLg0KPiA+IFRvIHNvbHZl IHRoaXMsIHRoaXMgcGF0Y2ggYWRkcyBhIG5ldyBsaW5lIGZvciBodWdldGxiIHVzYWdlIGxpa2Ug YmVsb3c6DQo+ID4gDQo+ID4gICBTaXplOiAgICAgICAgICAgICAgMjA0ODAga0INCj4gPiAgIFJz czogICAgICAgICAgICAgICAgICAgMCBrQg0KPiA+ICAgUHNzOiAgICAgICAgICAgICAgICAgICAw IGtCDQo+ID4gICBTaGFyZWRfQ2xlYW46ICAgICAgICAgIDAga0INCj4gPiAgIFNoYXJlZF9EaXJ0 eTogICAgICAgICAgMCBrQg0KPiA+ICAgUHJpdmF0ZV9DbGVhbjogICAgICAgICAwIGtCDQo+ID4g ICBQcml2YXRlX0RpcnR5OiAgICAgICAgIDAga0INCj4gPiAgIFJlZmVyZW5jZWQ6ICAgICAgICAg ICAgMCBrQg0KPiA+ICAgQW5vbnltb3VzOiAgICAgICAgICAgICAwIGtCDQo+ID4gICBBbm9uSHVn ZVBhZ2VzOiAgICAgICAgIDAga0INCj4gPiAgIEh1Z2V0bGJQYWdlczogICAgICAxODQzMiBrQg0K PiA+ICAgU3dhcDogICAgICAgICAgICAgICAgICAwIGtCDQo+ID4gICBLZXJuZWxQYWdlU2l6ZTog ICAgIDIwNDgga0INCj4gPiAgIE1NVVBhZ2VTaXplOiAgICAgICAgMjA0OCBrQg0KPiA+ICAgTG9j a2VkOiAgICAgICAgICAgICAgICAwIGtCDQo+ID4gICBWbUZsYWdzOiByZCB3ciBtciBtdyBtZSBk ZSBodA0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IE5hb3lhIEhvcmlndWNoaSA8bi1ob3JpZ3Vj aGlAYWguanAubmVjLmNvbT4NCj4gPiBBY2tlZC1ieTogSm9lcm4gRW5nZWwgPGpvZXJuQGxvZ2Zz Lm9yZz4NCj4gPiBBY2tlZC1ieTogRGF2aWQgUmllbnRqZXMgPHJpZW50amVzQGdvb2dsZS5jb20+ DQo+ID4gLS0tDQo+ID4gdjMgLT4gdjQ6DQo+ID4gLSBzdXNwZW5kIEFja2VkLWJ5IHRhZyBiZWNh dXNlIHYzLT52NCBjaGFuZ2UgaXMgbm90IHRyaXZpYWwNCj4gPiAtIEkgc3RhdGVkIGluIHByZXZp b3VzIGRpc2N1c3Npb24gdGhhdCBIdWdldGxiUGFnZXMgbGluZSBjYW4gY29udGFpbiBwYWdlDQo+ ID4gICBzaXplIGluZm8sIGJ1dCB0aGF0J3Mgbm90IG5lY2Vzc2FyeSBiZWNhdXNlIHdlIGFscmVh ZHkgaGF2ZSBLZXJuZWxQYWdlU2l6ZQ0KPiA+ICAgaW5mby4NCj4gPiAtIG1lcmdlZCBkb2N1bWVu dGF0aW9uIHVwZGF0ZSwgd2hlcmUgdGhlIGN1cnJlbnQgZG9jdW1lbnRhdGlvbiBkb2Vzbid0IG1l bnRpb24NCj4gPiAgIEFub25IdWdlUGFnZXMsIHNvIGl0J3MgYWxzbyBhZGRlZC4NCj4gPiAtLS0N Cj4gPiAgRG9jdW1lbnRhdGlvbi9maWxlc3lzdGVtcy9wcm9jLnR4dCB8ICA3ICsrKysrLS0NCj4g PiAgZnMvcHJvYy90YXNrX21tdS5jICAgICAgICAgICAgICAgICB8IDI5ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrDQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IHY0LjItcmM0L0RvY3VtZW50YXRp b24vZmlsZXN5c3RlbXMvcHJvYy50eHQgdjQuMi1yYzRfcGF0Y2hlZC9Eb2N1bWVudGF0aW9uL2Zp bGVzeXN0ZW1zL3Byb2MudHh0DQo+ID4gaW5kZXggNmY3ZmFmZGUwODg0Li4yMmU0MDIxMWVmNjQg MTAwNjQ0DQo+ID4gLS0tIHY0LjItcmM0L0RvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvcHJvYy50 eHQNCj4gPiArKysgdjQuMi1yYzRfcGF0Y2hlZC9Eb2N1bWVudGF0aW9uL2ZpbGVzeXN0ZW1zL3By b2MudHh0DQo+ID4gQEAgLTQyMyw2ICs0MjMsOCBAQCBQcml2YXRlX0NsZWFuOiAgICAgICAgIDAg a0INCj4gPiAgUHJpdmF0ZV9EaXJ0eTogICAgICAgICAwIGtCDQo+ID4gIFJlZmVyZW5jZWQ6ICAg ICAgICAgIDg5MiBrQg0KPiA+ICBBbm9ueW1vdXM6ICAgICAgICAgICAgIDAga0INCj4gPiArQW5v bkh1Z2VQYWdlczogICAgICAgICAwIGtCDQo+ID4gK0h1Z2V0bGJQYWdlczogICAgICAgICAgMCBr Qg0KPiA+ICBTd2FwOiAgICAgICAgICAgICAgICAgIDAga0INCj4gPiAgS2VybmVsUGFnZVNpemU6 ICAgICAgICA0IGtCDQo+ID4gIE1NVVBhZ2VTaXplOiAgICAgICAgICAgNCBrQg0KPiA+IEBAIC00 NDAsOCArNDQyLDkgQEAgaW5kaWNhdGVzIHRoZSBhbW91bnQgb2YgbWVtb3J5IGN1cnJlbnRseSBt YXJrZWQgYXMgcmVmZXJlbmNlZCBvciBhY2Nlc3NlZC4NCj4gPiAgIkFub255bW91cyIgc2hvd3Mg dGhlIGFtb3VudCBvZiBtZW1vcnkgdGhhdCBkb2VzIG5vdCBiZWxvbmcgdG8gYW55IGZpbGUuICBF dmVuDQo+ID4gIGEgbWFwcGluZyBhc3NvY2lhdGVkIHdpdGggYSBmaWxlIG1heSBjb250YWluIGFu b255bW91cyBwYWdlczogd2hlbiBNQVBfUFJJVkFURQ0KPiA+ICBhbmQgYSBwYWdlIGlzIG1vZGlm aWVkLCB0aGUgZmlsZSBwYWdlIGlzIHJlcGxhY2VkIGJ5IGEgcHJpdmF0ZSBhbm9ueW1vdXMgY29w eS4NCj4gPiAtIlN3YXAiIHNob3dzIGhvdyBtdWNoIHdvdWxkLWJlLWFub255bW91cyBtZW1vcnkg aXMgYWxzbyB1c2VkLCBidXQgb3V0IG9uDQo+ID4gLXN3YXAuDQo+ID4gKyJBbm9uSHVnZVBhZ2Vz IiBzaG93cyB0aGUgYW1tb3VudCBvZiBtZW1vcnkgYmFja2VkIGJ5IHRyYW5zcGFyZW50IGh1Z2Vw YWdlLg0KPiA+ICsiSHVnZXRsYlBhZ2VzIiBzaG93cyB0aGUgYW1tb3VudCBvZiBtZW1vcnkgYmFj a2VkIGJ5IGh1Z2V0bGJmcyBwYWdlLg0KPiA+ICsiU3dhcCIgc2hvd3MgaG93IG11Y2ggd291bGQt YmUtYW5vbnltb3VzIG1lbW9yeSBpcyBhbHNvIHVzZWQsIGJ1dCBvdXQgb24gc3dhcC4NCj4gDQo+ IFRoZXJlIGlzIG5vIGRpc3RpbmN0aW9uIGJldHdlZW4gInByaXZhdGUiIGFuZCAic2hhcmVkIiBp biB0aGlzICJodWdlIHBhZ2UiIGFjY291bnRpbmcgcmlnaHQ/DQoNClJpZ2h0IGZvciBjdXJyZW50 IHZlcnNpb24uIEFuZCBJIHRoaW5rIHRoYXQgcHJpdmF0ZS9zaGFyZWQgZGlzdGluY3Rpb24NCmdp dmVzIHNvbWUgaGVscC4NCg0KPiBXb3VsZCBpdCBiZSBwb3NzaWJsZSB0byBhY2NvdW50IGZvciB0 aGUgaHVnZSBwYWdlcyBpbiB0aGUge1ByaXZhdGUsU2hhcmVkfV97Q2xlYW4sRGlydHl9IGZpZWxk cz8NCj4gT3Igb3RoZXJ3aXNlIHNwbGl0IHRoZSBodWdlIHBhZ2UgYWNjb3VudGluZyBpbnRvIHNo YXJlZC9wcml2YXRlPw0KDQpBcyBmb3IgY2xlYW4vZGlydHkgZGlzdGluY3Rpb24sIEknbSBub3Qg c3VyZSBob3cgaXQncyB3b3J0aHdoaWxlIGJlY2F1c2UNCmh1Z2V0bGIgcGFnZXMgYXJlIGFsd2F5 cyBvbiBtZW1vcnkgYW5kIG5ldmVyIHN3YXBwZWQgb3V0ICh1c2Vyc3BhY2UgZG9lc24ndA0KY2Fy ZSBhYm91dCBkaXJ0aW5lc3Mgb2YgaHVnZXRsYj8pLg0KDQpBY2NvcmRpbmcgdG8gY29tbWl0IGxv ZyBvZiBjb21taXQgYjRkMWQ5OWZkZDhiICgiaHVnZXRsYjogaGFuZGxlIHVwZGF0aW5nDQpvZiBB Q0NFU1NFRCBhbmQgRElSVFkgaW4gaHVnZXRsYl9mYXVsdCgpIiksIGRpcnR5IGJpdCBvZiBodWdl dGxiIGlzIG1haW50YWluZWQNCnRvIG1ha2UgYXJjaC1zcGVjaWZpYyBUTEIgaGFuZGxpbmcgY29u dmVuaWVudC4gSXQgbG9va3MgcHVyZWx5IGtlcm5lbC1pbnRlcm5hbCwNCnNvIEkgdGhpbmsgd2Ug ZG9uJ3QgaGF2ZSB0byBleHBvc2UgaXQuDQoNClRoYW5rcywNCk5hb3lhIEhvcmlndWNoaQ== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> |
|---|---|
| Date | 2015-09-07 08:50 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <q5YpA-6fh-19@gated-at.bofh.it> |
| In reply to | #1219896 |
T24gTW9uLCBTZXAgMDcsIDIwMTUgYXQgMDI6MjM6NDRBTSArMDAwMCwgSG9yaWd1Y2hpIE5hb3lh KOWggOWPoyDnm7TkuZ8pIHdyb3RlOg0KPiBPbiBNb24sIFNlcCAwNywgMjAxNSBhdCAwMjoyOTo1 M0FNICswMTAwLCBQw6FkcmFpZyBCcmFkeSB3cm90ZToNCj4gPiBPbiAyMC8wOC8xNSAwOToyNiwg TmFveWEgSG9yaWd1Y2hpIHdyb3RlOg0KPiA+ID4gQ3VycmVudGx5IC9wcm9jL1BJRC9zbWFwcyBw cm92aWRlcyBubyB1c2FnZSBpbmZvIGZvciB2bWEoVk1fSFVHRVRMQiksIHdoaWNoDQo+ID4gPiBp cyBpbmNvbnZlbmllbnQgd2hlbiB3ZSB3YW50IHRvIGtub3cgcGVyLXRhc2sgb3IgcGVyLXZtYSBi YXNlIGh1Z2V0bGIgdXNhZ2UuDQo+ID4gPiBUbyBzb2x2ZSB0aGlzLCB0aGlzIHBhdGNoIGFkZHMg YSBuZXcgbGluZSBmb3IgaHVnZXRsYiB1c2FnZSBsaWtlIGJlbG93Og0KPiA+ID4gDQo+ID4gPiAg IFNpemU6ICAgICAgICAgICAgICAyMDQ4MCBrQg0KPiA+ID4gICBSc3M6ICAgICAgICAgICAgICAg ICAgIDAga0INCj4gPiA+ICAgUHNzOiAgICAgICAgICAgICAgICAgICAwIGtCDQo+ID4gPiAgIFNo YXJlZF9DbGVhbjogICAgICAgICAgMCBrQg0KPiA+ID4gICBTaGFyZWRfRGlydHk6ICAgICAgICAg IDAga0INCj4gPiA+ICAgUHJpdmF0ZV9DbGVhbjogICAgICAgICAwIGtCDQo+ID4gPiAgIFByaXZh dGVfRGlydHk6ICAgICAgICAgMCBrQg0KPiA+ID4gICBSZWZlcmVuY2VkOiAgICAgICAgICAgIDAg a0INCj4gPiA+ICAgQW5vbnltb3VzOiAgICAgICAgICAgICAwIGtCDQo+ID4gPiAgIEFub25IdWdl UGFnZXM6ICAgICAgICAgMCBrQg0KPiA+ID4gICBIdWdldGxiUGFnZXM6ICAgICAgMTg0MzIga0IN Cj4gPiA+ICAgU3dhcDogICAgICAgICAgICAgICAgICAwIGtCDQo+ID4gPiAgIEtlcm5lbFBhZ2VT aXplOiAgICAgMjA0OCBrQg0KPiA+ID4gICBNTVVQYWdlU2l6ZTogICAgICAgIDIwNDgga0INCj4g PiA+ICAgTG9ja2VkOiAgICAgICAgICAgICAgICAwIGtCDQo+ID4gPiAgIFZtRmxhZ3M6IHJkIHdy IG1yIG13IG1lIGRlIGh0DQo+ID4gPiANCj4gPiA+IFNpZ25lZC1vZmYtYnk6IE5hb3lhIEhvcmln dWNoaSA8bi1ob3JpZ3VjaGlAYWguanAubmVjLmNvbT4NCj4gPiA+IEFja2VkLWJ5OiBKb2VybiBF bmdlbCA8am9lcm5AbG9nZnMub3JnPg0KPiA+ID4gQWNrZWQtYnk6IERhdmlkIFJpZW50amVzIDxy aWVudGplc0Bnb29nbGUuY29tPg0KPiA+ID4gLS0tDQo+ID4gPiB2MyAtPiB2NDoNCj4gPiA+IC0g c3VzcGVuZCBBY2tlZC1ieSB0YWcgYmVjYXVzZSB2My0+djQgY2hhbmdlIGlzIG5vdCB0cml2aWFs DQo+ID4gPiAtIEkgc3RhdGVkIGluIHByZXZpb3VzIGRpc2N1c3Npb24gdGhhdCBIdWdldGxiUGFn ZXMgbGluZSBjYW4gY29udGFpbiBwYWdlDQo+ID4gPiAgIHNpemUgaW5mbywgYnV0IHRoYXQncyBu b3QgbmVjZXNzYXJ5IGJlY2F1c2Ugd2UgYWxyZWFkeSBoYXZlIEtlcm5lbFBhZ2VTaXplDQo+ID4g PiAgIGluZm8uDQo+ID4gPiAtIG1lcmdlZCBkb2N1bWVudGF0aW9uIHVwZGF0ZSwgd2hlcmUgdGhl IGN1cnJlbnQgZG9jdW1lbnRhdGlvbiBkb2Vzbid0IG1lbnRpb24NCj4gPiA+ICAgQW5vbkh1Z2VQ YWdlcywgc28gaXQncyBhbHNvIGFkZGVkLg0KPiA+ID4gLS0tDQo+ID4gPiAgRG9jdW1lbnRhdGlv bi9maWxlc3lzdGVtcy9wcm9jLnR4dCB8ICA3ICsrKysrLS0NCj4gPiA+ICBmcy9wcm9jL3Rhc2tf bW11LmMgICAgICAgICAgICAgICAgIHwgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysN Cj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p DQo+ID4gPiANCj4gPiA+IGRpZmYgLS1naXQgdjQuMi1yYzQvRG9jdW1lbnRhdGlvbi9maWxlc3lz dGVtcy9wcm9jLnR4dCB2NC4yLXJjNF9wYXRjaGVkL0RvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMv cHJvYy50eHQNCj4gPiA+IGluZGV4IDZmN2ZhZmRlMDg4NC4uMjJlNDAyMTFlZjY0IDEwMDY0NA0K PiA+ID4gLS0tIHY0LjItcmM0L0RvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvcHJvYy50eHQNCj4g PiA+ICsrKyB2NC4yLXJjNF9wYXRjaGVkL0RvY3VtZW50YXRpb24vZmlsZXN5c3RlbXMvcHJvYy50 eHQNCj4gPiA+IEBAIC00MjMsNiArNDIzLDggQEAgUHJpdmF0ZV9DbGVhbjogICAgICAgICAwIGtC DQo+ID4gPiAgUHJpdmF0ZV9EaXJ0eTogICAgICAgICAwIGtCDQo+ID4gPiAgUmVmZXJlbmNlZDog ICAgICAgICAgODkyIGtCDQo+ID4gPiAgQW5vbnltb3VzOiAgICAgICAgICAgICAwIGtCDQo+ID4g PiArQW5vbkh1Z2VQYWdlczogICAgICAgICAwIGtCDQo+ID4gPiArSHVnZXRsYlBhZ2VzOiAgICAg ICAgICAwIGtCDQo+ID4gPiAgU3dhcDogICAgICAgICAgICAgICAgICAwIGtCDQo+ID4gPiAgS2Vy bmVsUGFnZVNpemU6ICAgICAgICA0IGtCDQo+ID4gPiAgTU1VUGFnZVNpemU6ICAgICAgICAgICA0 IGtCDQo+ID4gPiBAQCAtNDQwLDggKzQ0Miw5IEBAIGluZGljYXRlcyB0aGUgYW1vdW50IG9mIG1l bW9yeSBjdXJyZW50bHkgbWFya2VkIGFzIHJlZmVyZW5jZWQgb3IgYWNjZXNzZWQuDQo+ID4gPiAg IkFub255bW91cyIgc2hvd3MgdGhlIGFtb3VudCBvZiBtZW1vcnkgdGhhdCBkb2VzIG5vdCBiZWxv bmcgdG8gYW55IGZpbGUuICBFdmVuDQo+ID4gPiAgYSBtYXBwaW5nIGFzc29jaWF0ZWQgd2l0aCBh IGZpbGUgbWF5IGNvbnRhaW4gYW5vbnltb3VzIHBhZ2VzOiB3aGVuIE1BUF9QUklWQVRFDQo+ID4g PiAgYW5kIGEgcGFnZSBpcyBtb2RpZmllZCwgdGhlIGZpbGUgcGFnZSBpcyByZXBsYWNlZCBieSBh IHByaXZhdGUgYW5vbnltb3VzIGNvcHkuDQo+ID4gPiAtIlN3YXAiIHNob3dzIGhvdyBtdWNoIHdv dWxkLWJlLWFub255bW91cyBtZW1vcnkgaXMgYWxzbyB1c2VkLCBidXQgb3V0IG9uDQo+ID4gPiAt c3dhcC4NCj4gPiA+ICsiQW5vbkh1Z2VQYWdlcyIgc2hvd3MgdGhlIGFtbW91bnQgb2YgbWVtb3J5 IGJhY2tlZCBieSB0cmFuc3BhcmVudCBodWdlcGFnZS4NCj4gPiA+ICsiSHVnZXRsYlBhZ2VzIiBz aG93cyB0aGUgYW1tb3VudCBvZiBtZW1vcnkgYmFja2VkIGJ5IGh1Z2V0bGJmcyBwYWdlLg0KPiA+ ID4gKyJTd2FwIiBzaG93cyBob3cgbXVjaCB3b3VsZC1iZS1hbm9ueW1vdXMgbWVtb3J5IGlzIGFs c28gdXNlZCwgYnV0IG91dCBvbiBzd2FwLg0KPiA+IA0KPiA+IFRoZXJlIGlzIG5vIGRpc3RpbmN0 aW9uIGJldHdlZW4gInByaXZhdGUiIGFuZCAic2hhcmVkIiBpbiB0aGlzICJodWdlIHBhZ2UiIGFj Y291bnRpbmcgcmlnaHQ/DQo+IA0KPiBSaWdodCBmb3IgY3VycmVudCB2ZXJzaW9uLiBBbmQgSSB0 aGluayB0aGF0IHByaXZhdGUvc2hhcmVkIGRpc3RpbmN0aW9uDQo+IGdpdmVzIHNvbWUgaGVscC4N Cj4gDQo+ID4gV291bGQgaXQgYmUgcG9zc2libGUgdG8gYWNjb3VudCBmb3IgdGhlIGh1Z2UgcGFn ZXMgaW4gdGhlIHtQcml2YXRlLFNoYXJlZH1fe0NsZWFuLERpcnR5fSBmaWVsZHM/DQo+ID4gT3Ig b3RoZXJ3aXNlIHNwbGl0IHRoZSBodWdlIHBhZ2UgYWNjb3VudGluZyBpbnRvIHNoYXJlZC9wcml2 YXRlPw0KDQpTb3JyeSwgSSBkaWRuJ3QgY2F0Y2ggeW91IHByb3Blcmx5Lg0KSSB0aGluayB0aGF0 IGFjY291bnRpbmcgZm9yIGh1Z2V0bGIgcGFnZXMgc2hvdWxkIGJlIGRvbmUgb25seSB3aXRoIEh1 Z2V0bGJQYWdlcw0Kb3IgYW55IG90aGVyIG5ldyBmaWVsZCBmb3IgaHVnZXRsYiwgaW4gb3JkZXIg bm90IHRvIGJyZWFrIHRoZSBiZWhhdmlvciBvZiBleGlzdGluZw0KZmllbGRzLiBTbyBzcGxpdHRp bmcgSHVnZXRsYlBhZ2VzIGludG8gc2hhcmVkL3ByaXZhdGUgbG9va3MgZ29vZCB0byBtZS4NCg0K VGhhbmtzLA0KTmFveWEgSG9yaWd1Y2hpDQoNCj4gQXMgZm9yIGNsZWFuL2RpcnR5IGRpc3RpbmN0 aW9uLCBJJ20gbm90IHN1cmUgaG93IGl0J3Mgd29ydGh3aGlsZSBiZWNhdXNlDQo+IGh1Z2V0bGIg cGFnZXMgYXJlIGFsd2F5cyBvbiBtZW1vcnkgYW5kIG5ldmVyIHN3YXBwZWQgb3V0ICh1c2Vyc3Bh Y2UgZG9lc24ndA0KPiBjYXJlIGFib3V0IGRpcnRpbmVzcyBvZiBodWdldGxiPykuDQo+IA0KPiBB Y2NvcmRpbmcgdG8gY29tbWl0IGxvZyBvZiBjb21taXQgYjRkMWQ5OWZkZDhiICgiaHVnZXRsYjog aGFuZGxlIHVwZGF0aW5nDQo+IG9mIEFDQ0VTU0VEIGFuZCBESVJUWSBpbiBodWdldGxiX2ZhdWx0 KCkiKSwgZGlydHkgYml0IG9mIGh1Z2V0bGIgaXMgbWFpbnRhaW5lZA0KPiB0byBtYWtlIGFyY2gt c3BlY2lmaWMgVExCIGhhbmRsaW5nIGNvbnZlbmllbnQuIEl0IGxvb2tzIHB1cmVseSBrZXJuZWwt aW50ZXJuYWwsDQo+IHNvIEkgdGhpbmsgd2UgZG9uJ3QgaGF2ZSB0byBleHBvc2UgaXQuDQo+IA0K PiBUaGFua3MsDQo+IE5hb3lhIEhvcmlndWNoaQ== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Pádraig Brady <P@draigBrady.com> |
|---|---|
| Date | 2015-09-07 12:00 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <q61ns-1ZQ-27@gated-at.bofh.it> |
| In reply to | #1219950 |
On 07/09/15 07:46, Naoya Horiguchi wrote:
> On Mon, Sep 07, 2015 at 02:23:44AM +0000, Horiguchi Naoya(堀口 直也) wrote:
>> On Mon, Sep 07, 2015 at 02:29:53AM +0100, Pádraig Brady wrote:
>>> On 20/08/15 09:26, Naoya Horiguchi wrote:
>>>> Currently /proc/PID/smaps provides no usage info for vma(VM_HUGETLB), which
>>>> is inconvenient when we want to know per-task or per-vma base hugetlb usage.
>>>> To solve this, this patch adds a new line for hugetlb usage like below:
>>>>
>>>> Size: 20480 kB
>>>> Rss: 0 kB
>>>> Pss: 0 kB
>>>> Shared_Clean: 0 kB
>>>> Shared_Dirty: 0 kB
>>>> Private_Clean: 0 kB
>>>> Private_Dirty: 0 kB
>>>> Referenced: 0 kB
>>>> Anonymous: 0 kB
>>>> AnonHugePages: 0 kB
>>>> HugetlbPages: 18432 kB
>>>> Swap: 0 kB
>>>> KernelPageSize: 2048 kB
>>>> MMUPageSize: 2048 kB
>>>> Locked: 0 kB
>>>> VmFlags: rd wr mr mw me de ht
>>>>
>>>> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>>>> Acked-by: Joern Engel <joern@logfs.org>
>>>> Acked-by: David Rientjes <rientjes@google.com>
>>>> ---
>>>> v3 -> v4:
>>>> - suspend Acked-by tag because v3->v4 change is not trivial
>>>> - I stated in previous discussion that HugetlbPages line can contain page
>>>> size info, but that's not necessary because we already have KernelPageSize
>>>> info.
>>>> - merged documentation update, where the current documentation doesn't mention
>>>> AnonHugePages, so it's also added.
>>>> ---
>>>> Documentation/filesystems/proc.txt | 7 +++++--
>>>> fs/proc/task_mmu.c | 29 +++++++++++++++++++++++++++++
>>>> 2 files changed, 34 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git v4.2-rc4/Documentation/filesystems/proc.txt v4.2-rc4_patched/Documentation/filesystems/proc.txt
>>>> index 6f7fafde0884..22e40211ef64 100644
>>>> --- v4.2-rc4/Documentation/filesystems/proc.txt
>>>> +++ v4.2-rc4_patched/Documentation/filesystems/proc.txt
>>>> @@ -423,6 +423,8 @@ Private_Clean: 0 kB
>>>> Private_Dirty: 0 kB
>>>> Referenced: 892 kB
>>>> Anonymous: 0 kB
>>>> +AnonHugePages: 0 kB
>>>> +HugetlbPages: 0 kB
>>>> Swap: 0 kB
>>>> KernelPageSize: 4 kB
>>>> MMUPageSize: 4 kB
>>>> @@ -440,8 +442,9 @@ indicates the amount of memory currently marked as referenced or accessed.
>>>> "Anonymous" shows the amount of memory that does not belong to any file. Even
>>>> a mapping associated with a file may contain anonymous pages: when MAP_PRIVATE
>>>> and a page is modified, the file page is replaced by a private anonymous copy.
>>>> -"Swap" shows how much would-be-anonymous memory is also used, but out on
>>>> -swap.
>>>> +"AnonHugePages" shows the ammount of memory backed by transparent hugepage.
>>>> +"HugetlbPages" shows the ammount of memory backed by hugetlbfs page.
>>>> +"Swap" shows how much would-be-anonymous memory is also used, but out on swap.
>>>
>>> There is no distinction between "private" and "shared" in this "huge page" accounting right?
>>
>> Right for current version. And I think that private/shared distinction
>> gives some help.
>>
>>> Would it be possible to account for the huge pages in the {Private,Shared}_{Clean,Dirty} fields?
>>> Or otherwise split the huge page accounting into shared/private?
>
> Sorry, I didn't catch you properly.
> I think that accounting for hugetlb pages should be done only with HugetlbPages
> or any other new field for hugetlb, in order not to break the behavior of existing
> fields.
On a more general note I'd be inclined to just account
for hugetlb pages in Rss and {Private,Shared}_Dirty
and fix any tools that double count.
> So splitting HugetlbPages into shared/private looks good to me.
Yes this is the most compatible solution,
and will allow one to accurately determine
how much core mem a process is using.
thanks!
Pádraig.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Pádraig Brady <P@draigBrady.com> |
|---|---|
| Date | 2015-09-07 13:00 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <q62jw-3kB-9@gated-at.bofh.it> |
| In reply to | #1220033 |
On 07/09/15 10:52, Pádraig Brady wrote:
> On 07/09/15 07:46, Naoya Horiguchi wrote:
>> On Mon, Sep 07, 2015 at 02:23:44AM +0000, Horiguchi Naoya(堀口 直也) wrote:
>>> On Mon, Sep 07, 2015 at 02:29:53AM +0100, Pádraig Brady wrote:
>>>> On 20/08/15 09:26, Naoya Horiguchi wrote:
>>>>> Currently /proc/PID/smaps provides no usage info for vma(VM_HUGETLB), which
>>>>> is inconvenient when we want to know per-task or per-vma base hugetlb usage.
>>>>> To solve this, this patch adds a new line for hugetlb usage like below:
>>>>>
>>>>> Size: 20480 kB
>>>>> Rss: 0 kB
>>>>> Pss: 0 kB
>>>>> Shared_Clean: 0 kB
>>>>> Shared_Dirty: 0 kB
>>>>> Private_Clean: 0 kB
>>>>> Private_Dirty: 0 kB
>>>>> Referenced: 0 kB
>>>>> Anonymous: 0 kB
>>>>> AnonHugePages: 0 kB
>>>>> HugetlbPages: 18432 kB
>>>>> Swap: 0 kB
>>>>> KernelPageSize: 2048 kB
>>>>> MMUPageSize: 2048 kB
>>>>> Locked: 0 kB
>>>>> VmFlags: rd wr mr mw me de ht
>>>>>
>>>>> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>>>>> Acked-by: Joern Engel <joern@logfs.org>
>>>>> Acked-by: David Rientjes <rientjes@google.com>
>>>>> ---
>>>>> v3 -> v4:
>>>>> - suspend Acked-by tag because v3->v4 change is not trivial
>>>>> - I stated in previous discussion that HugetlbPages line can contain page
>>>>> size info, but that's not necessary because we already have KernelPageSize
>>>>> info.
>>>>> - merged documentation update, where the current documentation doesn't mention
>>>>> AnonHugePages, so it's also added.
>>>>> ---
>>>>> Documentation/filesystems/proc.txt | 7 +++++--
>>>>> fs/proc/task_mmu.c | 29 +++++++++++++++++++++++++++++
>>>>> 2 files changed, 34 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git v4.2-rc4/Documentation/filesystems/proc.txt v4.2-rc4_patched/Documentation/filesystems/proc.txt
>>>>> index 6f7fafde0884..22e40211ef64 100644
>>>>> --- v4.2-rc4/Documentation/filesystems/proc.txt
>>>>> +++ v4.2-rc4_patched/Documentation/filesystems/proc.txt
>>>>> @@ -423,6 +423,8 @@ Private_Clean: 0 kB
>>>>> Private_Dirty: 0 kB
>>>>> Referenced: 892 kB
>>>>> Anonymous: 0 kB
>>>>> +AnonHugePages: 0 kB
>>>>> +HugetlbPages: 0 kB
>>>>> Swap: 0 kB
>>>>> KernelPageSize: 4 kB
>>>>> MMUPageSize: 4 kB
>>>>> @@ -440,8 +442,9 @@ indicates the amount of memory currently marked as referenced or accessed.
>>>>> "Anonymous" shows the amount of memory that does not belong to any file. Even
>>>>> a mapping associated with a file may contain anonymous pages: when MAP_PRIVATE
>>>>> and a page is modified, the file page is replaced by a private anonymous copy.
>>>>> -"Swap" shows how much would-be-anonymous memory is also used, but out on
>>>>> -swap.
>>>>> +"AnonHugePages" shows the ammount of memory backed by transparent hugepage.
>>>>> +"HugetlbPages" shows the ammount of memory backed by hugetlbfs page.
>>>>> +"Swap" shows how much would-be-anonymous memory is also used, but out on swap.
>>>>
>>>> There is no distinction between "private" and "shared" in this "huge page" accounting right?
>>>
>>> Right for current version. And I think that private/shared distinction
>>> gives some help.
>>>
>>>> Would it be possible to account for the huge pages in the {Private,Shared}_{Clean,Dirty} fields?
>>>> Or otherwise split the huge page accounting into shared/private?
>>
>> Sorry, I didn't catch you properly.
>> I think that accounting for hugetlb pages should be done only with HugetlbPages
>> or any other new field for hugetlb, in order not to break the behavior of existing
>> fields.
>
> On a more general note I'd be inclined to just account
> for hugetlb pages in Rss and {Private,Shared}_Dirty
> and fix any tools that double count.
By the same argument I presume the existing THP "AnonHugePages" smaps field
is not accounted for in the {Private,Shared}_... fields?
I.E. AnonHugePages may also benefit from splitting to Private/Shared?
thanks,
Pádraig.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> |
|---|---|
| Date | 2015-09-17 12:00 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <q9E8X-8lc-37@gated-at.bofh.it> |
| In reply to | #1220051 |
T24gTW9uLCBTZXAgMDcsIDIwMTUgYXQgMTE6NTI6NDFBTSArMDEwMCwgUMOhZHJhaWcgQnJhZHkg d3JvdGU6DQouLi4NCj4gDQo+IEJ5IHRoZSBzYW1lIGFyZ3VtZW50IEkgcHJlc3VtZSB0aGUgZXhp c3RpbmcgVEhQICJBbm9uSHVnZVBhZ2VzIiBzbWFwcyBmaWVsZA0KPiBpcyBub3QgYWNjb3VudGVk IGZvciBpbiB0aGUge1ByaXZhdGUsU2hhcmVkfV8uLi4gZmllbGRzPw0KPiBJLkUuIEFub25IdWdl UGFnZXMgbWF5IGFsc28gYmVuZWZpdCBmcm9tIHNwbGl0dGluZyB0byBQcml2YXRlL1NoYXJlZD8N Cg0Kc21hcHNfcG1kX2VudHJ5KCkgbm90IG9ubHkgaW5jcmVtZW50cyBtc3MtPmFub255bW91c190 aHAsIGJ1dCBhbHNvIGNhbGxzDQpzbWFwc19hY2NvdW50KCkgd2hpY2ggdXBkYXRlcyBtc3MtPmFu b255bW91cywgbXNzLT5yZWZlcmVuY2VkIGFuZA0KbXNzLT57c2hhcmVkLHByaXZhdGV9X3tjbGVh bixkaXJ0eX0sIHNvIHRocCdzIHNoYXJlZC9wcml2YXRlIGNoYXJhY3RlcmlzdGljDQppcyBpbmNs dWRlZCBpbiBvdGhlciBleGlzdGluZyBmaWVsZHMuDQpJIHRoaW5rIHRoYXQgZXZlbiBpZiB3ZSBr bm93IHRoZSB0aHAtc3BlY2lmaWMgc2hhcmVkL3ByaXZhdGUgcHJvZmlsZXMsIGl0DQptaWdodCBi ZSBoYXJkIHRvIGRvIHNvbWV0aGluZyBiZW5lZmljaWFsIHVzaW5nIHRoYXQgaW5mb3JtYXRpb24s IHNvIEkgZmVlbA0Ka2VlcGluZyB0aGlzIGZpZWxkIGFzLWlzIGlzIG9rIGZvciBub3cuDQoNClRo YW5rcywNCk5hb3lhIEhvcmlndWNoaQ== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| Date | 2015-09-09 17:20 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <q6Pke-6PL-23@gated-at.bofh.it> |
| In reply to | #1210294 |
On 08/20/2015 10:26 AM, Naoya Horiguchi wrote:
> Currently /proc/PID/smaps provides no usage info for vma(VM_HUGETLB), which
> is inconvenient when we want to know per-task or per-vma base hugetlb usage.
> To solve this, this patch adds a new line for hugetlb usage like below:
>
> Size: 20480 kB
> Rss: 0 kB
> Pss: 0 kB
> Shared_Clean: 0 kB
> Shared_Dirty: 0 kB
> Private_Clean: 0 kB
> Private_Dirty: 0 kB
> Referenced: 0 kB
> Anonymous: 0 kB
> AnonHugePages: 0 kB
> HugetlbPages: 18432 kB
> Swap: 0 kB
> KernelPageSize: 2048 kB
> MMUPageSize: 2048 kB
> Locked: 0 kB
> VmFlags: rd wr mr mw me de ht
>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Acked-by: Joern Engel <joern@logfs.org>
> Acked-by: David Rientjes <rientjes@google.com>
Sorry for coming late to this thread. It's a nice improvement, but I
find it somewhat illogical that the per-process stats (status) are more
detailed than the per-mapping stats (smaps) with respect to the size
breakdown. I would expect it to be the other way around. That would
simplify the per-process accounting (I realize this has been a hot topic
already), and allow those who really care to look at smaps.
I'm just not sure about the format in that case. In smaps, a line per
size would probably make more sense. Even in status, the extra
information in parentheses looks somewhat out of place. But of course,
adding shared/private breakdown as suggested would lead to an explosion
of number of lines in that case...
> ---
> v3 -> v4:
> - suspend Acked-by tag because v3->v4 change is not trivial
> - I stated in previous discussion that HugetlbPages line can contain page
> size info, but that's not necessary because we already have KernelPageSize
> info.
> - merged documentation update, where the current documentation doesn't mention
> AnonHugePages, so it's also added.
> ---
> Documentation/filesystems/proc.txt | 7 +++++--
> fs/proc/task_mmu.c | 29 +++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+), 2 deletions(-)
>
> diff --git v4.2-rc4/Documentation/filesystems/proc.txt v4.2-rc4_patched/Documentation/filesystems/proc.txt
> index 6f7fafde0884..22e40211ef64 100644
> --- v4.2-rc4/Documentation/filesystems/proc.txt
> +++ v4.2-rc4_patched/Documentation/filesystems/proc.txt
> @@ -423,6 +423,8 @@ Private_Clean: 0 kB
> Private_Dirty: 0 kB
> Referenced: 892 kB
> Anonymous: 0 kB
> +AnonHugePages: 0 kB
> +HugetlbPages: 0 kB
> Swap: 0 kB
> KernelPageSize: 4 kB
> MMUPageSize: 4 kB
> @@ -440,8 +442,9 @@ indicates the amount of memory currently marked as referenced or accessed.
> "Anonymous" shows the amount of memory that does not belong to any file. Even
> a mapping associated with a file may contain anonymous pages: when MAP_PRIVATE
> and a page is modified, the file page is replaced by a private anonymous copy.
> -"Swap" shows how much would-be-anonymous memory is also used, but out on
> -swap.
> +"AnonHugePages" shows the ammount of memory backed by transparent hugepage.
> +"HugetlbPages" shows the ammount of memory backed by hugetlbfs page.
> +"Swap" shows how much would-be-anonymous memory is also used, but out on swap.
>
> "VmFlags" field deserves a separate description. This member represents the kernel
> flags associated with the particular virtual memory area in two letter encoded
> diff --git v4.2-rc4/fs/proc/task_mmu.c v4.2-rc4_patched/fs/proc/task_mmu.c
> index ca1e091881d4..2c37938b82ee 100644
> --- v4.2-rc4/fs/proc/task_mmu.c
> +++ v4.2-rc4_patched/fs/proc/task_mmu.c
> @@ -445,6 +445,7 @@ struct mem_size_stats {
> unsigned long anonymous;
> unsigned long anonymous_thp;
> unsigned long swap;
> + unsigned long hugetlb;
> u64 pss;
> };
>
> @@ -610,12 +611,38 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma)
> seq_putc(m, '\n');
> }
>
> +#ifdef CONFIG_HUGETLB_PAGE
> +static int smaps_hugetlb_range(pte_t *pte, unsigned long hmask,
> + unsigned long addr, unsigned long end,
> + struct mm_walk *walk)
> +{
> + struct mem_size_stats *mss = walk->private;
> + struct vm_area_struct *vma = walk->vma;
> + struct page *page = NULL;
> +
> + if (pte_present(*pte)) {
> + page = vm_normal_page(vma, addr, *pte);
> + } else if (is_swap_pte(*pte)) {
> + swp_entry_t swpent = pte_to_swp_entry(*pte);
> +
> + if (is_migration_entry(swpent))
> + page = migration_entry_to_page(swpent);
> + }
> + if (page)
> + mss->hugetlb += huge_page_size(hstate_vma(vma));
> + return 0;
> +}
> +#endif /* HUGETLB_PAGE */
> +
> static int show_smap(struct seq_file *m, void *v, int is_pid)
> {
> struct vm_area_struct *vma = v;
> struct mem_size_stats mss;
> struct mm_walk smaps_walk = {
> .pmd_entry = smaps_pte_range,
> +#ifdef CONFIG_HUGETLB_PAGE
> + .hugetlb_entry = smaps_hugetlb_range,
> +#endif
> .mm = vma->vm_mm,
> .private = &mss,
> };
> @@ -637,6 +664,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid)
> "Referenced: %8lu kB\n"
> "Anonymous: %8lu kB\n"
> "AnonHugePages: %8lu kB\n"
> + "HugetlbPages: %8lu kB\n"
> "Swap: %8lu kB\n"
> "KernelPageSize: %8lu kB\n"
> "MMUPageSize: %8lu kB\n"
> @@ -651,6 +679,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid)
> mss.referenced >> 10,
> mss.anonymous >> 10,
> mss.anonymous_thp >> 10,
> + mss.hugetlb >> 10,
> mss.swap >> 10,
> vma_kernel_pagesize(vma) >> 10,
> vma_mmu_pagesize(vma) >> 10,
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | David Rientjes <rientjes@google.com> |
|---|---|
| Date | 2015-09-10 00:20 +0200 |
| Subject | Re: [PATCH v5 1/2] mm: hugetlb: proc: add HugetlbPages field to /proc/PID/smaps |
| Message-ID | <q6VSG-7Nj-13@gated-at.bofh.it> |
| In reply to | #1221523 |
On Wed, 9 Sep 2015, Vlastimil Babka wrote: > On 08/20/2015 10:26 AM, Naoya Horiguchi wrote: > > Currently /proc/PID/smaps provides no usage info for vma(VM_HUGETLB), which > > is inconvenient when we want to know per-task or per-vma base hugetlb usage. > > To solve this, this patch adds a new line for hugetlb usage like below: > > > > Size: 20480 kB > > Rss: 0 kB > > Pss: 0 kB > > Shared_Clean: 0 kB > > Shared_Dirty: 0 kB > > Private_Clean: 0 kB > > Private_Dirty: 0 kB > > Referenced: 0 kB > > Anonymous: 0 kB > > AnonHugePages: 0 kB > > HugetlbPages: 18432 kB > > Swap: 0 kB > > KernelPageSize: 2048 kB > > MMUPageSize: 2048 kB > > Locked: 0 kB > > VmFlags: rd wr mr mw me de ht > > > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > > Acked-by: Joern Engel <joern@logfs.org> > > Acked-by: David Rientjes <rientjes@google.com> > > Sorry for coming late to this thread. It's a nice improvement, but I find it > somewhat illogical that the per-process stats (status) are more detailed than > the per-mapping stats (smaps) with respect to the size breakdown. I would > expect it to be the other way around. That would simplify the per-process > accounting (I realize this has been a hot topic already), and allow those who > really care to look at smaps. > Smaps shows the pagesize for the hugepage of the vma and the rss, I believe you have all the information needed. Some distributions also change smaps to only be readable by the owner or root for security reasons. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web