Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219845 > unrolled thread

[PATCH 1/3] Staging: rtl8712: Replace memcpy by ether_addr_copy

Started byShraddha Barke <shraddha.6596@gmail.com>
First post2015-09-06 21:10 +0200
Last post2015-09-06 21:40 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/3] Staging: rtl8712: Replace memcpy by ether_addr_copy Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-06 21:10 +0200
    [PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-06 21:10 +0200
      Re: [PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy Larry Finger <Larry.Finger@lwfinger.net> - 2015-09-06 21:40 +0200
    Re: [PATCH 1/3] Staging: rtl8712: Replace memcpy by ether_addr_copy Larry Finger <Larry.Finger@lwfinger.net> - 2015-09-06 21:40 +0200

#1219845 — [PATCH 1/3] Staging: rtl8712: Replace memcpy by ether_addr_copy

FromShraddha Barke <shraddha.6596@gmail.com>
Date2015-09-06 21:10 +0200
Subject[PATCH 1/3] Staging: rtl8712: Replace memcpy by ether_addr_copy
Message-ID<q5Nua-7Ec-7@gated-at.bofh.it>
This patch replaces memcpy by ethr_addr_copy

The change was made using Coccinelle

@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
index 77f01bf..76c1cfe 100644
--- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
+++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
@@ -167,7 +167,7 @@ static int mp_start_test(struct _adapter *padapter)
 	int res = _SUCCESS;
 
 	/* 3 1. initialize a new struct wlan_bssid_ex */
-	memcpy(bssid.MacAddress, pmppriv->network_macaddr, ETH_ALEN);
+	ether_addr_copy(bssid.MacAddress, pmppriv->network_macaddr);
 	bssid.Ssid.SsidLength = 16;
 	memcpy(bssid.Ssid.Ssid, (unsigned char *)"mp_pseudo_adhoc",
 		bssid.Ssid.SsidLength);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1219846 — [PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy

FromShraddha Barke <shraddha.6596@gmail.com>
Date2015-09-06 21:10 +0200
Subject[PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy
Message-ID<q5Nub-7Ec-25@gated-at.bofh.it>
In reply to#1219845
The patch replaces memcpy with ethr_addr_copy

The changes were applied using the following coccinelle
rule:
@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
index 86f52ac..cf243fe 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
@@ -122,8 +122,8 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,
 
 		eth_zero_addr(wrqu->ap_addr.sa_data);
 	else
-		memcpy(wrqu->ap_addr.sa_data,
-		       ieee->current_network.bssid, ETH_ALEN);
+		ether_addr_copy(wrqu->ap_addr.sa_data,
+				ieee->current_network.bssid);
 
 	spin_unlock_irqrestore(&ieee->lock, flags);
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1219849 — Re: [PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy

FromLarry Finger <Larry.Finger@lwfinger.net>
Date2015-09-06 21:40 +0200
SubjectRe: [PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy
Message-ID<q5NXb-8bW-13@gated-at.bofh.it>
In reply to#1219846
On 09/06/2015 02:04 PM, Shraddha Barke wrote:
> The patch replaces memcpy with ethr_addr_copy
>
> The changes were applied using the following coccinelle
> rule:
> @@ expression e1, e2; @@
> - memcpy(e1, e2, ETH_ALEN);
> + ether_addr_copy(e1, e2);
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>   drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

The same comments apply as in patch 1/3. NACK.

Larry

>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> index 86f52ac..cf243fe 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> @@ -122,8 +122,8 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,
>
>   		eth_zero_addr(wrqu->ap_addr.sa_data);
>   	else
> -		memcpy(wrqu->ap_addr.sa_data,
> -		       ieee->current_network.bssid, ETH_ALEN);
> +		ether_addr_copy(wrqu->ap_addr.sa_data,
> +				ieee->current_network.bssid);
>
>   	spin_unlock_irqrestore(&ieee->lock, flags);
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1219847

FromLarry Finger <Larry.Finger@lwfinger.net>
Date2015-09-06 21:40 +0200
Message-ID<q5NXb-8bW-1@gated-at.bofh.it>
In reply to#1219845
On 09/06/2015 02:04 PM, Shraddha Barke wrote:
> This patch replaces memcpy by ethr_addr_copy
>
> The change was made using Coccinelle
>
> @@ expression e1, e2; @@
> - memcpy(e1, e2, ETH_ALEN);
> + ether_addr_copy(e1, e2);
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>   drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Your commit message has a typo.

More seriously, ether_addr_copy() requires that both arguments be u16 aligned. 
This condition is not hard to meet, but I see no indication in your commit 
message that you have checked this requirement. As a result, I must NACK this patch.

Coccinelle is a wonderful tool, but the user must exercise judgment when 
applying the results.

Larry

Larry

>
> diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
> index 77f01bf..76c1cfe 100644
> --- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
> +++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.c
> @@ -167,7 +167,7 @@ static int mp_start_test(struct _adapter *padapter)
>   	int res = _SUCCESS;
>
>   	/* 3 1. initialize a new struct wlan_bssid_ex */
> -	memcpy(bssid.MacAddress, pmppriv->network_macaddr, ETH_ALEN);
> +	ether_addr_copy(bssid.MacAddress, pmppriv->network_macaddr);
>   	bssid.Ssid.SsidLength = 16;
>   	memcpy(bssid.Ssid.Ssid, (unsigned char *)"mp_pseudo_adhoc",
>   		bssid.Ssid.SsidLength);
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web