Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1219825 > unrolled thread

[PATCH] block: Fix compiler warnings in blk-merge.c

Back to article view | Back to linux.kernel

Contents

  [PATCH] block: Fix compiler warnings in blk-merge.c Geliang Tang <geliangtang@163.com> - 2015-09-06 17:40 +0200
    Re: [PATCH] block: Fix compiler warnings in blk-merge.c Jens Axboe <axboe@kernel.dk> - 2015-09-08 17:20 +0200

#1219825 — [PATCH] block: Fix compiler warnings in blk-merge.c

Fix the following warnings:

  CC      block/blk-merge.o
In file included from block/blk-merge.c:7:0:
block/blk-merge.c: In function ‘blk_queue_split’:
include/linux/blkdev.h:1368:21: warning: ‘bvprv.bv_offset’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
   ((bprv->bv_offset + bprv->bv_len) & queue_virt_boundary(q));
                     ^
block/blk-merge.c:70:21: note: ‘bvprv.bv_offset’ was declared here
  struct bio_vec bv, bvprv;
                     ^
In file included from block/blk-merge.c:7:0:
include/linux/blkdev.h:1368:21: warning: ‘bvprv.bv_len’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
   ((bprv->bv_offset + bprv->bv_len) & queue_virt_boundary(q));
                     ^
block/blk-merge.c:70:21: note: ‘bvprv.bv_len’ was declared here
  struct bio_vec bv, bvprv;
                     ^
In file included from ./arch/x86/include/asm/page.h:70:0,
                 from ./arch/x86/include/asm/thread_info.h:11,
                 from include/linux/thread_info.h:54,
                 from ./arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:64,
                 from include/linux/spinlock.h:50,
                 from include/linux/seqlock.h:35,
                 from include/linux/time.h:5,
                 from include/linux/stat.h:18,
                 from include/linux/module.h:10,
                 from block/blk-merge.c:5:
include/asm-generic/memory_model.h:52:52: warning: ‘bvprv.bv_page’ may
be used uninitialized in this function [-Wmaybe-uninitialized]
 #define __page_to_pfn(page) (unsigned long)((page) - vmemmap)
                                                    ^
block/blk-merge.c:70:21: note: ‘bvprv.bv_page’ was declared here
  struct bio_vec bv, bvprv;
                     ^

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 block/blk-merge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-merge.c b/block/blk-merge.c
index d088cff..5bd84c8 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -67,7 +67,7 @@ static struct bio *blk_bio_segment_split(struct request_queue *q,
 					 struct bio_set *bs)
 {
 	struct bio *split;
-	struct bio_vec bv, bvprv;
+	struct bio_vec bv, bvprv = { NULL };
 	struct bvec_iter iter;
 	unsigned seg_size = 0, nsegs = 0, sectors = 0;
 	int prev = 0;
-- 
2.3.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1220923

On 09/06/2015 09:24 AM, Geliang Tang wrote:
> Fix the following warnings:
>
>    CC      block/blk-merge.o
> In file included from block/blk-merge.c:7:0:
> block/blk-merge.c: In function ‘blk_queue_split’:
> include/linux/blkdev.h:1368:21: warning: ‘bvprv.bv_offset’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>     ((bprv->bv_offset + bprv->bv_len) & queue_virt_boundary(q));
>                       ^
> block/blk-merge.c:70:21: note: ‘bvprv.bv_offset’ was declared here
>    struct bio_vec bv, bvprv;
>                       ^
> In file included from block/blk-merge.c:7:0:
> include/linux/blkdev.h:1368:21: warning: ‘bvprv.bv_len’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>     ((bprv->bv_offset + bprv->bv_len) & queue_virt_boundary(q));
>                       ^
> block/blk-merge.c:70:21: note: ‘bvprv.bv_len’ was declared here
>    struct bio_vec bv, bvprv;
>                       ^
> In file included from ./arch/x86/include/asm/page.h:70:0,
>                   from ./arch/x86/include/asm/thread_info.h:11,
>                   from include/linux/thread_info.h:54,
>                   from ./arch/x86/include/asm/preempt.h:6,
>                   from include/linux/preempt.h:64,
>                   from include/linux/spinlock.h:50,
>                   from include/linux/seqlock.h:35,
>                   from include/linux/time.h:5,
>                   from include/linux/stat.h:18,
>                   from include/linux/module.h:10,
>                   from block/blk-merge.c:5:
> include/asm-generic/memory_model.h:52:52: warning: ‘bvprv.bv_page’ may
> be used uninitialized in this function [-Wmaybe-uninitialized]
>   #define __page_to_pfn(page) (unsigned long)((page) - vmemmap)
>                                                      ^
> block/blk-merge.c:70:21: note: ‘bvprv.bv_page’ was declared here
>    struct bio_vec bv, bvprv;

There's already a fix queued up for that, which doesn't require bvprv to 
be cleared to 0:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=5014c311baa2b21384321fa4a9f617a92e3e56f0

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web