Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1217744 > unrolled thread
| Started by | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
|---|---|
| First post | 2015-09-02 18:50 +0200 |
| Last post | 2015-09-03 05:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2] cpufreq-dt: add suspend frequency support Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-09-02 18:50 +0200
Re: [PATCH v2] cpufreq-dt: add suspend frequency support Stephen Boyd <sboyd@codeaurora.org> - 2015-09-02 20:10 +0200
Re: [PATCH v2] cpufreq-dt: add suspend frequency support Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-03 05:00 +0200
| From | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
|---|---|
| Date | 2015-09-02 18:50 +0200 |
| Subject | [PATCH v2] cpufreq-dt: add suspend frequency support |
| Message-ID | <q4jou-2g9-13@gated-at.bofh.it> |
Add suspend frequency support and set it to the boot frequency,
this matches what the old exynos-cpufreq driver has been doing.
This patch fixes suspend/resume support on Exynos4412 based
Trats2 board and reboot hang on Exynos4412 based Odroid U3
board.
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Abraham <thomas.ab@samsung.com>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
This patch supersedes "[PATCH] ARM: dts: exynos4412-odroid-*: add
workaround for CPUfreq/reboot issue" one from yesterday.
v2:
- remove superfluous ";"
drivers/cpufreq/cpufreq-dt.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
index c3583cd..c9138c7 100644
--- a/drivers/cpufreq/cpufreq-dt.c
+++ b/drivers/cpufreq/cpufreq-dt.c
@@ -329,6 +329,10 @@ static int cpufreq_init(struct cpufreq_policy *policy)
policy->driver_data = priv;
policy->clk = cpu_clk;
+
+ /* capture boot frequency */
+ policy->suspend_freq = clk_get_rate(cpu_clk) / 1000;
+
ret = cpufreq_table_validate_and_show(policy, freq_table);
if (ret) {
dev_err(cpu_dev, "%s: invalid frequency table: %d\n", __func__,
@@ -419,6 +423,9 @@ static struct cpufreq_driver dt_cpufreq_driver = {
.ready = cpufreq_ready,
.name = "cpufreq-dt",
.attr = cpufreq_dt_attr,
+#ifdef CONFIG_PM
+ .suspend = cpufreq_generic_suspend,
+#endif
};
static int dt_cpufreq_probe(struct platform_device *pdev)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2015-09-02 20:10 +0200 |
| Message-ID | <q4kDU-4f5-3@gated-at.bofh.it> |
| In reply to | #1217744 |
On 09/02/2015 09:47 AM, Bartlomiej Zolnierkiewicz wrote: > Add suspend frequency support and set it to the boot frequency, > this matches what the old exynos-cpufreq driver has been doing. > > This patch fixes suspend/resume support on Exynos4412 based > Trats2 board and reboot hang on Exynos4412 based Odroid U3 > board. > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Thomas Abraham <thomas.ab@samsung.com> > Cc: Javier Martinez Canillas <javier@osg.samsung.com> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > Cc: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > This patch supersedes "[PATCH] ARM: dts: exynos4412-odroid-*: add > workaround for CPUfreq/reboot issue" one from yesterday. What do we do about cpufreq-dt users that don't want to change frequency during suspend? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2015-09-03 05:00 +0200 |
| Message-ID | <q4sUO-7tv-1@gated-at.bofh.it> |
| In reply to | #1217783 |
On 02-09-15, 11:03, Stephen Boyd wrote: > On 09/02/2015 09:47 AM, Bartlomiej Zolnierkiewicz wrote: > > Add suspend frequency support and set it to the boot frequency, > > this matches what the old exynos-cpufreq driver has been doing. > > > > This patch fixes suspend/resume support on Exynos4412 based > > Trats2 board and reboot hang on Exynos4412 based Odroid U3 > > board. > > > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > Cc: Thomas Abraham <thomas.ab@samsung.com> > > Cc: Javier Martinez Canillas <javier@osg.samsung.com> > > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > > Cc: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > --- > > This patch supersedes "[PATCH] ARM: dts: exynos4412-odroid-*: add > > workaround for CPUfreq/reboot issue" one from yesterday. > > What do we do about cpufreq-dt users that don't want to change frequency > during suspend? Again, this should be done via opp-v2 suspend-opp feature instead. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web