Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1217517 > unrolled thread

[PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

Started byZhenzhong Duan <zhenzhong.duan@oracle.com>
First post2015-09-02 13:00 +0200
Last post2015-09-02 13:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range Zhenzhong Duan <zhenzhong.duan@oracle.com> - 2015-09-02 13:00 +0200
    Re: [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range Juergen Gross <jgross@suse.com> - 2015-09-02 13:10 +0200

#1217517 — [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

FromZhenzhong Duan <zhenzhong.duan@oracle.com>
Date2015-09-02 13:00 +0200
Subject[PATCH] xen: fix the check of e_pfn in xen_find_pfn_range
Message-ID<q4dVL-2P4-1@gated-at.bofh.it>
On some numa system, after dom0 up, we see below warning even if there are
enough pfn ranges could be used for remapping.
"Unable to find available pfn range, not remapping identity pages"

Fix it to avoid getting a memory region of zero size in xen_find_pfn_range.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
  arch/x86/xen/setup.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index a3a7546..c11f6b2 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -178,7 +178,7 @@ static unsigned long __init xen_find_pfn_range(
  		e_pfn = PFN_DOWN(entry->addr + entry->size);
  
  		/* We only care about E820 after this */
-		if (e_pfn < *min_pfn)
+		if (e_pfn <= *min_pfn)
  			continue;
  
  		s_pfn = PFN_UP(entry->addr);
-- 
1.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1217527

FromJuergen Gross <jgross@suse.com>
Date2015-09-02 13:10 +0200
Message-ID<q4e5t-3fT-57@gated-at.bofh.it>
In reply to#1217517
On 09/02/2015 12:51 PM, Zhenzhong Duan wrote:
> On some numa system, after dom0 up, we see below warning even if there are
> enough pfn ranges could be used for remapping.
> "Unable to find available pfn range, not remapping identity pages"
>
> Fix it to avoid getting a memory region of zero size in xen_find_pfn_range.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

> ---
>   arch/x86/xen/setup.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index a3a7546..c11f6b2 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -178,7 +178,7 @@ static unsigned long __init xen_find_pfn_range(
>           e_pfn = PFN_DOWN(entry->addr + entry->size);
>
>           /* We only care about E820 after this */
> -        if (e_pfn < *min_pfn)
> +        if (e_pfn <= *min_pfn)
>               continue;
>
>           s_pfn = PFN_UP(entry->addr);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web