Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1216887 > unrolled thread
| Started by | Cyrille Pitchen <cyrille.pitchen@atmel.com> |
|---|---|
| First post | 2015-09-01 16:50 +0200 |
| Last post | 2015-09-03 17:50 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-09-01 16:50 +0200
[PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-09-01 16:50 +0200
Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-09-03 18:00 +0200
[PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-09-01 16:50 +0200
Re: [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-09-03 17:50 +0200
| From | Cyrille Pitchen <cyrille.pitchen@atmel.com> |
|---|---|
| Date | 2015-09-01 16:50 +0200 |
| Subject | [PATCH linux-next v9 0/3] mfd: flexcom: add a driver for Flexcom |
| Message-ID | <q3V2N-13Z-5@gated-at.bofh.it> |
ChangeLog
v9:
- go back to v5 (use the new "atmel,flexcom-mode" DT property).
- fix the name of the spi node in the DT example: from spi@f8034400 to
spi@400
- align the fields of the struct platform_driver atmel_flexcom_driver as
suggested by Lee Jones.
v8:
- fix the name of the spi node in the DT example: from spi@f8034400 to
spi@2,0
- use the return code of op_property_read_u32_index() instead of -EINVAL
to report error.
- add Acked-by from Nicolas Ferre
v7:
- read the operating mode from the very first u32 of the reg property from
the first available child node (should be unique).
- update the DT bindings documentation accordingly.
v6:
- select the operating mode according to the "compatible" DT property of
the first available child node (should be unique).
- remove the "atmel,flexcom-mode" DT property so the need of a header file
defining macros for the possible values of this deprecated property.
v5:
- create a header file containing macros used by DT bindings
- use numeric constants instead of strings to select the Flexcom mode
- change the license to "GPL v2"
- update the DT binding documentation to make it more readable and add
references to USART, SPI and I2C DT binding documentations. remove the
useless label in the Example section.
- change the register prefix from FX_ to FLEX_ to match the Flexcom
programmer datasheet.
- rename some variables to make them more understandable.
v4:
- check clk_prepare_enable() return code in atmel_flexcom_probe()
- add a commit message to the DT binding patch
v3:
- remove MODULE_ALIAS()
- add Acked-by from Boris Brezillon and Alexandre Belloni
v2:
- enhance the documentation of DT bindings and change the way the "ranges"
property is used.
- replace __raw_readl() and __raw_writel() by readl() and writel().
- change the module license to "GPL" for v2 or later
- print the selected flexcom mode after the hardware version
v1:
This series of patches a support to the Atmel Flexcom, a wrapper which
integrates an USART, a SPI controller and a TWI controller. Only one
peripheral can be used at a time. The active function is selected though
the Flexcom Mode Register.
Cyrille Pitchen (3):
mfd: atmel-flexcom: create include file with macros used by DT
bindings
mfd: devicetree: add bindings for Atmel Flexcom
mfd: atmel-flexcom: add a driver for Atmel Flexible Serial
Communication Unit
.../devicetree/bindings/mfd/atmel-flexcom.txt | 67 +++++++++++++
drivers/mfd/Kconfig | 11 +++
drivers/mfd/Makefile | 1 +
drivers/mfd/atmel-flexcom.c | 104 +++++++++++++++++++++
include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++
5 files changed, 199 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
create mode 100644 drivers/mfd/atmel-flexcom.c
create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h
--
1.8.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Cyrille Pitchen <cyrille.pitchen@atmel.com> |
|---|---|
| Date | 2015-09-01 16:50 +0200 |
| Subject | [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom |
| Message-ID | <q3V2N-13Z-7@gated-at.bofh.it> |
| In reply to | #1216887 |
This patch documents the DT bindings for the Atmel Flexcom which will be
introduced by sama5d2x SoCs. These bindings will be used by the actual
Flexcom driver to be sent in another patch.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
.../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
1 file changed, 67 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
new file mode 100644
index 000000000000..fc3511e41542
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
@@ -0,0 +1,67 @@
+* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
+
+The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
+controller and an USART. Only one function can be used at a time and is chosen
+at boot time according to the device tree.
+
+Required properties:
+- compatible: Should be "atmel,sama5d2-flexcom"
+- reg: Should be the offset/length value for Flexcom dedicated
+ I/O registers (without USART, TWI or SPI registers).
+- clocks: Should be the Flexcom peripheral clock from PMC.
+- #address-cells: Should be <1>
+- #size-cells: Should be <1>
+- ranges: Should be one range for the full I/O register region
+ (including USART, TWI and SPI registers).
+- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
+ include/dt-bindings/mfd/atmel-flexcom.h:
+ - ATMEL_FLEXCOM_MODE_USART for USART
+ - ATMEL_FLEXCOM_MODE_SPI for SPI
+ - ATMEL_FLEXCOM_MODE_TWI for I2C
+
+Required child:
+a single child device of type matching the "atmel,flexcom-mode" property.
+
+The reg property of this child should be:
+- <0x200 0x200> for USART
+- <0x400 0x200> for SPI
+- <0x600 0x200> for I2C
+
+The phandle provided by the clocks property of the child is the same as one for
+the Flexcom parent.
+
+Other properties remain unchanged. See documentation of the respective device:
+- ../serial/atmel-usart.txt
+- ../spi/spi_atmel.txt
+- ../i2c/i2c-at91.txt
+
+Example:
+
+flexcom@f8034000 {
+ compatible = "atmel,sama5d2-flexcom";
+ reg = <0xf8034000 0x200>;
+ clocks = <&flx0_clk>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0xf8034000 0x800>;
+ atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
+
+ spi@400 {
+ compatible = "atmel,at91rm9200-spi";
+ reg = <0x400 0x200>;
+ interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flx0_default>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&flx0_clk>;
+ clock-names = "spi_clk";
+ atmel,fifo-size = <32>;
+
+ mtd_dataflash@0 {
+ compatible = "atmel,at25f512b";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ };
+ };
+};
--
1.8.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| Date | 2015-09-03 18:00 +0200 |
| Subject | Re: [PATCH linux-next v9 2/3] mfd: devicetree: add bindings for Atmel Flexcom |
| Message-ID | <q4F5E-83m-25@gated-at.bofh.it> |
| In reply to | #1216888 |
Le 01/09/2015 16:46, Cyrille Pitchen a écrit :
> This patch documents the DT bindings for the Atmel Flexcom which will be
> introduced by sama5d2x SoCs. These bindings will be used by the actual
> Flexcom driver to be sent in another patch.
>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
After all, this approach is far more simple and obvious than the use of
the "reg" property, so coming back to this "atmel,flexcom-mode" option
make a lot of sense.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Bye,
> ---
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> new file mode 100644
> index 000000000000..fc3511e41542
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> @@ -0,0 +1,67 @@
> +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
> +
> +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
> +controller and an USART. Only one function can be used at a time and is chosen
> +at boot time according to the device tree.
> +
> +Required properties:
> +- compatible: Should be "atmel,sama5d2-flexcom"
> +- reg: Should be the offset/length value for Flexcom dedicated
> + I/O registers (without USART, TWI or SPI registers).
> +- clocks: Should be the Flexcom peripheral clock from PMC.
> +- #address-cells: Should be <1>
> +- #size-cells: Should be <1>
> +- ranges: Should be one range for the full I/O register region
> + (including USART, TWI and SPI registers).
> +- atmel,flexcom-mode: Should be one of the 3 following macros as defined in
> + include/dt-bindings/mfd/atmel-flexcom.h:
> + - ATMEL_FLEXCOM_MODE_USART for USART
> + - ATMEL_FLEXCOM_MODE_SPI for SPI
> + - ATMEL_FLEXCOM_MODE_TWI for I2C
> +
> +Required child:
> +a single child device of type matching the "atmel,flexcom-mode" property.
> +
> +The reg property of this child should be:
> +- <0x200 0x200> for USART
> +- <0x400 0x200> for SPI
> +- <0x600 0x200> for I2C
> +
> +The phandle provided by the clocks property of the child is the same as one for
> +the Flexcom parent.
> +
> +Other properties remain unchanged. See documentation of the respective device:
> +- ../serial/atmel-usart.txt
> +- ../spi/spi_atmel.txt
> +- ../i2c/i2c-at91.txt
> +
> +Example:
> +
> +flexcom@f8034000 {
> + compatible = "atmel,sama5d2-flexcom";
> + reg = <0xf8034000 0x200>;
> + clocks = <&flx0_clk>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0xf8034000 0x800>;
> + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_SPI>;
> +
> + spi@400 {
> + compatible = "atmel,at91rm9200-spi";
> + reg = <0x400 0x200>;
> + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flx0_default>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&flx0_clk>;
> + clock-names = "spi_clk";
> + atmel,fifo-size = <32>;
> +
> + mtd_dataflash@0 {
> + compatible = "atmel,at25f512b";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> + };
> +};
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Cyrille Pitchen <cyrille.pitchen@atmel.com> |
|---|---|
| Date | 2015-09-01 16:50 +0200 |
| Subject | [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings |
| Message-ID | <q3V2O-13Z-21@gated-at.bofh.it> |
| In reply to | #1216887 |
This patch defines some macros to be used as value for the "atmel,flexcom-mode" DT property. This value is then written into the Operating Mode (OPMODE) bit field of the Flexcom Mode Register. Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com> --- include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h new file mode 100644 index 000000000000..6728f2851b4d --- /dev/null +++ b/include/dt-bindings/mfd/atmel-flexcom.h @@ -0,0 +1,16 @@ +/* + * This header provides macros for Atmel Flexcom DT bindings. + * + * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen@atmel.com> + * + * GPLv2 only + */ + +#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__ +#define __DT_BINDINGS_ATMEL_FLEXCOM_H__ + +#define ATMEL_FLEXCOM_MODE_USART 1 +#define ATMEL_FLEXCOM_MODE_SPI 2 +#define ATMEL_FLEXCOM_MODE_TWI 3 + +#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */ -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| Date | 2015-09-03 17:50 +0200 |
| Subject | Re: [PATCH linux-next v9 1/3] mfd: atmel-flexcom: create include file with macros used by DT bindings |
| Message-ID | <q4EVX-7Sc-9@gated-at.bofh.it> |
| In reply to | #1216891 |
Le 01/09/2015 16:46, Cyrille Pitchen a écrit : > This patch defines some macros to be used as value for the > "atmel,flexcom-mode" DT property. This value is then written into > the Operating Mode (OPMODE) bit field of the Flexcom Mode Register. > > Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > --- > include/dt-bindings/mfd/atmel-flexcom.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > create mode 100644 include/dt-bindings/mfd/atmel-flexcom.h > > diff --git a/include/dt-bindings/mfd/atmel-flexcom.h b/include/dt-bindings/mfd/atmel-flexcom.h > new file mode 100644 > index 000000000000..6728f2851b4d > --- /dev/null > +++ b/include/dt-bindings/mfd/atmel-flexcom.h > @@ -0,0 +1,16 @@ > +/* > + * This header provides macros for Atmel Flexcom DT bindings. > + * > + * Copyright (C) 2015 Cyrille Pitchen <cyrille.pitchen@atmel.com> > + * > + * GPLv2 only > + */ > + > +#ifndef __DT_BINDINGS_ATMEL_FLEXCOM_H__ > +#define __DT_BINDINGS_ATMEL_FLEXCOM_H__ > + > +#define ATMEL_FLEXCOM_MODE_USART 1 > +#define ATMEL_FLEXCOM_MODE_SPI 2 > +#define ATMEL_FLEXCOM_MODE_TWI 3 > + > +#endif /* __DT_BINDINGS_ATMEL_FLEXCOM_H__ */ > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web