Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1218178 > unrolled thread
| Started by | Andrey Ryabinin <aryabinin@odin.com> |
|---|---|
| First post | 2015-09-03 13:40 +0200 |
| Last post | 2015-09-04 17:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] x86/crypto/ghash-intel: specify context size for ghash async algorithm Andrey Ryabinin <aryabinin@odin.com> - 2015-09-03 13:40 +0200
Re: [PATCH] x86/crypto/ghash-intel: specify context size for ghash async algorithm Herbert Xu <herbert@gondor.apana.org.au> - 2015-09-04 17:30 +0200
| From | Andrey Ryabinin <aryabinin@odin.com> |
|---|---|
| Date | 2015-09-03 13:40 +0200 |
| Subject | [PATCH] x86/crypto/ghash-intel: specify context size for ghash async algorithm |
| Message-ID | <q4B22-2jJ-13@gated-at.bofh.it> |
Currently context size (cra_ctxsize) doesn't specified for
ghash_async_alg. Which means it's zero. Thus crypto_create_tfm()
doesn't allocate needed space for ghash_async_ctx, so any
read/write to ctx (e.g. in ghash_async_init_tfm()) is not valid.
Signed-off-by: Andrey Ryabinin <aryabinin@odin.com>
---
arch/x86/crypto/ghash-clmulni-intel_glue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/crypto/ghash-clmulni-intel_glue.c b/arch/x86/crypto/ghash-clmulni-intel_glue.c
index 64d7cf1..440df0c 100644
--- a/arch/x86/crypto/ghash-clmulni-intel_glue.c
+++ b/arch/x86/crypto/ghash-clmulni-intel_glue.c
@@ -294,6 +294,7 @@ static struct ahash_alg ghash_async_alg = {
.cra_name = "ghash",
.cra_driver_name = "ghash-clmulni",
.cra_priority = 400,
+ .cra_ctxsize = sizeof(struct ghash_async_ctx),
.cra_flags = CRYPTO_ALG_TYPE_AHASH | CRYPTO_ALG_ASYNC,
.cra_blocksize = GHASH_BLOCK_SIZE,
.cra_type = &crypto_ahash_type,
--
2.4.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2015-09-04 17:30 +0200 |
| Subject | Re: [PATCH] x86/crypto/ghash-intel: specify context size for ghash async algorithm |
| Message-ID | <q516a-61Z-11@gated-at.bofh.it> |
| In reply to | #1218178 |
On Thu, Sep 03, 2015 at 02:32:01PM +0300, Andrey Ryabinin wrote: > Currently context size (cra_ctxsize) doesn't specified for > ghash_async_alg. Which means it's zero. Thus crypto_create_tfm() > doesn't allocate needed space for ghash_async_ctx, so any > read/write to ctx (e.g. in ghash_async_init_tfm()) is not valid. > > Signed-off-by: Andrey Ryabinin <aryabinin@odin.com> Patch applied. Thanks! -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web