Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1216131 > unrolled thread
| Started by | Christoffer Dall <christoffer.dall@linaro.org> |
|---|---|
| First post | 2015-08-31 12:20 +0200 |
| Last post | 2015-08-31 12:20 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 3/4] KVM: arm/arm64: check power_off in critical section before VCPU run Christoffer Dall <christoffer.dall@linaro.org> - 2015-08-31 12:20 +0200
| From | Christoffer Dall <christoffer.dall@linaro.org> |
|---|---|
| Date | 2015-08-31 12:20 +0200 |
| Subject | Re: [PATCH v2 3/4] KVM: arm/arm64: check power_off in critical section before VCPU run |
| Message-ID | <q3ulX-4K1-7@gated-at.bofh.it> |
On Fri, Aug 07, 2015 at 06:08:32PM +0200, Eric Auger wrote:
> In case KVM_SET_MP_STATE ioctl is called just after we executed the
> vcpu_sleep check, we can enter the guest although KVM_MP_STATE_STOPPED
> is set. Let's check the power_off state in the critical section,
> just before entering the guest.
I don't think this can happen from the KVM_SET_MP_STATE, because that is
a vcpu ioctl and would therefore require userspace sets this before even
entering the run loop in the kernel, but it could happen at the PSCI
system event preparation.
>
> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> Reported-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
> arch/arm/kvm/arm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> index 4f50be3..cc404a8 100644
> --- a/arch/arm/kvm/arm.c
> +++ b/arch/arm/kvm/arm.c
> @@ -555,7 +555,8 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run)
> run->exit_reason = KVM_EXIT_INTR;
> }
>
> - if (ret <= 0 || need_new_vmid_gen(vcpu->kvm)) {
> + if (ret <= 0 || need_new_vmid_gen(vcpu->kvm) ||
> + vcpu->arch.power_off) {
> local_irq_enable();
> kvm_vgic_sync_hwstate(vcpu);
> preempt_enable();
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web