Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215909 > unrolled thread

Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq functions

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq  functions Guennadi Liakhovetski <g.liakhovetski@gmx.de> - 2015-08-30 13:20 +0200
    Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq functions Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-30 21:40 +0200

#1215909 — Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq functions

On Wed, 29 Jul 2015, Robert Jarzmik wrote:

> From: Robert Jarzmik <robert.jarzmik@intel.com>
> 
> This moves the dma irq handling functions up in the source file, so that
> they are available before DMA preparation functions. It prepares the
> conversion to DMA engine, where the descriptors are populated with these
> functions as callbacks.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@intel.com>
> ---
> Since v1: fixed prototypes change
> ---
>  drivers/media/platform/soc_camera/pxa_camera.c | 42 +++++++++++++++-----------
>  1 file changed, 24 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/platform/soc_camera/pxa_camera.c
> index 39c7e7519b3c..cdfb93aaee43 100644
> --- a/drivers/media/platform/soc_camera/pxa_camera.c
> +++ b/drivers/media/platform/soc_camera/pxa_camera.c
> @@ -313,6 +313,30 @@ static int calculate_dma_sglen(struct scatterlist *sglist, int sglen,

[snip]

> +	pxa_camera_dma_irq(pcdev, DMA_Y);

[snip]

> -	pxa_camera_dma_irq(channel, pcdev, DMA_Y);

This still seems to break compilation to me. Could you compile-test after 
each your patch, please?

Thanks
Guennadi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1215966 — Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq functions

Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:

> This still seems to break compilation to me. Could you compile-test after 
> each your patch, please?
Ah yes. Ill timing, I had sent the v4 before having these comments, so I'll have
to fix it in v5.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web