Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215928 > unrolled thread

Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs() Jarkko Nikula <jarkko.nikula@bitmer.com> - 2015-08-30 16:50 +0200
    Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs() Michael Welling <mwelling@ieee.org> - 2015-08-30 18:50 +0200
      Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs() Mark Brown <broonie@kernel.org> - 2015-08-31 11:00 +0200
        Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs() Michael Welling <mwelling@ieee.org> - 2015-08-31 15:50 +0200
          Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs() Mark Brown <broonie@kernel.org> - 2015-08-31 16:30 +0200

#1215928 — Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

Hi

On 07/24/2015 07:39 PM, Mark Brown wrote:
> On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote:
>> Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without
>> runtime power management requested. Thus the below kernel oops may be
>> generated if a device is accessed after the runtime power management
>> timeout. This patch fixes the problem by requesting runtime power
>> management in omap2_mcspi_set_cs().
>>
>> [   13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09802c
>> [   13.940490] pgd = cfb38000
>> [   13.946594] [fa09802c] *pgd=48011452(bad)
>> [   13.952758] Internal error: : 1028 [#1] PREEMPT ARM
>> [   13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt
>> [   13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363
>> [   13.971801] Hardware name: Nokia RX-51 board
>> [   13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000
>> [   13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c
>> [   13.991485] LR is at spi_set_cs+0x5c/0x60
> 
> Please don't paste entire backtraces into commit messages, they are very
> large and almost entirely noise (for example in this case the entire
> explanation is in the commit message itself).  If you feel a backtrace
> helps clarify things then please present an *edited* highlight of the
> relevant sections.
> present
> 
Is there update to this patch? I don't see such in 4.2.0-rc8+. I hit
this same issue on Nokia N900 WLAN (CONFIG_WL1251=m and
CONFIG_WL1251_SPI=m) and googling lead to this patch which made the WLAN
working.

If you are going to resend this, please feel free to add my tested by:

Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1215943

On Sun, Aug 30, 2015 at 05:45:21PM +0300, Jarkko Nikula wrote:
> Hi
> 
> On 07/24/2015 07:39 PM, Mark Brown wrote:
> > On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote:
> >> Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without
> >> runtime power management requested. Thus the below kernel oops may be
> >> generated if a device is accessed after the runtime power management
> >> timeout. This patch fixes the problem by requesting runtime power
> >> management in omap2_mcspi_set_cs().
> >>
> >> [   13.933959] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09802c
> >> [   13.940490] pgd = cfb38000
> >> [   13.946594] [fa09802c] *pgd=48011452(bad)
> >> [   13.952758] Internal error: : 1028 [#1] PREEMPT ARM
> >> [   13.958862] Modules linked in: tsc2005(+) omap_sham twl4030_wdt omap_wdt
> >> [   13.965332] CPU: 0 PID: 183 Comm: modprobe Not tainted 4.2.0-rc1+ #363
> >> [   13.971801] Hardware name: Nokia RX-51 board
> >> [   13.978302] task: cf572300 ti: cb1f2000 task.ti: cb1f2000
> >> [   13.984924] PC is at omap2_mcspi_set_cs+0x44/0x4c
> >> [   13.991485] LR is at spi_set_cs+0x5c/0x60
> > 
> > Please don't paste entire backtraces into commit messages, they are very
> > large and almost entirely noise (for example in this case the entire
> > explanation is in the commit message itself).  If you feel a backtrace
> > helps clarify things then please present an *edited* highlight of the
> > relevant sections.
> > present
> > 
> Is there update to this patch? I don't see such in 4.2.0-rc8+. I hit
> this same issue on Nokia N900 WLAN (CONFIG_WL1251=m and
> CONFIG_WL1251_SPI=m) and googling lead to this patch which made the WLAN
> working.
> 
> If you are going to resend this, please feel free to add my tested by:
> 
> Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com>

The patch is currently sitting in linux-next.

Not sure why it wasn't merged with 4.2.0-rc8.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1216115

[Multipart message — attachments visible in raw view] — view raw

On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote:

> The patch is currently sitting in linux-next.

> Not sure why it wasn't merged with 4.2.0-rc8.

You didn't indicate that it was a bug fix for Linus rather than a fix
for recent development :(

[toc] | [prev] | [next] | [standalone]

#1216190

On Mon, Aug 31, 2015 at 09:53:55AM +0100, Mark Brown wrote:
> On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote:
> 
> > The patch is currently sitting in linux-next.
> 
> > Not sure why it wasn't merged with 4.2.0-rc8.
> 
> You didn't indicate that it was a bug fix for Linus rather than a fix
> for recent development :(

Sorry, I did not know that it was my responsibility.

How do I indicate this for future reference?

The patch that Sebastian sent said the following:
"
Michael also tested the patch, but have not explicitly written an
Tested-By, so you may want to wait for feedback from him. The patch
should be sent for 4.2-rc, which introduced the regression.
"

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1216221

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 31, 2015 at 08:46:46AM -0500, Michael Welling wrote:
> On Mon, Aug 31, 2015 at 09:53:55AM +0100, Mark Brown wrote:
> > On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote:

> > > The patch is currently sitting in linux-next.

> > > Not sure why it wasn't merged with 4.2.0-rc8.

> > You didn't indicate that it was a bug fix for Linus rather than a fix
> > for recent development :(

Ah, actually it did get applied as a fix - it's just that I didn't send
a pull request before v4.3 got released.  Looking at what's there I
wasn't comfortable with the volume of fixes that arrived and never got
round to picking out those that were most urgent.  Sorry, these things
do happen from time to time I'm afraid especially when I'm travelling,
if something is urgent it's good to verify around -rc6 or so.

> Sorry, I did not know that it was my responsibility.

> How do I indicate this for future reference?

> The patch that Sebastian sent said the following:

> "
> Michael also tested the patch, but have not explicitly written an
> Tested-By, so you may want to wait for feedback from him. The patch
> should be sent for 4.2-rc, which introduced the regression.
> "

That's not in the changelog which is all I have after the patch is
applied (and what I was looking at since I just pulled the commit up by
ID).  If something is in Linus' tree it's often helpful to say
"...introduced in v4.2-rc1" or similar in the changelog.  Though in this
case it wasn't the issue.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web